[v2,0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Message ID	cover.1690733545.git.tanyuan@tinylab.org
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Yuan Tan <tanyuan@tinylab.org> To: w@1wt.eu, thomas@t-8ch.de Cc: falcon@tinylab.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Yuan Tan <tanyuan@tinylab.org> Subject: [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase Date: Mon, 31 Jul 2023 13:50:31 +0800 Message-Id: <cover.1690733545.git.tanyuan@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 Precedence: bulk
Series	tools/nolibc: add pipe(), pipe2() and their testcase \| [v2,0/2] tools/nolibc: add pipe(), pipe2() and their testcase [v2,1/2] tools/nolibc: add pipe() and pipe2() support [v2,2/2] selftests/nolibc: add testcase for pipe

Message ID

cover.1690733545.git.tanyuan@tinylab.org

Headers

Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
 designates 2620:137:e000::1:20 as permitted sender)
 client-ip=2620:137:e000::1:20;
From: Yuan Tan <tanyuan@tinylab.org>
To: w@1wt.eu, thomas@t-8ch.de
Cc: falcon@tinylab.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, Yuan Tan <tanyuan@tinylab.org>
Subject: [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase
Date: Mon, 31 Jul 2023 13:50:31 +0800
Message-Id: <cover.1690733545.git.tanyuan@tinylab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1
Precedence: bulk

Series

tools/nolibc: add pipe(), pipe2() and their testcase |

Message

Yuan Tan July 31, 2023, 5:50 a.m. UTC

  Hi, Willy, Thomas,

Thanks to your advice and I really learned a lot from it.

V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in test
case.

Best regards,
Yuan Tan

Yuan Tan (2):
  tools/nolibc: add pipe() and pipe2() support
  selftests/nolibc: add testcase for pipe

 tools/include/nolibc/sys.h                   | 24 ++++++++++++++
 tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++
 2 files changed, 59 insertions(+)

Comments

Thomas Weißschuh July 31, 2023, 6:13 a.m. UTC | #1

Hi Yuan!

On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> Thanks to your advice and I really learned a lot from it.
> 
> V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in test
> case.

Thanks!

I have some more comments for the patches.

For new revisions you should also link to the old revision.

> Best regards,
> Yuan Tan
> 
> Yuan Tan (2):
>   tools/nolibc: add pipe() and pipe2() support
>   selftests/nolibc: add testcase for pipe
> 
>  tools/include/nolibc/sys.h                   | 24 ++++++++++++++
>  tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++
>  2 files changed, 59 insertions(+)
> 
> -- 
> 2.34.1
>

Yuan Tan July 31, 2023, 11:08 a.m. UTC | #2

Hi Thomas,

On Mon, 2023-07-31 at 08:13 +0200, Thomas Weißschuh wrote:
> Hi Yuan!
> 
> On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> > Thanks to your advice and I really learned a lot from it.
> > 
> > V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in
> > test
> > case.
> 
> Thanks!
> 
> I have some more comments for the patches.
> 
> For new revisions you should also link to the old revision.
> 

I sincerely appreciate your valuable advice. As a newcomer, I will
certainly take note of it next time. :)

> > Best regards,
> > Yuan Tan
> > 
> > Yuan Tan (2):
> >   tools/nolibc: add pipe() and pipe2() support
> >   selftests/nolibc: add testcase for pipe
> > 
> >  tools/include/nolibc/sys.h                   | 24 ++++++++++++++
> >  tools/testing/selftests/nolibc/nolibc-test.c | 35
> > ++++++++++++++++++++
> >  2 files changed, 59 insertions(+)
> > 
> > -- 
> > 2.34.1
> > 
>