mbox series

[v3,0/4] Trivial code cleanup patches

Message ID cover.1687092111.git.yogi.kernel@gmail.com
Headers
Series Trivial code cleanup patches |

Message

Yogesh Hegde June 18, 2023, 1:03 p.m. UTC 
  Rename variables in struct rtllib_device to avoid CamelCase which is not
accepted by checkpatch.

---
v3: The driver is split into 2 modules, calling the functions directly which 
    the v2 of the patchset does breaks compile. So reverting back to v1 of 
    the patch as suggested by Greg Kroah-Hartman <gregkh@linuxfoundation.org>.

v2: Removed the variable and called the function directly instead of
    just renaming the variable as suggested by Greg Kroah-Hartman
    <gregkh@linuxfoundation.org>.



Yogesh Hegde (4):
  staging: rtl8192e: Rename variable SetWirelessMode
  staging: rtl8192e: Rename variable SetBWModeHandler
  staging: rtl8192e: Rename variable LeisurePSLeave
  staging: rtl8192e: Rename variable InitialGainHandler

 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c |  4 ++--
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c   |  8 ++++----
 drivers/staging/rtl8192e/rtl819x_HTProc.c      |  4 ++--
 drivers/staging/rtl8192e/rtllib.h              | 12 ++++++------
 drivers/staging/rtl8192e/rtllib_rx.c           |  2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c      | 12 ++++++------
 drivers/staging/rtl8192e/rtllib_softmac_wx.c   |  6 +++---
 7 files changed, 24 insertions(+), 24 deletions(-)

Comments

Philipp Hortmann June 18, 2023, 8:26 p.m. UTC | #1 
On 6/18/23 15:03, Yogesh Hegde wrote:
> Rename variables in struct rtllib_device to avoid CamelCase which is not
> accepted by checkpatch.
> 
> ---
> v3: The driver is split into 2 modules, calling the functions directly which
>      the v2 of the patchset does breaks compile. So reverting back to v1 of
>      the patch as suggested by Greg Kroah-Hartman <gregkh@linuxfoundation.org>.
> 
> v2: Removed the variable and called the function directly instead of
>      just renaming the variable as suggested by Greg Kroah-Hartman
>      <gregkh@linuxfoundation.org>.
> 
> 
> 
> Yogesh Hegde (4):
>    staging: rtl8192e: Rename variable SetWirelessMode
>    staging: rtl8192e: Rename variable SetBWModeHandler
>    staging: rtl8192e: Rename variable LeisurePSLeave
>    staging: rtl8192e: Rename variable InitialGainHandler
> 
>   drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c |  4 ++--
>   drivers/staging/rtl8192e/rtl8192e/rtl_core.c   |  8 ++++----
>   drivers/staging/rtl8192e/rtl819x_HTProc.c      |  4 ++--
>   drivers/staging/rtl8192e/rtllib.h              | 12 ++++++------
>   drivers/staging/rtl8192e/rtllib_rx.c           |  2 +-
>   drivers/staging/rtl8192e/rtllib_softmac.c      | 12 ++++++------
>   drivers/staging/rtl8192e/rtllib_softmac_wx.c   |  6 +++---
>   7 files changed, 24 insertions(+), 24 deletions(-)
>
This patch series alone is fine. But when my patch series ([PATCH 0/9] 
staging: rtl8192e: Remove unsupported modes a and 5G) is applied before 
it fails as we change same lines. Will see what happens.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Greg KH June 19, 2023, 12:57 p.m. UTC | #2 
On Sun, Jun 18, 2023 at 10:26:37PM +0200, Philipp Hortmann wrote:
> On 6/18/23 15:03, Yogesh Hegde wrote:
> > Rename variables in struct rtllib_device to avoid CamelCase which is not
> > accepted by checkpatch.
> > 
> > ---
> > v3: The driver is split into 2 modules, calling the functions directly which
> >      the v2 of the patchset does breaks compile. So reverting back to v1 of
> >      the patch as suggested by Greg Kroah-Hartman <gregkh@linuxfoundation.org>.
> > 
> > v2: Removed the variable and called the function directly instead of
> >      just renaming the variable as suggested by Greg Kroah-Hartman
> >      <gregkh@linuxfoundation.org>.
> > 
> > 
> > 
> > Yogesh Hegde (4):
> >    staging: rtl8192e: Rename variable SetWirelessMode
> >    staging: rtl8192e: Rename variable SetBWModeHandler
> >    staging: rtl8192e: Rename variable LeisurePSLeave
> >    staging: rtl8192e: Rename variable InitialGainHandler
> > 
> >   drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c |  4 ++--
> >   drivers/staging/rtl8192e/rtl8192e/rtl_core.c   |  8 ++++----
> >   drivers/staging/rtl8192e/rtl819x_HTProc.c      |  4 ++--
> >   drivers/staging/rtl8192e/rtllib.h              | 12 ++++++------
> >   drivers/staging/rtl8192e/rtllib_rx.c           |  2 +-
> >   drivers/staging/rtl8192e/rtllib_softmac.c      | 12 ++++++------
> >   drivers/staging/rtl8192e/rtllib_softmac_wx.c   |  6 +++---
> >   7 files changed, 24 insertions(+), 24 deletions(-)
> > 
> This patch series alone is fine. But when my patch series ([PATCH 0/9]
> staging: rtl8192e: Remove unsupported modes a and 5G) is applied before it
> fails as we change same lines. Will see what happens.

Yes, none of these apply :(

Yogesh, can you rebase this on my staging-next branch and resend?

thanks,

greg k-h
Yogesh Hegde June 19, 2023, 1:49 p.m. UTC | #3 
Hi Greg, 
On Mon, Jun 19, 2023 at 02:57:56PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jun 18, 2023 at 10:26:37PM +0200, Philipp Hortmann wrote:
> > This patch series alone is fine. But when my patch series ([PATCH 0/9]
> > staging: rtl8192e: Remove unsupported modes a and 5G) is applied before it
> > fails as we change same lines. Will see what happens.
> 
> Yes, none of these apply :(
> 
> Yogesh, can you rebase this on my staging-next branch and resend?
Sure, will rebase and resend. Did you mean staging-testing branch instead of 
staging-next branch ? 

The patch series is rebased to commit "f99bbb4412ce axis-fifo: remove the 
unnecessary dev_info()" which is the HEAD of staging-next.
Latest changes by Philipp are merged into staging-testing branch. 
Let me know if you still want to rebase it to staging-next branch. 

Regards 
Yogesh
Greg KH June 19, 2023, 1:53 p.m. UTC | #4 
On Mon, Jun 19, 2023 at 07:19:21PM +0530, Yogesh Hegde wrote:
> Hi Greg, 
> On Mon, Jun 19, 2023 at 02:57:56PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Jun 18, 2023 at 10:26:37PM +0200, Philipp Hortmann wrote:
> > > This patch series alone is fine. But when my patch series ([PATCH 0/9]
> > > staging: rtl8192e: Remove unsupported modes a and 5G) is applied before it
> > > fails as we change same lines. Will see what happens.
> > 
> > Yes, none of these apply :(
> > 
> > Yogesh, can you rebase this on my staging-next branch and resend?
> Sure, will rebase and resend. Did you mean staging-testing branch instead of 
> staging-next branch ? 

Yes, sorry.