From patchwork Wed Jun 7 15:01:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 10434 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp279711vqr; Wed, 7 Jun 2023 08:23:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Bnv7RwoAfnD3WptCZXOP/6wgPd1N6B6rstflhhoFFX56ciX9Lqv7dtPlgU7m4XNVC1nXH X-Received: by 2002:a05:6a20:3d0e:b0:10d:951f:58bd with SMTP id y14-20020a056a203d0e00b0010d951f58bdmr3963009pzi.19.1686151405597; Wed, 07 Jun 2023 08:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686151405; cv=none; d=google.com; s=arc-20160816; b=nDbhoW4rgtAey/5+ylbXvSsNjn4AKltN0ZiJMRNWvUuHj9TbOfvYdpQ1GV3TbVJTXu D6t4OxuTtSpH3XhL/fKvtb+nyc3gw7Kj0/WZi+h25tUDg2wPkRUlM0LYDr+sZP805ssu KwNq8W6TUWYb+nbQamfs5bQ1MSvdcZQsGt0etU3sFbChwrT2j7QzsrL/j8bO575/t1gh 0cX0wsD8sb4eWlJ1Lur1Rbc9/gRHbp0KpnJjSSMKsdv+Uufext5D/Muz3HwkFqsBPvOX de2nXkRDZV3/LMaesQCFLEIXrK5WVrI9p05No+IFwN42eHthA1+nVTbxY7Q/sTihIDGs JL4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=8JScWWC74+BsV0fJcjz9vzitBceUwIm3AIsd9TVMHHw=; b=RzlWG7jzRO6T2z0PEYWeF59geHYNju2t3v6/XpL73W5IMi55MAQrWRZD+i/VF8nK4+ /yYmlhj43M+twBUwNYid7xHTXfWhBv6Z7iyVeKZfa4WkhCUZGALhuZKTTq6pwMlTFPR7 sDMSulp3V+SU02Sbxpavsl9mgPUR3uMVzlZl0abrYZxEWSCXTUbyre7l/+30umT0BJoq bewqyWdksxHYSYzMf8mCRg9pao6hFD2FL93QzKMhuZfSGMmpNWDK/1XDe7fzHNT0rdTp torRV21tpRHMyWuWVgRXXhj8w09r1s3jObTlwjoQgUcwINB3yTiR5M2OGJ48/mT9E48M ClYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="U6E3/1M8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v128-20020a626186000000b0064d32440768si7517258pfb.138.2023.06.07.08.23.10; Wed, 07 Jun 2023 08:23:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="U6E3/1M8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239049AbjFGPBk (ORCPT + 99 others); Wed, 7 Jun 2023 11:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240878AbjFGPBh (ORCPT ); Wed, 7 Jun 2023 11:01:37 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 236471FD8 for ; Wed, 7 Jun 2023 08:01:25 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-52cb8e5e9f5so523867a12.0 for ; Wed, 07 Jun 2023 08:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686150084; x=1688742084; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8JScWWC74+BsV0fJcjz9vzitBceUwIm3AIsd9TVMHHw=; b=U6E3/1M8l5g0rXH+m2pQJSyRDyBkwriKf2tZoQqW15ghveXyC/SJYouKOWYJnro7Jy YH9TXxyKnPA5QDvxF19Xg+nEWiOo5reX5dzSF1jT3A49/0Tm2gKpfc8jh/mDqc8zvzhT kErXjXmX/NdqHXdOk5EWKL/Sm/Ki5KU6WSkdkzHrtNDu6BUxZz6+wqDj/J5B3O2TD1BH EVaPnqM/jK03Hxrlomw7aJnP4RYed1r9JcjcTBgDg6N/dAJvlDDoNnUKOmbDBDhQUq4g 9qaljs0lhDQitF/jGmH4wJTN9YXO3w+Gnv6OoadQ+GPP5yyzI5S/nb9L6EvNbDuch25a Kymg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686150084; x=1688742084; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8JScWWC74+BsV0fJcjz9vzitBceUwIm3AIsd9TVMHHw=; b=EtWvQiFpq6mKR4WcAj2KxNUAWJ9lB4iD35Pk/Avz8MmpCQugQJx4NK/eBYjdcrsooJ gMDJQMQlJ8z0+gANJG06lNHRTz3UKLUZ5iJToMYpxy/xPSvayinauPIKCV71SaHlHIvJ 1B3O5BuCU9CPFPvl20FPVQuAZK4BzTLoNqxQWMMpPz9k57UPZkkwZXIYVcKpwn+syOf2 mQihEbHLIrKulGjxpS9BtK+XI2DD31AQ7FVALFyF7iVNc82NbEqYMMaS1QTfJ2rJUgEM +z36+jPy3x2lvKDCS+zeE3kjdEMpJnDmoRjL2ThIQtU+k+hoBnyx77+I5t19rT0u+fWz wiDg== X-Gm-Message-State: AC+VfDx7ASiGhZJnUmOtjZmxtL/93GMekXkfpEjo908u6OMRiYIjgTHa Pdf5rXUMzYK4Tg07t7YsFmUhvLE3DN8= X-Received: by 2002:a17:90a:199:b0:253:2816:2a12 with SMTP id 25-20020a17090a019900b0025328162a12mr6682116pjc.14.1686150084136; Wed, 07 Jun 2023 08:01:24 -0700 (PDT) Received: from yogi-Zephyrus ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id 27-20020a17090a19db00b002568f2f8102sm1574901pjj.30.2023.06.07.08.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 08:01:23 -0700 (PDT) Date: Wed, 7 Jun 2023 20:31:19 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/5] Trivial code cleanup patches Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768057896462897679?= X-GMAIL-MSGID: =?utf-8?q?1768057896462897679?= These patches remove variables in the struct rtllib_device that were set only once throughout the driver. Instead of using these variables, the patches modify the relevant code to directly call the corresponding functions, eliminating unnecessary indirection and removing CamelCase. The patches are required to be applied in sequence. Yogesh Hegde (5): staging: rtl8192e: Remove variable SetWirelessMode staging: rtl8192e: Remove variable SetBWModeHandler staging: rtl8192e: Remove variable LeisurePSLeave staging: rtl8192e: Remove variable InitialGainHandler staging: rtl8192e: Remove DRV_NAME definition in rtllib_debug.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ---- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++---- drivers/staging/rtl8192e/rtllib.h | 6 ------ drivers/staging/rtl8192e/rtllib_debug.h | 5 ----- drivers/staging/rtl8192e/rtllib_rx.c | 3 ++- drivers/staging/rtl8192e/rtllib_softmac.c | 16 +++++++--------- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 9 +++++---- 8 files changed, 20 insertions(+), 35 deletions(-) Reviewed-by: Dan Carpenter