mbox series

[v4,0/2] Patches for introducing traces in remoteproc.

Message ID cover.1685486994.git.quic_gokukris@quicinc.com
Headers
Series Patches for introducing traces in remoteproc. |

Message

Gokul krishna Krishnakumar May 31, 2023, 9:28 p.m. UTC 
  V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
    Rename rproc_qcom.h to remoteproc_tracepoints.h
    Rename qcom_tracepoints.c to remoteproc_tracepoints.c
    Switch to EXPORT_SYMBOL_GPL

V3: Split the Patch to 2 as per suggestion from Mukesh, fixed format
error from v2. 

V2: Moved the traces to common code from the qcom_pas driver as per
Bjorns review, fixed text as per Triloks suggestion, Updated QuiC
copyright to 2023.

[1]: https://lore.kernel.org/all/20230224165142.17745-2-quic_gokukris@quicinc.com/

Gokul krishna Krishnakumar (2):
  remoteproc: Introduce traces for remoteproc events
  remoteproc: qcom: Add remoteproc tracing

 drivers/remoteproc/Kconfig                    |   5 +
 drivers/remoteproc/Makefile                   |   1 +
 drivers/remoteproc/qcom_common.c              |  37 +++++
 drivers/remoteproc/qcom_q6v5.c                |   9 ++
 drivers/remoteproc/remoteproc_core.c          |   8 ++
 drivers/remoteproc/remoteproc_tracepoints.c   |  13 ++
 include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
 7 files changed, 202 insertions(+)
 create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
 create mode 100644 include/trace/events/remoteproc_tracepoints.h

Comments

Trilok Soni May 31, 2023, 9:35 p.m. UTC | #1 
On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>      Switch to EXPORT_SYMBOL_GPL


Any reasons you have not sent these patches to mailing list?

> 
> V3: Split the Patch to 2 as per suggestion from Mukesh, fixed format
> error from v2.
> 
> V2: Moved the traces to common code from the qcom_pas driver as per
> Bjorns review, fixed text as per Triloks suggestion, Updated QuiC
> copyright to 2023.
> 
> [1]: https://lore.kernel.org/all/20230224165142.17745-2-quic_gokukris@quicinc.com/
> 
> Gokul krishna Krishnakumar (2):
>    remoteproc: Introduce traces for remoteproc events
>    remoteproc: qcom: Add remoteproc tracing
> 
>   drivers/remoteproc/Kconfig                    |   5 +
>   drivers/remoteproc/Makefile                   |   1 +
>   drivers/remoteproc/qcom_common.c              |  37 +++++
>   drivers/remoteproc/qcom_q6v5.c                |   9 ++
>   drivers/remoteproc/remoteproc_core.c          |   8 ++
>   drivers/remoteproc/remoteproc_tracepoints.c   |  13 ++
>   include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
>   7 files changed, 202 insertions(+)
>   create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
>   create mode 100644 include/trace/events/remoteproc_tracepoints.h
>
Trilok Soni May 31, 2023, 9:36 p.m. UTC | #2 
On 5/31/2023 2:35 PM, Trilok Soni wrote:
> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>>      Switch to EXPORT_SYMBOL_GPL
> 
> 
> Any reasons you have not sent these patches to mailing list?

I don't see linux-arm-msm mailing list. Are you CCing all the required 
lists and maintainers?

---Trilok Soni
Gokul krishna Krishnakumar May 31, 2023, 9:49 p.m. UTC | #3 
On 5/31/2023 2:36 PM, Trilok Soni wrote:
> On 5/31/2023 2:35 PM, Trilok Soni wrote:
>> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>>> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>>>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>>>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>>>      Switch to EXPORT_SYMBOL_GPL
>>
>>
>> Any reasons you have not sent these patches to mailing list?
> 
> I don't see linux-arm-msm mailing list. Are you CCing all the required 
> lists and maintainers?
> 
> ---Trilok Soni
linux-arm-msm was not in the remoteproc lists(I have included everyone 
required), I will include the linux-trace-kernel as well from the next 
patch.

Thanks,
Gokul
Trilok Soni May 31, 2023, 9:50 p.m. UTC | #4 
On 5/31/2023 2:49 PM, Gokul Krishna Krishnakumar wrote:
> 
> 
> On 5/31/2023 2:36 PM, Trilok Soni wrote:
>> On 5/31/2023 2:35 PM, Trilok Soni wrote:
>>> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>>>> V4: Add config symbol REMOTEPROC_TRACEPOINTS to enable traces
>>>>      Rename rproc_qcom.h to remoteproc_tracepoints.h
>>>>      Rename qcom_tracepoints.c to remoteproc_tracepoints.c
>>>>      Switch to EXPORT_SYMBOL_GPL
>>>
>>>
>>> Any reasons you have not sent these patches to mailing list?
>>
>> I don't see linux-arm-msm mailing list. Are you CCing all the required 
>> lists and maintainers?
>>
>> ---Trilok Soni
> linux-arm-msm was not in the remoteproc lists(I have included everyone 
> required), I will include the linux-trace-kernel as well from the next 
> patch.

Thanks. linux-arm-msm should be default if you had used Qualcomm 
platform to test these patches which I am sure you did :)

---Trilok Soni