From patchwork Mon Apr 24 18:03:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 8609 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2927137vqo; Mon, 24 Apr 2023 11:17:20 -0700 (PDT) X-Google-Smtp-Source: AKy350ayfYzJxAvJHhut8qO1Zril6tDx0vQLNHd4Zvgvuusim9ZEuU7XwKGAvRNO9oHAZFxJLk5s X-Received: by 2002:a05:6a20:429a:b0:dd:7661:fb34 with SMTP id o26-20020a056a20429a00b000dd7661fb34mr19048731pzj.51.1682360239769; Mon, 24 Apr 2023 11:17:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682360239; cv=none; d=google.com; s=arc-20160816; b=j8NdqXtHPwFzGynWT8QeBRR7w541er9Mwp0Tksc6Y6O60XynMz6I+pXaY+JdYHeMfz 5KamuXHUWVMAWxdD7yAwLnFWeQkb6xdmKQozKXV+9ALGPGvPwNMws6fKqsHMj7pK1bzf fE2GXPJsmF3WDtqUyxd6KQy5NCZ4t1Cv9NrTnjmS2n6gdz4lMtbtbNr5O+dkG+oHTaIy LUcG8e7uEKCup2zYAH2TIUtEvQaNmW7w31M1n7ghKGTmMPwWxGL2EZAXDr7E+c1swKcI VovH6yEtUxumVSVHe8hNqTWw3EgfYLbMUBWfNI8mFp+NoBTwjHMEoMQhTz7Rt4jeIW7K DuxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=T1NUtVt3knB/HcXq8IIUhsyBrwMDib57ziNBiOWDoTI=; b=A/nnvUcJM7KAT2YELixRWt4xcsvvTXffZ4qAo2B6T35vKVV98L4g1o8ilpO8SFKLwP RX8jtOjwG/j7Ly5ZS9RtV215DKZMCjgGPnA0M4ILngC76FORp3yS/4dmyNKDjj9xPgSk In0b0GKEANsWxfa0rQ8FmX6f5S53SqOsS0n8KXP8CwUhaHySy5LE4BZZO5JOyjRD65vx h8tEjhVRCjHuK8HajEcHffN5L5MVWVHnPM/NVmUthQGI654Do+zjqqP6klkzh6PKD8nc Qao5zKXTxCx9RiK6O1SvfpniigDO7BG/weKwLBZVpDtQsAmUHvGfTfXpkV6laOR0Zr33 Ljxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=CkeLkg5K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a127-20020a621a85000000b0063b78126397si11418258pfa.230.2023.04.24.11.17.07; Mon, 24 Apr 2023 11:17:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=CkeLkg5K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231802AbjDXSD4 (ORCPT + 99 others); Mon, 24 Apr 2023 14:03:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbjDXSDy (ORCPT ); Mon, 24 Apr 2023 14:03:54 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 840275258 for ; Mon, 24 Apr 2023 11:03:53 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-63b7b54642cso3565592b3a.0 for ; Mon, 24 Apr 2023 11:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682359433; x=1684951433; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=T1NUtVt3knB/HcXq8IIUhsyBrwMDib57ziNBiOWDoTI=; b=CkeLkg5KKm0VfGJuk5lq/38olMkTW7PTeFFmDiDckPTrlzJgywQfut52O+UPNqV1A9 K5KaXcu5BLzfG9x1VwslhDrA989OPGEx4MvEcr8joRS7ofdpZUuViB0NlLjWps00q/9I a6f77xX+CHYg0L5KwLa/L6MNUI6c3mYdjBVQnrxHNiI15oM5yo81MsoyIZ8OVsmWgR+G yquL/JyhEvfFifD1iLb4KPUDtf8ntADaWP2l8YJ8bj5T4MZSg0Vihn6RuBY4AysV6Yw/ qnPzWbTQpjrRHhm1Mqt6+BDa23GOZlx2fGdXSXuglm+76iqK9TQ0HMhY47FLZCD4oTLF XOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682359433; x=1684951433; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T1NUtVt3knB/HcXq8IIUhsyBrwMDib57ziNBiOWDoTI=; b=Oml5WAfSLDzH5MTlr5MzHX5Yh5NV65rMGtvjGDlnq5VRFxAL7cup/D8wc+K3g/R6hl LUPfRoiVvV7oVWsIm2s68C4zp1YIjZVghHRaCmpt8Xrnn8QX1E3vyXneFTnCELFK2zQ1 0pc0OExKE6WGQXeAt2zQlFF+qpcfAC6DWwtbT4YJFers6dgSnofR4M2tRYUCDfRQglx9 9T3KcaVWF7NS3hHP46mwAELcRsYB4RyatrimFak9Yf7XeC57oS98kxAND7opa8ewZvY7 AVbj+6zkNFgFU5SCSTmYvoKId9NJOf8sCoIfqMPo5lr/Mq6usxVw3+qd9bHe9uSZ3lKy BWzw== X-Gm-Message-State: AAQBX9fNBStchgAGhScZhWPuCclWDO23oCe/iJtJo1ikVqngBW/VIg2h 3NR50aL4/9r9eJ4au6MoVt92PFg7t2w= X-Received: by 2002:a05:6a20:1449:b0:d6:91f5:2b10 with SMTP id a9-20020a056a20144900b000d691f52b10mr17617976pzi.58.1682359432995; Mon, 24 Apr 2023 11:03:52 -0700 (PDT) Received: from pop-os.localdomain ([103.251.210.208]) by smtp.gmail.com with ESMTPSA id x185-20020a6286c2000000b0063f00898245sm7948417pfd.146.2023.04.24.11.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 11:03:52 -0700 (PDT) Date: Mon, 24 Apr 2023 23:33:48 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/4] Remove unused rf_set_sens variable Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLY, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764082570727335435?= X-GMAIL-MSGID: =?utf-8?q?1764082570727335435?= The rf_set_sens variable is declared but never set, so it is always NULL. Cleanup the unused rf_set_sens variable. Remove functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens which always returned error code after removal of rf_set_sens variable. Cleanup unused max_sens and sens variable. The patches are required to be applied in sequence. Changes in v5: 1. Rebased onto latest staging-testing branch per feedback from philipp.g.hortmann@gmail.com Changes in v4: 1. Split changes into patch series per feedback from gregkh@linuxfoundation.org Changes in v3: 1. Fixed description to fit within 75 chars 2. Added suggested tags per feedback from philipp.g.hortmann@gmail.com Changes in v2: 1. Removed function definition rf_set_sens 2. Removed usage of variable priv->rf_set_sens 3. Removed functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens 4. Cleaned up the variables sens and max_sens used in these functions Changes in v1: 1. Fix comparison to NULL of variable rf_set_sens Yogesh Hegde (4): staging: rtl8192e: Remove unused rf_set_sens variable staging: rtl8192e: Remove unused _rtl92e_wx_get_sens function staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function staging: rtl8192e: Remove unused sens and max_sens from r8192_priv struct drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 -- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 45 -------------------- 2 files changed, 48 deletions(-) Tested-by: Philipp Hortmann