[v3,0/8] objtool: warning improvements

Message ID	cover.1681853186.git.jpoimboe@kernel.org
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Josh Poimboeuf <jpoimboe@kernel.org> To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Miroslav Benes <mbenes@suse.cz>, Nick Desaulniers <ndesaulniers@google.com> Subject: [PATCH v3 0/8] objtool: warning improvements Date: Tue, 18 Apr 2023 14:27:46 -0700 Message-Id: <cover.1681853186.git.jpoimboe@kernel.org> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit Precedence: bulk
Series	objtool: warning improvements \| [v3,0/8] objtool: warning improvements [v3,1/8] objtool: Limit unreachable warnings to once per function [v3,2/8] objtool: Add verbose option for disassembling affected functions [v3,3/8] objtool: Include backtrace in verbose mode [v3,4/8] objtool: Detect missing __noreturn annotations [v3,5/8] objtool: Ignore exc_double_fault() __noreturn warnings [v3,6/8] objtool: Remove superfluous global_noreturns entries [v3,7/8] tools/lib/subcmd: Replace NORETURN usage with __noreturn [v3,8/8] objtool: Move noreturn function list to separate file

Message ID

cover.1681853186.git.jpoimboe@kernel.org

Headers

Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
 designates 2620:137:e000::1:20 as permitted sender)
 client-ip=2620:137:e000::1:20;
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Miroslav Benes <mbenes@suse.cz>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH v3 0/8] objtool: warning improvements
Date: Tue, 18 Apr 2023 14:27:46 -0700
Message-Id: <cover.1681853186.git.jpoimboe@kernel.org>
MIME-Version: 1.0
Content-type: text/plain
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

objtool: warning improvements |

Message

Josh Poimboeuf April 18, 2023, 9:27 p.m. UTC

  v3:
- dropped merged patches and rebased on tip/objtool/core
- moved list of noreturn functions to separate file
- improved WARN_INSN() to do single evaluation of insn arg

Josh Poimboeuf (8):
  objtool: Limit unreachable warnings to once per function
  objtool: Add verbose option for disassembling affected functions
  objtool: Include backtrace in verbose mode
  objtool: Detect missing __noreturn annotations
  objtool: Ignore exc_double_fault() __noreturn warnings
  objtool: Remove superfluous global_noreturns entries
  tools/lib/subcmd: Replace NORETURN usage with __noreturn
  objtool: Move noreturn function list to separate file

 tools/lib/subcmd/parse-options.h        |   8 +-
 tools/lib/subcmd/subcmd-util.h          |   5 +-
 tools/objtool/Documentation/objtool.txt |  10 ++
 tools/objtool/builtin-check.c           |   5 +
 tools/objtool/check.c                   | 195 ++++++++++++++++--------
 tools/objtool/include/objtool/builtin.h |   1 +
 tools/objtool/include/objtool/elf.h     |   1 +
 tools/objtool/include/objtool/warn.h    |  21 ++-
 tools/objtool/noreturns.h               |  45 ++++++
 9 files changed, 214 insertions(+), 77 deletions(-)
 create mode 100644 tools/objtool/noreturns.h

Comments

Miroslav Benes April 19, 2023, 2:51 p.m. UTC | #1

On Tue, 18 Apr 2023, Josh Poimboeuf wrote:

> v3:
> - dropped merged patches and rebased on tip/objtool/core
> - moved list of noreturn functions to separate file
> - improved WARN_INSN() to do single evaluation of insn arg
> 
> Josh Poimboeuf (8):
>   objtool: Limit unreachable warnings to once per function
>   objtool: Add verbose option for disassembling affected functions
>   objtool: Include backtrace in verbose mode
>   objtool: Detect missing __noreturn annotations
>   objtool: Ignore exc_double_fault() __noreturn warnings
>   objtool: Remove superfluous global_noreturns entries
>   tools/lib/subcmd: Replace NORETURN usage with __noreturn
>   objtool: Move noreturn function list to separate file
> 
>  tools/lib/subcmd/parse-options.h        |   8 +-
>  tools/lib/subcmd/subcmd-util.h          |   5 +-
>  tools/objtool/Documentation/objtool.txt |  10 ++
>  tools/objtool/builtin-check.c           |   5 +
>  tools/objtool/check.c                   | 195 ++++++++++++++++--------
>  tools/objtool/include/objtool/builtin.h |   1 +
>  tools/objtool/include/objtool/elf.h     |   1 +
>  tools/objtool/include/objtool/warn.h    |  21 ++-
>  tools/objtool/noreturns.h               |  45 ++++++
>  9 files changed, 214 insertions(+), 77 deletions(-)
>  create mode 100644 tools/objtool/noreturns.h

Reviewed-by: Miroslav Benes <mbenes@suse.cz>

M