From patchwork Thu Mar 30 15:19:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 7482 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1243112vqo; Thu, 30 Mar 2023 09:13:23 -0700 (PDT) X-Google-Smtp-Source: AKy350a7L9hcghVrdZthjP1AyaZmPMwtJITGBwiLmXEFChKHH1xC4DFoPE7eHJkXi1Evb7K1VxPj X-Received: by 2002:a17:903:1208:b0:1a2:55c9:1808 with SMTP id l8-20020a170903120800b001a255c91808mr17270632plh.17.1680192803305; Thu, 30 Mar 2023 09:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680192803; cv=none; d=google.com; s=arc-20160816; b=kHp9A8jnI6KEbvspxuqx7/ykQd2rxdCy62fC0muEpGsEu4jD0gfUdU9O8G0eQyv+3X aafP4BTgu3jHJgM9vyu58jzMHkvKB8gpYcgeocmzJfJOEgsmgDKFhu3mJQsoLdg/7dEP 8fe7l71RKTxoZ+VauPiWrRsczr2/UO1G+JlRwna9i2rUst2O/U9IKbQVjXWV8pyZmlDH QSAfXBmLjBh5pE2YqVdxy0ZRl/hFWdVPymYrC2dTZGQSDR9ApstX1w9h5QQeuBj1kJFY oymhkQ6g8oRYvg7hn4xAdqYhv30d422U0QgkgLVTmrE6tgVuRA9IxqiWaKCily9XtL/i 19iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date; bh=RMUDoZuVbNdMCto62844rMiAMonPsQuJO3n9Tz7XFqQ=; b=QCYNu8wVYwwlVVDTZRYScRWvFo3H0vFpiWYKQMGeCqTIH/53NUMBd/nCARHg9U/NUZ cljxGxoDIildtMyB0jAzTgLd4gAZPhL8x8t2ETtnWVAKG3wB3xcmsLfImGJ0Ef4iOWEQ 5ElXAZ2z3NZsbbHTaLjSJop03nI9UDzTROwiSIFWGVxnbFLAM70wH5iHAvEGkrLl6Cnw 2XY0xW/TfxWAnOoAsN5KzUoctfumnxrmUHDKP126+Dx7KmHgf/+8LmzaVDMwx1DnI/aY IzB/kc8USQ/FVBu+bGpR7R0LJaQ4f8/EURSdsJUUsopsMsd4dJnHA9AgYyf6Fsok2HY3 B8GA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i9-20020a17090332c900b001a1a252c4b1si36853586plr.13.2023.03.30.09.13.09; Thu, 30 Mar 2023 09:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232862AbjC3PUe (ORCPT + 99 others); Thu, 30 Mar 2023 11:20:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232840AbjC3PUd (ORCPT ); Thu, 30 Mar 2023 11:20:33 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F90CDF5; Thu, 30 Mar 2023 08:19:19 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1phu3Q-0006ZI-2u; Thu, 30 Mar 2023 17:19:09 +0200 Date: Thu, 30 Mar 2023 16:19:04 +0100 From: Daniel Golle To: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, =?utf-8?b?QXLEsW7DpyDDnG5hbA==?= , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sean Wang , Landen Chao , DENG Qingfang , Philipp Zabel Cc: Sam Shih , Lorenzo Bianconi , John Crispin , Felix Fietkau Subject: [PATCH net-next 00/15] net: dsa: add support for MT7988 Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761809848930689139?= X-GMAIL-MSGID: =?utf-8?q?1761809848930689139?= The MediaTek MT7988 SoC comes with a built-in switch very similar to previous MT7530 and MT7531. However, the switch address space is mapped into the SoCs memory space rather than being connected via MDIO. Using MMIO simplifies register access and also removes the need for a bus lock, and for that reason also makes interrupt handling more light-weight. Note that this is different from previous SoCs like MT7621 and MT7623N which also came with an integrated MT7530-like switch which yet had to be accessed via MDIO. Split-off the part of the driver registering an MDIO driver, then add another module acting as MMIO/platform driver. The whole series has been tested on various MediaTek boards: * MT7623A + MT7530 (BPi-R2) * MT7986A + MT7531 (BPi-R3) * MT7988A reference board Changes since RFC v3: * WARN_ON_ONCE if register read fails * move probing of the reset GPIO and reset controller link out of common probe function, as they are not actually common Changes since RFC v2: * split into many small commits to ease review * introduce helper functions to reduce code duplication * use helpers for locking to make lock-skipping easier and less ugly to implement. * add dt-bindings for mediatek,mt7988-switch Changes since initial RFC: * use regmap for register access and move register access to bus- specific driver * move initialization of MT7531 SGMII PCS to MDIO driver Daniel Golle (15): net: dsa: mt7530: make some noise if register read fails net: dsa: mt7530: refactor SGMII PCS creation net: dsa: mt7530: use unlocked regmap accessors net: dsa: mt7530: use regmap to access switch register space net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function net: dsa: mt7530: introduce mutex helpers net: dsa: mt7530: move p5_intf_modes() function to mt7530.c net: dsa: mt7530: introduce mt7530_probe_common helper function net: dsa: mt7530: introduce mt7530_remove_common helper function net: dsa: mt7530: split-off common parts from mt7531_setup net: dsa: mt7530: introduce separate MDIO driver net: dsa: mt7530: skip locking if MDIO bus isn't present net: dsa: mt7530: add support for 10G link modes for CPU port net: dsa: mt7530: introduce driver for MT7988 built-in switch dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch .../bindings/net/dsa/mediatek,mt7530.yaml | 26 +- MAINTAINERS | 3 + drivers/net/dsa/Kconfig | 28 +- drivers/net/dsa/Makefile | 4 +- drivers/net/dsa/mt7530-mdio.c | 271 ++++++++++ drivers/net/dsa/mt7530-mmio.c | 101 ++++ drivers/net/dsa/mt7530.c | 511 ++++++++---------- drivers/net/dsa/mt7530.h | 38 +- 8 files changed, 668 insertions(+), 314 deletions(-) create mode 100644 drivers/net/dsa/mt7530-mdio.c create mode 100644 drivers/net/dsa/mt7530-mmio.c base-commit: 4ddd6375c3ef6756d492ea5466408cace097121b