mbox series

[00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h

Message ID cover.1678569965.git.philipp.g.hortmann@gmail.com
Headers
Series staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h |

Message

Philipp Hortmann March 11, 2023, 9:50 p.m. UTC 
  Remove unused RF90_PATH_C and RF90_PATH_D. Justification can be quite
complex. Some variables are unused then those are completely removed. 

The following code lines are mandatory:
enum rf90_radio_path {
	RF90_PATH_A = 0,
	RF90_PATH_B = 1,
	RF90_PATH_C = 2,
	RF90_PATH_D = 3,
	RF90_PATH_MAX
};

Index is saved in variable name: eRFPath

Code likes to shorten variable name to the array with this line:
pPhyReg = &priv->phy_reg_def[eRFPath];

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

Philipp Hortmann (12):
  staging: rtl8192e: Remove unused RF90_PATH_C and ..D in
    rtl92e_config_rf
  staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfs
  staging: rtl8192e: Remove unused variable rfintfi
  staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and
    ..fe
  staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffset
  staging: rtl8192e: Remove unused variable rfLSSI_Select and
    rfTxGainStage
  staging: rtl8192e: Remove unused variable rfHSSIPara1 and
    rfSwitchControl
  staging: rtl8192e: Remove unused variable rfAGCControl1 and
    rfAGCControl2
  staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFE
  staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFE
  staging: rtl8192e: Remove unused RF90_PATH_C and ..D for
    rfLSSIReadBack
  staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2

 .../staging/rtl8192e/rtl8192e/r8190P_def.h    | 11 ---
 .../rtl8192e/rtl8192e/r8190P_rtl8256.c        |  4 --
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 68 -------------------
 .../staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 37 ----------
 4 files changed, 120 deletions(-)

Comments

Dan Carpenter March 13, 2023, 4:55 a.m. UTC | #1 
Looks good!

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter