From patchwork Wed Mar 1 19:53:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 6000 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3836550wrd; Wed, 1 Mar 2023 11:57:28 -0800 (PST) X-Google-Smtp-Source: AK7set9/AmirtmeaICNtqPdB4CUx+lfQrH/RR74x7EWhyKquo5CxYBQ+5p6VWVPxrHcnZV+hgb+w X-Received: by 2002:a17:906:f105:b0:8b2:e6f6:c20a with SMTP id gv5-20020a170906f10500b008b2e6f6c20amr7996847ejb.11.1677700647987; Wed, 01 Mar 2023 11:57:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677700647; cv=none; d=google.com; s=arc-20160816; b=aYwcUJXTZAAQzs6QJWKlxtvY+7ydGNFw8oPVBsTxuNjZMZ2iCX3abNhq2MMBr1BRVZ MoqsLpR06ECxd/NGXpo3L3VDVH+42vCOrT9jZwA/4zYHTShhrdZlkR1SuL6hk1Ec5bCj +cqI2iM3eUqn2qIgzTl0gIftcQwtHXY+ejmaxQZ4yJsp0xdpZ2jyC5MXzbIaMKwggTJZ fLNIvCcLvYXMvqnO7osGz/FHOpvx6kgePDr722pYqW5OfonGHbw8TtRNYSSV2WwGTSvv nVqSmdulOMcEzkLOEzSGeByIXGG7rxRQ/gXuddlN7mQgO5oSPghQoLLBRiTWydGv7lkD ZYQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date; bh=5jGEbBF1/efgEWgJ5oF7oZDXp/O1E3most1HT1cKws0=; b=0rdgLFXqzu2cnoIQZu2mmPbaeASrbA4i9WqAX/spEl87ljYjDyOyMlxevvO6+FI2wY yYqecxOlA2DEqgGCRTiL8Cu+Wx/BYxHBzUAvank33uq/EXvZFVLNL+pCgBByt4dpy/A5 RACHKFSJ906E/TuM163/HRYAzeFqk3e06cJFQIblwJGIV21w+aAd0myBf2RdJpK3Av7I BrImlGGrr3S07jcnMjV72i3O9nO5sWeC4FI3PbAFPDkT1gQXhXZwmCD5SSLNHPYvXFLC gN3rx9FW0b3zumcmYV5jeWBUyd4i31DvrjDSa/Jft6HsEbvcd+xtT3H3AByVz4NoRzf2 q8Tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f27-20020a170906391b00b008d399f4f54fsi13999052eje.606.2023.03.01.11.57.05; Wed, 01 Mar 2023 11:57:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjCATxa (ORCPT + 99 others); Wed, 1 Mar 2023 14:53:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjCATx2 (ORCPT ); Wed, 1 Mar 2023 14:53:28 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3BE20562; Wed, 1 Mar 2023 11:53:27 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pXSVr-0007Fg-02; Wed, 01 Mar 2023 20:53:19 +0100 Date: Wed, 1 Mar 2023 19:53:10 +0000 From: Daniel Golle To: devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn Cc: Jianhui Zhao , =?iso-8859-1?q?Bj=F8rn?= Mork Subject: [RFC PATCH net-next v11 00/12] net: ethernet: mtk_eth_soc: various enhancements Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759196634901799096?= X-GMAIL-MSGID: =?utf-8?q?1759196634901799096?= This series brings a variety of fixes and enhancements for mtk_eth_soc, adds support for the MT7981 SoC and facilitates sharing the SGMII PCS code between mtk_eth_soc and mt7530. Note that this series depends on commit 697c3892d825 ("regmap: apply reg_base and reg_downshift for single register ops") to not break mt7530 pcs register access. The whole series has been tested on MT7622+MT7531 (BPi-R64), MT7623+MT7530 (BPi-R2), MT7981+GPY211 (GL.iNet GL-MT3000) and MT7986+MT7531 (BPi-R3). Changes since v10: * improve mediatek,mt7981-eth dt-bindings * use regmap_set_bits instead of regmap_update_bits where possible * completely remove mtk_sgmii.c * no need to keep struct mtk_sgmii either as it had only a single element Changes since v9: * fix path in mediatek,sgmiisys dt-binding Changes since v8: * move mediatek,sgmiisys dt-bindings to correct net/pcs folder * rebase on top of net-next/main so series applies cleanly again Changes since v7: * move mediatek,sgmiisys.yaml to more appropriate folder * don't include twice in PCS driver, sort includes Changes since v6: * label MAC MCR bit 12 in 08/12, MediaTek replied explaining its function Changes since v5: * drop dev pointer also from struct mtk_sgmii, pass it as function parameter instead * address comments left for dt-bindings * minor improvements to commit messages Changes since v4: * remove unused dev pointer in struct pcs_mtk_lynxi * squash link timer check into correct follow-up patch Changes since v3: * remove unused #define's * use BMCR_* instead of #define'ing our own constants * return before changing registers in case of invalid link timer Changes since v2: * improve dt-bindings, convert sgmisys bindings to dt-schema yaml * fix typo Changes since v1: * apply reverse xmas tree everywhere * improve commit descriptions * add dt binding documentation * various small changes addressing all comments received for v1 Daniel Golle (12): net: ethernet: mtk_eth_soc: add support for MT7981 SoC dt-bindings: net: mediatek,net: add mt7981-eth binding dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC net: ethernet: mtk_eth_soc: set MDIO bus clock frequency net: ethernet: mtk_eth_soc: reset PCS state net: ethernet: mtk_eth_soc: only write values if needed net: ethernet: mtk_eth_soc: fix RX data corruption issue net: ethernet: mtk_eth_soc: ppe: add support for flow accounting net: pcs: add driver for MediaTek SGMII PCS net: ethernet: mtk_eth_soc: switch to external PCS driver net: dsa: mt7530: use external PCS driver .../arm/mediatek/mediatek,sgmiisys.txt | 27 -- .../devicetree/bindings/net/mediatek,net.yaml | 53 ++- .../bindings/net/pcs/mediatek,sgmiisys.yaml | 55 ++++ MAINTAINERS | 7 + drivers/net/dsa/Kconfig | 1 + drivers/net/dsa/mt7530.c | 277 ++++------------ drivers/net/dsa/mt7530.h | 47 +-- drivers/net/ethernet/mediatek/Kconfig | 2 + drivers/net/ethernet/mediatek/Makefile | 2 +- drivers/net/ethernet/mediatek/mtk_eth_path.c | 14 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 114 ++++++- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 114 +++---- drivers/net/ethernet/mediatek/mtk_ppe.c | 114 ++++++- drivers/net/ethernet/mediatek/mtk_ppe.h | 25 +- .../net/ethernet/mediatek/mtk_ppe_debugfs.c | 9 +- .../net/ethernet/mediatek/mtk_ppe_offload.c | 8 + drivers/net/ethernet/mediatek/mtk_ppe_regs.h | 14 + drivers/net/ethernet/mediatek/mtk_sgmii.c | 203 ------------ drivers/net/pcs/Kconfig | 7 + drivers/net/pcs/Makefile | 1 + drivers/net/pcs/pcs-mtk-lynxi.c | 302 ++++++++++++++++++ include/linux/pcs/pcs-mtk-lynxi.h | 13 + 22 files changed, 817 insertions(+), 592 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt create mode 100644 Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml delete mode 100644 drivers/net/ethernet/mediatek/mtk_sgmii.c create mode 100644 drivers/net/pcs/pcs-mtk-lynxi.c create mode 100644 include/linux/pcs/pcs-mtk-lynxi.h base-commit: 1716a175592aff9549a0c07aac8f9cadd03003f5