mbox series

[0/5] media: add FSD MIPI-CSI2 Rx controller driver

Message ID cover.1668963790.git.sathya@samsung.com
Headers
Series media: add FSD MIPI-CSI2 Rx controller driver |

Message

Sathyakam M Nov. 20, 2022, 6:52 p.m. UTC 
  This patch series adds the V4L2 media driver for
Tesla Full Self Driving (FSD) SoC MIPI-CSI2 Rx controller.

The controller is compliant to MIPI CSI2 v1.3 specification.
It receives images from camera sensors over the D-PHY interface.

The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
supports up to maximum of 4 data lanes.

V4L2 user control is provided to set the desired number of data lanes.

Maximum of up to 4 streams can be received simultaneously by one Rx
port. (Each streams identified by designated Virtual Channel
Identifier).

The controller instances consist of port property describing the endpoints.
When combined with remote-endpoint property the driver instantiates
video device nodes using V4L2 async subdev methods.

Streaming formats supported:
- YUV420
- RGB565, RGB666, RGB888
- RAW8, RAW10, RAW12
- JPEG

The driver implementation is verified on FSD evaluation board.

Thanks, Sathyakam

Cc: Sathyakam M <sathya@samsung.com>,Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>,Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,Shashank Prashar <s.prashar@samsung.com>
Cc: Aswani Reddy <aswani.reddy@samsung.com>,Chandrasekar R <rcsekar@samsung.com>
Cc: Andi Shyti <andi@etezian.org>,Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Ming Qian <ming.qian@nxp.com>,Dmitry Osipenko <digetx@gmail.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,Bjorn Andersson <andersson@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>,Arnd Bergmann <arnd@arndb.de>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,linux-phy@lists.infradead.org,devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,linux-media@vger.kernel.org

Sathyakam M (5):
  dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
  media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
  arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
  media: fsd: add MIPI CSI2 Rx controller driver
  arm64: defconfig: enable FSD MIPI CSI2 Rx controller driver

 .../bindings/media/tesla-fsd-csis.yaml        |  148 +
 .../bindings/phy/fsd-csis-syscon.yaml         |   48 +
 .../media/drivers/fsd-csis-uapi.rst           |   78 +
 MAINTAINERS                                   |   12 +
 arch/arm64/boot/dts/tesla/fsd-evb.dts         |  232 ++
 arch/arm64/boot/dts/tesla/fsd.dtsi            |  162 +
 arch/arm64/configs/defconfig                  |    1 +
 drivers/media/platform/Kconfig                |    1 +
 drivers/media/platform/Makefile               |    1 +
 drivers/media/platform/fsd/Kconfig            |   73 +
 drivers/media/platform/fsd/Makefile           |    1 +
 drivers/media/platform/fsd/fsd-csis.c         | 2664 +++++++++++++++++
 drivers/media/platform/fsd/fsd-csis.h         |  785 +++++
 include/uapi/linux/fsd-csis.h                 |   19 +
 include/uapi/linux/v4l2-controls.h            |    5 +
 15 files changed, 4230 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/tesla-fsd-csis.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/fsd-csis-syscon.yaml
 create mode 100644 Documentation/userspace-api/media/drivers/fsd-csis-uapi.rst
 create mode 100644 drivers/media/platform/fsd/Kconfig
 create mode 100644 drivers/media/platform/fsd/Makefile
 create mode 100644 drivers/media/platform/fsd/fsd-csis.c
 create mode 100644 drivers/media/platform/fsd/fsd-csis.h
 create mode 100644 include/uapi/linux/fsd-csis.h


base-commit: 77c51ba552a1c4f73228766e43ae37c4101b3758

Comments

Krzysztof Kozlowski Nov. 21, 2022, 9:31 a.m. UTC | #1 
On 20/11/2022 19:52, Sathyakam M wrote:
> This patch series adds the V4L2 media driver for
> Tesla Full Self Driving (FSD) SoC MIPI-CSI2 Rx controller.
> 
> The controller is compliant to MIPI CSI2 v1.3 specification.
> It receives images from camera sensors over the D-PHY interface.
> 
> The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
> supports up to maximum of 4 data lanes.
> 
> V4L2 user control is provided to set the desired number of data lanes.
> 
> Maximum of up to 4 streams can be received simultaneously by one Rx
> port. (Each streams identified by designated Virtual Channel
> Identifier).
> 
> The controller instances consist of port property describing the endpoints.
> When combined with remote-endpoint property the driver instantiates
> video device nodes using V4L2 async subdev methods.
> 
> Streaming formats supported:
> - YUV420
> - RGB565, RGB666, RGB888
> - RAW8, RAW10, RAW12
> - JPEG
> 
> The driver implementation is verified on FSD evaluation board.
> 
> Thanks, Sathyakam
> 
> Cc: Sathyakam M <sathya@samsung.com>,Vinod Koul <vkoul@kernel.org>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>,Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>,Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>,Shashank Prashar <s.prashar@samsung.com>
> Cc: Aswani Reddy <aswani.reddy@samsung.com>,Chandrasekar R <rcsekar@samsung.com>
> Cc: Andi Shyti <andi@etezian.org>,Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Ming Qian <ming.qian@nxp.com>,Dmitry Osipenko <digetx@gmail.com>
> Cc: Jacopo Mondi <jacopo@jmondi.org>,Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>,Bjorn Andersson <andersson@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>,Arnd Bergmann <arnd@arndb.de>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,Mark Brown <broonie@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,linux-phy@lists.infradead.org,devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org,linux-media@vger.kernel.org
> 
> Sathyakam M (5):
>   dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
>   media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
>   arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
>   media: fsd: add MIPI CSI2 Rx controller driver

I did not get your patch #4. Don't Cc selectively.

Best regards,
Krzysztof
Sathyakam M Nov. 23, 2022, 8:45 a.m. UTC | #2 
Hi Krzysztof,
Thank you for taking your time to review the patches.

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 21 November 2022 15:01
> To: Sathyakam M <sathya@samsung.com>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Pankaj Kumar Dubey
> <pankaj.dubey@samsung.com>; Alim Akhtar <alim.akhtar@samsung.com>;
> Aswani Reddy <aswani.reddy@samsung.com>; Andi Shyti
> <andi@etezian.org>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; Ming Qian
> <ming.qian@nxp.com>; Jacopo Mondi <jacopo@jmondi.org>; Will Deacon
> <will@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Marcel Ziswiler
> <marcel.ziswiler@toradex.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver
> 
> On 20/11/2022 19:52, Sathyakam M wrote:
> > This patch series adds the V4L2 media driver for Tesla Full Self
> > Driving (FSD) SoC MIPI-CSI2 Rx controller.
> >
> > The controller is compliant to MIPI CSI2 v1.3 specification.
> > It receives images from camera sensors over the D-PHY interface.
> >
> > The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
> > supports up to maximum of 4 data lanes.
> >
> > V4L2 user control is provided to set the desired number of data lanes.
> >
> > Maximum of up to 4 streams can be received simultaneously by one Rx
> > port. (Each streams identified by designated Virtual Channel
> > Identifier).
> >
> > The controller instances consist of port property describing the endpoints.
> > When combined with remote-endpoint property the driver instantiates
> > video device nodes using V4L2 async subdev methods.
> >
> > Streaming formats supported:
> > - YUV420
> > - RGB565, RGB666, RGB888
> > - RAW8, RAW10, RAW12
> > - JPEG
> >
> > The driver implementation is verified on FSD evaluation board.
> >
> > Thanks, Sathyakam
> >
> > Cc: Sathyakam M <sathya@samsung.com>,Vinod Koul <vkoul@kernel.org>
> > Cc: Kishon Vijay Abraham I <kishon@kernel.org>,Rob Herring
> > <robh+dt@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>,Mauro Carvalho
> > Chehab <mchehab@kernel.org>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>,Shashank Prashar
> > <s.prashar@samsung.com>
> > Cc: Aswani Reddy <aswani.reddy@samsung.com>,Chandrasekar R
> > <rcsekar@samsung.com>
> > Cc: Andi Shyti <andi@etezian.org>,Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com>
> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,Jernej Skrabec
> > <jernej.skrabec@gmail.com>
> > Cc: Ming Qian <ming.qian@nxp.com>,Dmitry Osipenko
> <digetx@gmail.com>
> > Cc: Jacopo Mondi <jacopo@jmondi.org>,Catalin Marinas
> > <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>,Bjorn Andersson
> > <andersson@kernel.org>
> > Cc: Shawn Guo <shawnguo@kernel.org>,Arnd Bergmann
> <arnd@arndb.de>
> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,Mark Brown
> > <broonie@kernel.org>
> > Cc:
> > linux-arm-kernel@lists.infradead.org,linux-phy@lists.infradead.org,dev
> > icetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org,linux-media@vger.kernel.org
> >
> > Sathyakam M (5):
> >   dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
> >   media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
> >   arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
> >   media: fsd: add MIPI CSI2 Rx controller driver
> 
> I did not get your patch #4. Don't Cc selectively.
Sorry for that. There was problem with sending the bundled patch set. I see that you got "[PATCH 4/5] media: fsd: add MIPI CSI2 Rx controller driver".
I will address the comments for the same.
> 
> Best regards,
> Krzysztof