mbox series

[v3,0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c

Message ID cover.1667326000.git.tanjubrunostar0@gmail.com
Headers
Series staging: vt6655: some checkpatch fixes in the file rxtx.c |

Message

Tanjuate Brunostar Nov. 1, 2022, 6:17 p.m. UTC 
  These fixes are focused on the function s_vFillRTSHead

v3: changed the function name from fill_rts_head to fill_rts_header as
head is conventionally used in lists

v2: changed confusing changelog messages

Tanjuate Brunostar (2):
  staging: vt6655: change the function name s_vFillRTSHead
  staging: vt6655: Join some lines of code to avoid code lines ending in
    (

 drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 26 deletions(-)

Comments

Philipp Hortmann Nov. 1, 2022, 10:15 p.m. UTC | #1 
On 11/1/22 19:17, Tanjuate Brunostar wrote:
> These fixes are focused on the function s_vFillRTSHead
> 
> v3: changed the function name from fill_rts_head to fill_rts_header as
> head is conventionally used in lists
> 
> v2: changed confusing changelog messages
> 
> Tanjuate Brunostar (2):
>    staging: vt6655: change the function name s_vFillRTSHead
>    staging: vt6655: Join some lines of code to avoid code lines ending in
>      (
> 
>   drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
>   1 file changed, 22 insertions(+), 26 deletions(-)
> 

Patch failed at 0001 staging: vt6655: change the function name 
s_vFillRTSHead


WARNING: line length of 138 exceeds 100 columns
#58: FILE: drivers/staging/vt6655/rxtx.c:915:
+			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, 
bDisCRC, psEthHeader, wCurrentRate, byFBOption);

WARNING: line length of 138 exceeds 100 columns
#67: FILE: drivers/staging/vt6655/rxtx.c:934:
+			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, 
bDisCRC, psEthHeader, wCurrentRate, byFBOption);

WARNING: line length of 138 exceeds 100 columns
#76: FILE: drivers/staging/vt6655/rxtx.c:948:
+			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, 
bDisCRC, psEthHeader, wCurrentRate, byFBOption);

May be you need to consider to break this lines.

Bye Philipp
Greg KH Nov. 2, 2022, 7:19 a.m. UTC | #2 
On Tue, Nov 01, 2022 at 11:15:37PM +0100, Philipp Hortmann wrote:
> On 11/1/22 19:17, Tanjuate Brunostar wrote:
> > These fixes are focused on the function s_vFillRTSHead
> > 
> > v3: changed the function name from fill_rts_head to fill_rts_header as
> > head is conventionally used in lists
> > 
> > v2: changed confusing changelog messages
> > 
> > Tanjuate Brunostar (2):
> >    staging: vt6655: change the function name s_vFillRTSHead
> >    staging: vt6655: Join some lines of code to avoid code lines ending in
> >      (
> > 
> >   drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
> >   1 file changed, 22 insertions(+), 26 deletions(-)
> > 
> 
> Patch failed at 0001 staging: vt6655: change the function name
> s_vFillRTSHead
> 
> 
> WARNING: line length of 138 exceeds 100 columns
> #58: FILE: drivers/staging/vt6655/rxtx.c:915:
> +			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
> bDisCRC, psEthHeader, wCurrentRate, byFBOption);
> 
> WARNING: line length of 138 exceeds 100 columns
> #67: FILE: drivers/staging/vt6655/rxtx.c:934:
> +			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
> bDisCRC, psEthHeader, wCurrentRate, byFBOption);
> 
> WARNING: line length of 138 exceeds 100 columns
> #76: FILE: drivers/staging/vt6655/rxtx.c:948:
> +			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
> bDisCRC, psEthHeader, wCurrentRate, byFBOption);
> 
> May be you need to consider to break this lines.

Not in this commit, just stick to doing one thing per patch.  This line
is already "too long" so it is not a new problem being introduced with
this change.  It is fine as-is.

thanks,

greg k-h
Greg KH Nov. 2, 2022, 7:20 a.m. UTC | #3 
On Tue, Nov 01, 2022 at 06:17:47PM +0000, Tanjuate Brunostar wrote:
> These fixes are focused on the function s_vFillRTSHead
> 
> v3: changed the function name from fill_rts_head to fill_rts_header as
> head is conventionally used in lists
> 
> v2: changed confusing changelog messages
> 
> Tanjuate Brunostar (2):
>   staging: vt6655: change the function name s_vFillRTSHead
>   staging: vt6655: Join some lines of code to avoid code lines ending in
>     (

Neither of these changes apply to my tree.  Please rebase against the
staging-next branch of the staging.git tree and resend a new version.

thanks,

greg k-h