mbox series

[v9,0/6] Checkpatch cleanup in rxtx.c

Message ID cover.1666995639.git.tanjubrunostar0@gmail.com
Headers
Series Checkpatch cleanup in rxtx.c |

Message

Tanjuate Brunostar Oct. 28, 2022, 11:23 p.m. UTC 
  v9: reorganized the changelog messages on this patch

v8: made commit messages clearer, unsuccessfuly

v7: made log messages less confusing

v6: fixed some errors on commit messages

v5: shortend changelog comments

v4: made some changes on the code

v3: fixed compilation errors

v2: tried fixing compilation erros unsuccessfuly

Tanjuate Brunostar (6):
  staging: vt6655: fix lines of code ending in a '('
  staging: vt6655: split long lines of code in s_uGetRTSCTSDuration
  staging: vt6655: split long lines of code in s_uFillDataHead
  staging: vt6655: split long lines of code in s_vGenerateTxParamete
  staging: vt6655: split long lines of code in some functions
  staging: vt6655: fix lines of code ending in a '('

 drivers/staging/vt6655/rxtx.c | 542 ++++++++++++++++++++--------------
 1 file changed, 324 insertions(+), 218 deletions(-)

Comments

Alison Schofield Oct. 29, 2022, 12:29 a.m. UTC | #1 
Tanjuate,

Wow - I've seen 4 revs of this in 12 hours?!

I reviewed each Patch against the feedback previously
offered, and it was not addressed, so I'm going to NAK
this set and ask you to rework carefully before resending.
I expect to see each specific piece of reviewer feedback,
called out as addressed in the changelog.

BTW - I still prefer a single patch at a time while you are
learning these mechanics, and to make sure that this type
of patch is going to be accepted.

If you are still amenable to doing that, keep the version,
but only send one patch at a time. When one gets accepted,
apply those learnings to the second patch, and so on.

That should go more smoothly for you and your reviewers.

Alison

On Fri, Oct 28, 2022 at 11:23:21PM +0000, Tanjuate Brunostar wrote:
> v9: reorganized the changelog messages on this patch
> 
> v8: made commit messages clearer, unsuccessfuly
> 
> v7: made log messages less confusing
> 
> v6: fixed some errors on commit messages
> 
> v5: shortend changelog comments
> 
> v4: made some changes on the code
> 
> v3: fixed compilation errors
> 
> v2: tried fixing compilation erros unsuccessfuly
> 
> Tanjuate Brunostar (6):
>   staging: vt6655: fix lines of code ending in a '('
>   staging: vt6655: split long lines of code in s_uGetRTSCTSDuration
>   staging: vt6655: split long lines of code in s_uFillDataHead
>   staging: vt6655: split long lines of code in s_vGenerateTxParamete
>   staging: vt6655: split long lines of code in some functions
>   staging: vt6655: fix lines of code ending in a '('
> 
>  drivers/staging/vt6655/rxtx.c | 542 ++++++++++++++++++++--------------
>  1 file changed, 324 insertions(+), 218 deletions(-)
> 
> -- 
> 2.34.1
> 
>
Greg KH Oct. 29, 2022, 7:39 a.m. UTC | #2 
On Fri, Oct 28, 2022 at 11:23:21PM +0000, Tanjuate Brunostar wrote:
> v9: reorganized the changelog messages on this patch

You dropped the "staging: vt6655: " from this 0/X email, why?

Please take a day or two off, relax, and resubmit the series with _ALL_
review comments addressed.

thanks,

greg k-h