Message ID | cover.1666978292.git.tanjubrunostar0@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp959484wru; Fri, 28 Oct 2022 10:41:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7oKShVgAmpf5g7n2bXMvyqvZ8Xxd5uvYEFi/dfEVJhkUjG5uCspexIp7I2xZuuGOGc+L5n X-Received: by 2002:a05:6402:5cd:b0:446:5965:f4af with SMTP id n13-20020a05640205cd00b004465965f4afmr591667edx.12.1666978916212; Fri, 28 Oct 2022 10:41:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666978916; cv=none; d=google.com; s=arc-20160816; b=x8mT/fgFWVLbNdq9pqskD8fSOpQMG4fe6B4vXJB51vtENjhavHRuY05aLjNs29h+a4 sF51lLkYzrJ4eAAQEDHK7QbeaQSH6vRHaWcHa4PyWx7RQemebTh9wVSDavU2OV5CtAMQ 3PjXLp1821WWlpHOoB87XQpg+EU30hRjJwIC/Dp57WC38TjBQhJQS4Zm5vNYT7oSoA2O +yOGEJMPzn1wYnSZwW0WDSxIDRtyr5HU9bz+t24vEogEVBHJPAkl402oSCj24sLZicfG iKjwo+NcWZ6Y/Lq8zkaNV5elbCJYbZkotbYyCu7jLPqnnXi76zr+A5a9Mhxcu/BRSTi8 NKiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LgIFkJpodLhQ5UNB8CnN3tOTm9odgIidnDRK4X3byAg=; b=jqz9gNRhOcPXy7solw1XEQjp8vBNWO57c6S52SJnhrUIzcSVAjGckRLQboMqfSU/zo tG9muqXVUPqZV4kBMdQMheI/PcmenFyXnKvFcVtiXPIDt8OgzBG/N+Pjc5vqV+z+//8j NQYOrUUdNI9Oc1EJTFHRPq2PRN+QjbpIg/u7XVjITJaZujJC6h/3zkyKloyEY5Md5xsd SZwMfpulU5ZuhEXSgofDu4ksBuo3FRoH2ox6yPRUXPKIf5cbotlHQEM06b0bHThxuBqh d3Gtsm13F8Hsly9ZbjRenFUMvwAkgEor4qT+hrFmp47Khpupejk9ssaBNX5PnxLlp9IJ eZIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WA90H9fR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv13-20020a17090760cd00b0078e1d213831si5475996ejc.122.2022.10.28.10.41.32; Fri, 28 Oct 2022 10:41:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WA90H9fR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbiJ1RlO (ORCPT <rfc822;norden.jeffspam@gmail.com> + 99 others); Fri, 28 Oct 2022 13:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbiJ1RlL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Oct 2022 13:41:11 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA828733D5 for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 10:41:10 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id bn35so9249564ljb.5 for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 10:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LgIFkJpodLhQ5UNB8CnN3tOTm9odgIidnDRK4X3byAg=; b=WA90H9fRil7olR1Vlx/1sOEtZ0T3JsGEo/zahhOQwFUmffec42jXK67bQZGEdVJZ0b PYwyVYcokv5NPLfkNsVbXmyXYVR9YLMFNmi7vs9nbz5JgD9VKC+53jP7g/gRZ1JDGVnS lPvldw9IbWef9my0YLqiicSNaq6pP14bPdQmhtlOE8M39NmP2qkFpq5LZW2bvOuZXlgs FJuJlV3ME0cnhFQpYb8shJ8a49kWaPha38YsKJt5QZD8CqX1kMlX0jFxxpsk2w2jm+jS T74nIkCZBAQOf7oX1ItpdaqEDMjPJ4uxp3LxlEaHVO2KSqmva8PqV9VW8ECg0ESXmhia DT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LgIFkJpodLhQ5UNB8CnN3tOTm9odgIidnDRK4X3byAg=; b=nD+Rd4Nq0lniBz3czGUNPsc9z4kUqz+Px8S0KbI2cR6XqWNPPie7T0dBSSmInH2JJD 7U/SmC+yorNu1wQCF3kAlfPaqpe5ul622u6U4YyFqQzswfK/fAtO4ulonR6GsCEG79P1 RT44QUANzHkOAyh3KWgGDfrPfhpjJZLretYMpk5yksAPHDUrRwX9tWmZCadYQd95dBbs NO+XclDwP/dIj62+jfe0hJB0Js5RsrgxPpVdzvkXTNKumVTkf7v0zUGtUnlXKW3Ee06e OpP3z6pOMIurKVqiLp8slVgs69/4uSwS/Pd7QyB9PdfggSDA1HnJf93a4oh9xFXT8gkL LF9A== X-Gm-Message-State: ACrzQf3rTtKLJo7DRP2b7XN18JuapXakpq+ELOrb26pGV9kYWb0+/orS 1C8ffeMCPP4BPEZ5grPl4Go= X-Received: by 2002:a05:651c:2212:b0:26c:2baf:652e with SMTP id y18-20020a05651c221200b0026c2baf652emr295510ljq.84.1666978868819; Fri, 28 Oct 2022 10:41:08 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id s2-20020a2eb622000000b0026dfdcbccdasm725322ljn.14.2022.10.28.10.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 10:41:08 -0700 (PDT) From: Tanjuate Brunostar <tanjubrunostar0@gmail.com> To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar <tanjubrunostar0@gmail.com> Subject: [PATCH v8 0/6] staging: vt6655: a series of checkpatch fixes on the file: rxtx.c Date: Fri, 28 Oct 2022 17:40:52 +0000 Message-Id: <cover.1666978292.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747819511532300486?= X-GMAIL-MSGID: =?utf-8?q?1747954083805830174?= |
Series |
staging: vt6655: a series of checkpatch fixes on the file: rxtx.c
|
|
Message
Tanjuate Brunostar
Oct. 28, 2022, 5:40 p.m. UTC
The fixes are similar, mostly long lines splitting. I had to make serveral patches to ease the work of inspectors v2: fixed a compilation error found by the kernel test robot and recompiled the code v3: tends out the error persisted in the second version. this version is a correction of that v4: did some corrections as recommended by Greg KH v5: shortend changelog comments as recommended by Greg KH v6: did some corrections as recommended by Greg KH v7: fixed some errors on my changelog comments v8: fixed some errors pointed out by Philipp Hortmann Tanjuate Brunostar (6): staging: vt6655: fix lines ending in a '(' staging: vt6655: fix long lines of code in s_uGetRTSCTSDuration staging: vt6655: fix long lines of code in s_uFillDataHead staging: vt6655: fix long lines of code in s_vGenerateTxParamete staging: vt6655: fix long lines of code in the rest of the file staging: vt6655: fix lines of code ending in a '(' drivers/staging/vt6655/rxtx.c | 542 ++++++++++++++++++++-------------- 1 file changed, 324 insertions(+), 218 deletions(-)
Comments
We know it's a patchset or series, saying so in subject line is redundant. Perhaps - 'Checkpatch cleanup in rxtx.c' On Fri, Oct 28, 2022 at 05:40:52PM +0000, Tanjuate Brunostar wrote: > The fixes are similar, mostly long lines splitting. I had to make > serveral patches to ease the work of inspectors ^ Please use a spell checker. > > v2: fixed a compilation error found by the kernel test robot and > recompiled the code Expected to be in reverse order, with latest changes first. ie. Here you would start with v8 > v3: tends out the error persisted in the second version. this version is > a correction of that ? > > v4: did some corrections as recommended by Greg KH State what changed. Do not expect your review to go back hunting for past review comments. Same for all below. > > v5: shortend changelog comments as recommended by Greg KH > > v6: did some corrections as recommended by Greg KH > > v7: fixed some errors on my changelog comments > > v8: fixed some errors pointed out by Philipp Hortmann > > Tanjuate Brunostar (6): > staging: vt6655: fix lines ending in a '(' Move ( to end of line > staging: vt6655: fix long lines of code in s_uGetRTSCTSDuration This doesn't match what was actually done > staging: vt6655: fix long lines of code in s_uFillDataHead > staging: vt6655: fix long lines of code in s_vGenerateTxParamete > staging: vt6655: fix long lines of code in the rest of the file Each commit msg needs to stand alone. The one above only makes sense (still it's a poor message) when viewed in this patchset. Once the patches are applied, it must stand alone. The commit msg should read like a directive. Fix is too general. Commit msg states what you did, commit log states why you did it. I see you took 'refactoring' out of the commit messages, but left it in the commit logs. It doesn't belong in the logs. As another reviewer pointed out, this is not a refactor. Alison > > drivers/staging/vt6655/rxtx.c | 542 ++++++++++++++++++++-------------- > 1 file changed, 324 insertions(+), 218 deletions(-) > > -- > 2.34.1 > >
On Fri, Oct 28, 2022 at 7:11 PM Alison Schofield <alison.schofield@intel.com> wrote: > > We know it's a patchset or series, saying so in subject line is > redundant. Perhaps - 'Checkpatch cleanup in rxtx.c' > > On Fri, Oct 28, 2022 at 05:40:52PM +0000, Tanjuate Brunostar wrote: > > The fixes are similar, mostly long lines splitting. I had to make > > serveral patches to ease the work of inspectors > ^ > Please use a spell checker. > > > > > v2: fixed a compilation error found by the kernel test robot and > > recompiled the code > > Expected to be in reverse order, with latest changes first. > ie. Here you would start with v8 > > > v3: tends out the error persisted in the second version. this version is > > a correction of that > > ? > > > > > v4: did some corrections as recommended by Greg KH > > State what changed. Do not expect your review to go back > hunting for past review comments. > > Same for all below. > > > > > v5: shortend changelog comments as recommended by Greg KH > > > > v6: did some corrections as recommended by Greg KH > > > > v7: fixed some errors on my changelog comments > > > > v8: fixed some errors pointed out by Philipp Hortmann > > > > Tanjuate Brunostar (6): > > staging: vt6655: fix lines ending in a '(' > > Move ( to end of line > > > staging: vt6655: fix long lines of code in s_uGetRTSCTSDuration > > This doesn't match what was actually done > > > staging: vt6655: fix long lines of code in s_uFillDataHead > > staging: vt6655: fix long lines of code in s_vGenerateTxParamete > > staging: vt6655: fix long lines of code in the rest of the file > > Each commit msg needs to stand alone. The one above only makes > sense (still it's a poor message) when viewed in this patchset. > Once the patches are applied, it must stand alone. > > The commit msg should read like a directive. Fix is too general. > Commit msg states what you did, commit log states why you did it. > > I see you took 'refactoring' out of the commit messages, but left it > in the commit logs. It doesn't belong in the logs. As another > reviewer pointed out, this is not a refactor. > > Alison The commit logs I changed too but they did not show in the patches when I sent them. I don't get how that happened. Thanks for the corrections. like i said, I will be sticking with single patches for now. Thanks, Tanju > > > > drivers/staging/vt6655/rxtx.c | 542 ++++++++++++++++++++-------------- > > 1 file changed, 324 insertions(+), 218 deletions(-) > > > > -- > > 2.34.1 > > > > >
On Fri, Oct 28, 2022 at 05:40:52PM +0000, Tanjuate Brunostar wrote: > The fixes are similar, mostly long lines splitting. I had to make > serveral patches to ease the work of inspectors > > v2: fixed a compilation error found by the kernel test robot and > recompiled the code > > v3: tends out the error persisted in the second version. this version is > a correction of that > > v4: did some corrections as recommended by Greg KH > > v5: shortend changelog comments as recommended by Greg KH > > v6: did some corrections as recommended by Greg KH > > v7: fixed some errors on my changelog comments > > v8: fixed some errors pointed out by Philipp Hortmann > > Tanjuate Brunostar (6): > staging: vt6655: fix lines ending in a '(' > staging: vt6655: fix long lines of code in s_uGetRTSCTSDuration > staging: vt6655: fix long lines of code in s_uFillDataHead > staging: vt6655: fix long lines of code in s_vGenerateTxParamete > staging: vt6655: fix long lines of code in the rest of the file > staging: vt6655: fix lines of code ending in a '(' > You messed up your patchset...; the shortlog above says "fix longlines" but individual patch subject says "refactor". Well, refactoring means resturcturing and improving it without introducing new functionality or changing behavior, which is really changing existing code. However, your patchset only do visual formatting, right? Also, have you ever at least compile-test your patchset (make W=1 and enabling CONFIG_WERROR)? Thanks.