mbox series

[v2,0/4] staging: rtl8712: clean up dynamic memory management

Message ID cover.1666688642.git.namcaov@gmail.com
Headers
Series staging: rtl8712: clean up dynamic memory management |

Message

Nam Cao Oct. 25, 2022, 9:12 a.m. UTC 
  This driver is fine if memory allocation never fails. However it does not
handle allocation failure well. This can either lead to memory leak, or
unallocated buffers being used.

v2: Add a missing if statement, as noticed by Dan Carpenter

Nam Cao (4):
  Revert "staging: r8712u: Tracking kmemleak false positives."
  staging: rtl8712: check for alloc fail in _r8712_init_recv_priv()
  staging: rtl8712: check for return value of _r8712_init_xmit_priv()
  staging: rtl8712: fix potential memory leak

 drivers/staging/rtl8712/os_intfs.c     | 27 +++++++++++++++++++++-----
 drivers/staging/rtl8712/recv_osdep.h   |  8 ++++----
 drivers/staging/rtl8712/rtl8712_recv.c |  7 ++++---
 drivers/staging/rtl8712/rtl871x_recv.c | 16 ++++++++-------
 4 files changed, 39 insertions(+), 19 deletions(-)

Comments

Philipp Hortmann Oct. 25, 2022, 6:37 p.m. UTC | #1 
On 10/25/22 11:12, Nam Cao wrote:
> This driver is fine if memory allocation never fails. However it does not
> handle allocation failure well. This can either lead to memory leak, or
> unallocated buffers being used.
> 
> v2: Add a missing if statement, as noticed by Dan Carpenter
> 
> Nam Cao (4):
>    Revert "staging: r8712u: Tracking kmemleak false positives."
>    staging: rtl8712: check for alloc fail in _r8712_init_recv_priv()
>    staging: rtl8712: check for return value of _r8712_init_xmit_priv()
>    staging: rtl8712: fix potential memory leak
> 
>   drivers/staging/rtl8712/os_intfs.c     | 27 +++++++++++++++++++++-----
>   drivers/staging/rtl8712/recv_osdep.h   |  8 ++++----
>   drivers/staging/rtl8712/rtl8712_recv.c |  7 ++++---
>   drivers/staging/rtl8712/rtl871x_recv.c | 16 ++++++++-------
>   4 files changed, 39 insertions(+), 19 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>