mbox series

[v4,00/11] staging: r8188eu: trivial code cleanup patches

Message ID cover.1666299151.git.drv@mailo.com
Headers
Series staging: r8188eu: trivial code cleanup patches |

Message

Deepak R Varma Oct. 20, 2022, 9:26 p.m. UTC 
  Address different kinds of checkpatch complains for the staging/r8188eu module.
The patches are required to be applied in sequence.

Changes in v4:
   1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr
   2. Update patch 1 per feedback from David.Laight@ACULAB.COM
   3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr

Changes in v3:
   1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
      This was suggested by philipp.g.hortmann@gmail.com
   2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com
   3. Patch 5 through 10: Included in this version. Additional clean up patches.

Changes in v2:
   I incorrectly labeled the first revision as v1 instead of v2. So,
   following change recorded under v1 is actually changes for v2. Feedback
   provided by philipp.g.hortmann@gmail.com
      1. Improve language / grammar for the patch descriptions
      2. Further improve code reformatting


Deepak R Varma (11):
  staging: r8188eu: use Linux kernel variable naming convention
  staging: r8188eu: reformat long computation lines
  staging: r8188eu: remove {} for single statement blocks
  staging: r8188eu: use htons macro instead of __constant_htons
  staging: r8188eu: correct misspelled words in comments
  staging: r8188eu: Add space between function & macro parameters
  staging: r8188eu: Associate pointer symbol with parameter name
  staging: r8188eu: replace leading spaces by tabs
  staging: r8188eu: Put '{" on the symbol declaration line
  staging: r8188eu: Correct missing or extra space in the statements
  staging: r8188eu: Remove unused macros

 drivers/staging/r8188eu/core/rtw_br_ext.c     | 119 +++++++++---------
 drivers/staging/r8188eu/core/rtw_ioctl_set.c  |   2 +-
 drivers/staging/r8188eu/core/rtw_mlme_ext.c   |  36 +++---
 drivers/staging/r8188eu/core/rtw_recv.c       |   8 +-
 drivers/staging/r8188eu/core/rtw_xmit.c       |  14 +--
 drivers/staging/r8188eu/hal/HalPhyRf_8188e.c  |   2 +-
 drivers/staging/r8188eu/hal/odm_RTL8188E.c    |   2 +-
 .../staging/r8188eu/hal/rtl8188e_hal_init.c   |   2 +-
 drivers/staging/r8188eu/hal/rtl8188e_phycfg.c |  16 +--
 .../staging/r8188eu/include/Hal8188EPhyReg.h  |   4 +-
 .../staging/r8188eu/include/osdep_service.h   |   4 +-
 .../staging/r8188eu/include/rtl8188e_hal.h    |   6 +-
 .../staging/r8188eu/include/rtl8188e_spec.h   |  18 +--
 drivers/staging/r8188eu/include/rtw_cmd.h     |  62 +++++----
 drivers/staging/r8188eu/include/rtw_io.h      |  16 +--
 .../staging/r8188eu/include/rtw_ioctl_set.h   |   4 +-
 drivers/staging/r8188eu/include/rtw_mlme.h    |  22 ++--
 .../staging/r8188eu/include/rtw_mlme_ext.h    |  12 +-
 drivers/staging/r8188eu/include/rtw_recv.h    |   4 +-
 drivers/staging/r8188eu/include/rtw_xmit.h    |   2 +-
 drivers/staging/r8188eu/include/wifi.h        |  12 +-
 drivers/staging/r8188eu/os_dep/ioctl_linux.c  |   6 +-
 22 files changed, 176 insertions(+), 197 deletions(-)

--
2.30.2

Comments

Philipp Hortmann Oct. 21, 2022, 5:20 a.m. UTC | #1 
On 10/20/22 23:26, Deepak R Varma wrote:
> Address different kinds of checkpatch complains for the staging/r8188eu module.
> The patches are required to be applied in sequence.
> 
> Changes in v4:
>     1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr
>     2. Update patch 1 per feedback from David.Laight@ACULAB.COM
>     3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr
> 
> Changes in v3:
>     1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
>        This was suggested by philipp.g.hortmann@gmail.com
>     2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com
>     3. Patch 5 through 10: Included in this version. Additional clean up patches.
> 
> Changes in v2:
>     I incorrectly labeled the first revision as v1 instead of v2. So,
>     following change recorded under v1 is actually changes for v2. Feedback
>     provided by philipp.g.hortmann@gmail.com
>        1. Improve language / grammar for the patch descriptions
>        2. Further improve code reformatting
> 
> 
> Deepak R Varma (11):
>    staging: r8188eu: use Linux kernel variable naming convention
>    staging: r8188eu: reformat long computation lines
>    staging: r8188eu: remove {} for single statement blocks
>    staging: r8188eu: use htons macro instead of __constant_htons
>    staging: r8188eu: correct misspelled words in comments
>    staging: r8188eu: Add space between function & macro parameters
>    staging: r8188eu: Associate pointer symbol with parameter name
>    staging: r8188eu: replace leading spaces by tabs
>    staging: r8188eu: Put '{" on the symbol declaration line
>    staging: r8188eu: Correct missing or extra space in the statements
>    staging: r8188eu: Remove unused macros
> 
>   drivers/staging/r8188eu/core/rtw_br_ext.c     | 119 +++++++++---------
>   drivers/staging/r8188eu/core/rtw_ioctl_set.c  |   2 +-
>   drivers/staging/r8188eu/core/rtw_mlme_ext.c   |  36 +++---
>   drivers/staging/r8188eu/core/rtw_recv.c       |   8 +-
>   drivers/staging/r8188eu/core/rtw_xmit.c       |  14 +--
>   drivers/staging/r8188eu/hal/HalPhyRf_8188e.c  |   2 +-
>   drivers/staging/r8188eu/hal/odm_RTL8188E.c    |   2 +-
>   .../staging/r8188eu/hal/rtl8188e_hal_init.c   |   2 +-
>   drivers/staging/r8188eu/hal/rtl8188e_phycfg.c |  16 +--
>   .../staging/r8188eu/include/Hal8188EPhyReg.h  |   4 +-
>   .../staging/r8188eu/include/osdep_service.h   |   4 +-
>   .../staging/r8188eu/include/rtl8188e_hal.h    |   6 +-
>   .../staging/r8188eu/include/rtl8188e_spec.h   |  18 +--
>   drivers/staging/r8188eu/include/rtw_cmd.h     |  62 +++++----
>   drivers/staging/r8188eu/include/rtw_io.h      |  16 +--
>   .../staging/r8188eu/include/rtw_ioctl_set.h   |   4 +-
>   drivers/staging/r8188eu/include/rtw_mlme.h    |  22 ++--
>   .../staging/r8188eu/include/rtw_mlme_ext.h    |  12 +-
>   drivers/staging/r8188eu/include/rtw_recv.h    |   4 +-
>   drivers/staging/r8188eu/include/rtw_xmit.h    |   2 +-
>   drivers/staging/r8188eu/include/wifi.h        |  12 +-
>   drivers/staging/r8188eu/os_dep/ioctl_linux.c  |   6 +-
>   22 files changed, 176 insertions(+), 197 deletions(-)
> 
> --
> 2.30.2
> 
> 
> 
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Deepak R Varma Oct. 21, 2022, 4:49 p.m. UTC | #2 
On Sat, Oct 22, 2022 at 10:05:36AM +0200, Greg KH wrote:
> On Fri, Oct 21, 2022 at 02:56:10AM +0530, Deepak R Varma wrote:
> > Address different kinds of checkpatch complains for the staging/r8188eu module.
> > The patches are required to be applied in sequence.
> >
> > Changes in v4:
> >    1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr
> >    2. Update patch 1 per feedback from David.Laight@ACULAB.COM
> >    3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr
> >
> > Changes in v3:
> >    1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
> >       This was suggested by philipp.g.hortmann@gmail.com
> >    2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com
> >    3. Patch 5 through 10: Included in this version. Additional clean up patches.
> >
> > Changes in v2:
> >    I incorrectly labeled the first revision as v1 instead of v2. So,
> >    following change recorded under v1 is actually changes for v2. Feedback
> >    provided by philipp.g.hortmann@gmail.com
> >       1. Improve language / grammar for the patch descriptions
> >       2. Further improve code reformatting
> >
>
> I've taken these, but note, your email system is not properly being
> authenticated.  Here's the results I get when I use the tool 'b4' to
> apply the patches:
>
> Grabbing thread from lore.kernel.org/all/cover.1666299151.git.drv%40mailo.com/t.mbox.gz
> Analyzing 20 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
>   ✗ [PATCH v4 1/11] staging: r8188eu: use Linux kernel variable naming convention
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 2/11] staging: r8188eu: reformat long computation lines
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 3/11] staging: r8188eu: remove {} for single statement blocks
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 4/11] staging: r8188eu: use htons macro instead of __constant_htons
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 5/11] staging: r8188eu: correct misspelled words in comments
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 6/11] staging: r8188eu: Add space between function & macro parameters
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 7/11] staging: r8188eu: Associate pointer symbol with parameter name
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 8/11] staging: r8188eu: replace leading spaces by tabs
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 9/11] staging: r8188eu: Put '{" on the symbol declaration line
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 10/11] staging: r8188eu: Correct missing or extra space in the statements
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ✗ [PATCH v4 11/11] staging: r8188eu: Remove unused macros
>     + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
>   ---
>   ✗ BADSIG: DKIM/mailo.com
> ---
> Total patches: 11
>
>
> Please look into fixing up your DKIM settings.

Hi Greg,
Yeah, there is some trouble with my email settings and I have already written to
the tech support.
I will also look DKIM authentication issue and let you know if I need further
guidance from you all.

Thank you for highlight it.


./drv

>
> thanks,
>
> greg k-h
Greg KH Oct. 22, 2022, 8:05 a.m. UTC | #3 
On Fri, Oct 21, 2022 at 02:56:10AM +0530, Deepak R Varma wrote:
> Address different kinds of checkpatch complains for the staging/r8188eu module.
> The patches are required to be applied in sequence.
> 
> Changes in v4:
>    1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr
>    2. Update patch 1 per feedback from David.Laight@ACULAB.COM
>    3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr
> 
> Changes in v3:
>    1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
>       This was suggested by philipp.g.hortmann@gmail.com
>    2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com
>    3. Patch 5 through 10: Included in this version. Additional clean up patches.
> 
> Changes in v2:
>    I incorrectly labeled the first revision as v1 instead of v2. So,
>    following change recorded under v1 is actually changes for v2. Feedback
>    provided by philipp.g.hortmann@gmail.com
>       1. Improve language / grammar for the patch descriptions
>       2. Further improve code reformatting
> 

I've taken these, but note, your email system is not properly being
authenticated.  Here's the results I get when I use the tool 'b4' to
apply the patches:

Grabbing thread from lore.kernel.org/all/cover.1666299151.git.drv%40mailo.com/t.mbox.gz
Analyzing 20 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH v4 1/11] staging: r8188eu: use Linux kernel variable naming convention
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 2/11] staging: r8188eu: reformat long computation lines
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 3/11] staging: r8188eu: remove {} for single statement blocks
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 4/11] staging: r8188eu: use htons macro instead of __constant_htons
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 5/11] staging: r8188eu: correct misspelled words in comments
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 6/11] staging: r8188eu: Add space between function & macro parameters
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 7/11] staging: r8188eu: Associate pointer symbol with parameter name
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 8/11] staging: r8188eu: replace leading spaces by tabs
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 9/11] staging: r8188eu: Put '{" on the symbol declaration line
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 10/11] staging: r8188eu: Correct missing or extra space in the statements
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ✗ [PATCH v4 11/11] staging: r8188eu: Remove unused macros
    + Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> (✓ DKIM/gmail.com)
  ---
  ✗ BADSIG: DKIM/mailo.com
---
Total patches: 11


Please look into fixing up your DKIM settings.

thanks,

greg k-h