From patchwork Thu Oct 20 07:52:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 403 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp128014wrs; Thu, 20 Oct 2022 01:08:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM40LWN0geslnja/MS5tjmnrJdyZ4CKX/Y2oZTYTsChg+uUHw3T1YPNuxsAM8xyfzdRCfocS X-Received: by 2002:a05:6402:2686:b0:45d:82c0:c2b6 with SMTP id w6-20020a056402268600b0045d82c0c2b6mr10760835edd.390.1666253320238; Thu, 20 Oct 2022 01:08:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666253320; cv=none; d=google.com; s=arc-20160816; b=fhW4vlF1iNpj97ebBs20FbbK6etXPr1csPOky70AShtkh3UP0DNjYNaOZ0KIOK56nj WvJOvVwPul6hNoHmYjLRnwYq2uKyE1G/d0h5B+s8nvStCUWwOeE9TBN8XyHd+DiE/hb0 oxLjRlOhRo/IPfM1dzIo8K3qviDwe/oXSXGbPdkidF5OJ7dveYm7XMHnvL+rpqviT6t2 +hpXufYYs5UvDkMWeBKUfgNJnFefRZA0kNqn1HTJIiV8vCARd3/W5jAuWDz7CQtZLH3Q 9QIr4HwO4UGAy0T2Sxbbd8eXveEFZs3oH2QGEcNmWY5LcpB0lbG3RcMVq41XV/JAm18p fnyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=0Qe5qImaZ9rY/M47ymFrKtLHA4y2XM+ihgVEOQzrBz8=; b=b280d2EB2G2aGPw1cLrcW+WFnLhHGda1/fFCL3Z3VtRd9aAmeBDnWyoGr+leC4bwjJ C5gt07V/50Hzx0Nu3vFabBlftWLV3LodaZp7wZxIH8XZwfkOk/QjnQFiOeIJN6yopKu7 pKS0jNzgF6/BhdAfxd682AamhiuqMXw7JbOD0dmHynUAlr45VZwgcVFAseUkROVO4rpw 1kMIxluyWmBV0+m0NQFqZeNrQGcDrHpqIi0QH0mVDNgKnjOFH+HA4ucyWf2u1wysiY0M EWRbz+OImUAdWSOekRr2wwRqesAsn3iaidn3wCjfuP6BUvUB3vbpGaS/OsdIrmXNdQgn vPBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=lULIsknr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ce6-20020a170906b24600b0078de51ec509si13956350ejb.686.2022.10.20.01.07.55; Thu, 20 Oct 2022 01:08:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=lULIsknr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230512AbiJTHxG (ORCPT + 99 others); Thu, 20 Oct 2022 03:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230489AbiJTHxE (ORCPT ); Thu, 20 Oct 2022 03:53:04 -0400 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E79118796 for ; Thu, 20 Oct 2022 00:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666252343; bh=IDxcId1QkT7hrlZDNW6yFY1xSb80oaphOlu0dv7CxTI=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; b=lULIsknrK7h2gT9YSw6Nm7OI6qDBJNaWDtmoTnvq+RnIemTK9mZQTe/RZq14dxb6r OgJz/2frvCHR49bUiKqFQjJRsAmGj5fkEBWOEgLXouZI2Z0uCCdQadVFffeaq1t8Co wQaOoA1DlBc93A+EijkoCmh5oZwnBpyP1DW2Vgg0= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Thu, 20 Oct 2022 09:52:23 +0200 (CEST) X-EA-Auth: uFKiTbVSLLsHOwrxlJNQ2/+NSGS5G7jnaBTa8x7mBmImRrJp0lk6jBMqryZJI0j9MRaoSFmWWw2fYjCJRTbnH+fb9yrP12mX Date: Thu, 20 Oct 2022 13:22:17 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH v3 00/10] staging: r8188eu: trivial code cleanup patches Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747193241779282265?= X-GMAIL-MSGID: =?utf-8?q?1747193241779282265?= Address different kinds of checkpatch complains for the staging/r8188eu module. The patches are required to be applied in sequence. Changes in v3: 1. Patch 4: Extend the __constant_htons to htons change to other files of the driver. This was suggested by philipp.g.hortmann@gmail.com 2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com 3. Patch 5 through 10: Included in this version. Additional clean up patches. Changes in v2: I incorrectly labeled the first revision as v1 instead of v2. So, following change recorded under v1 is actually changes for v2. Feedback provided by philipp.g.hortmann@gmail.com 1. Improve language / grammar for the patch descriptions 2. Further improve code reformatting Deepak R Varma (10): staging: r8188eu: use Linux kernel variable naming convention staging: r8188eu: reformat long computation lines staging: r8188eu: remove {} for single statement blocks staging: r8188eu: use htons macro instead of __constant_htons staging: r8188eu: correct misspelled words in comments staging: r8188eu: Add space between function & macro parameters staging: r8188eu: Associate pointer symbol with parameter name staging: r8188eu: replace leading spaces by tabs staging: r8188eu: Put '{" on the symbol declaration line staging: r8188eu: Correct missing or extra space in the statements drivers/staging/r8188eu/core/rtw_br_ext.c | 122 +++++++++--------- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 36 +++--- drivers/staging/r8188eu/core/rtw_recv.c | 8 +- drivers/staging/r8188eu/core/rtw_xmit.c | 14 +- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 4 +- .../staging/r8188eu/include/Hal8188EPhyReg.h | 4 +- .../staging/r8188eu/include/osdep_service.h | 4 +- .../staging/r8188eu/include/rtl8188e_hal.h | 6 +- .../staging/r8188eu/include/rtl8188e_spec.h | 18 +-- drivers/staging/r8188eu/include/rtw_cmd.h | 52 ++++---- drivers/staging/r8188eu/include/rtw_io.h | 28 ++-- .../staging/r8188eu/include/rtw_ioctl_set.h | 4 +- drivers/staging/r8188eu/include/rtw_mlme.h | 22 ++-- .../staging/r8188eu/include/rtw_mlme_ext.h | 12 +- drivers/staging/r8188eu/include/rtw_recv.h | 4 +- drivers/staging/r8188eu/include/rtw_xmit.h | 2 +- drivers/staging/r8188eu/include/wifi.h | 12 +- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +- 22 files changed, 181 insertions(+), 185 deletions(-) --- 2.30.2