From patchwork Fri Oct 28 16:47:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 837 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp934777wru; Fri, 28 Oct 2022 09:49:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Jq7/ySfzXc2NPmTD+q9q/9pMi2iYJiX9qjD47oqcZgr6YWXYaKrJj9DibfvCgKqzGX8H+ X-Received: by 2002:a63:354e:0:b0:439:837:692f with SMTP id c75-20020a63354e000000b004390837692fmr411042pga.74.1666975740662; Fri, 28 Oct 2022 09:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666975740; cv=none; d=google.com; s=arc-20160816; b=R5RhhFuKz8q7kBwbKh0gBA1Me2UKXccKy/7d/CHH9EKRq9vQ+yllTwMjhN39HSxjXM pdt6l8MJqmJxddi27o4SVoOD5EPeGtmGpQTntCcvABW3zLd2fAyQaLOmAQePamErv3b8 UG0AfNP6TgG/ZNqtnPXA0PLn45zMtSiQNuAEqHRVvQujTDqec2Ye3z9Z5awpWw7aTNOR poyE7yFOuB5oSYGlQ7XWKofuBk9VGqiSTf4bbb7O5SlwWuFP/2fihYmXC9jIxyO0gOu4 0rFXDv+CD8N9LEDtUmrQfCgjAp8Qy6q98obMesv2xeVzNtOG4m5K6Wi4PmdjwAAfyrZu j/8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=Vf6WNjRrnNoJD4F4zYNGY5IkKPLfI5Fyrgdl2dIKPkg=; b=e2NXR4+p1tEHnXJIVlvJHCFLi4WR5mpLhWUqvcbZVvK1RlKrfi03shP75Z9GvvM1RS xcRvhkEr8plv5H9mh6BSxPkoglFBFsrzsmArxJ0QDggsqDc5z3gzcRquGbk1Sv5WA80U 2AqKCVKV6VYcGvVqZ4McKLRKvNI9RZRpTbluBycPuGWjO6f7kNTYoyHh2/kpC966Kd+w fpH4GOK8hSaI9TIglw/ZkCJ9y5+zbR1i67kggFoX4+XTITNaiD10IYzk1oKv9YvcqfD1 aievBxxqcACH3Wq2T2vZqKLXWXgeQNu/pdFMgb3n6AmHl9M0/7k0aqRdztSjBIpEB4t4 6ckg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=OiJXxZFj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a170902f38200b0017f74b810c4si5004094ple.53.2022.10.28.09.48.47; Fri, 28 Oct 2022 09:49:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=OiJXxZFj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiJ1Qr0 (ORCPT + 99 others); Fri, 28 Oct 2022 12:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiJ1QrY (ORCPT ); Fri, 28 Oct 2022 12:47:24 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E490B86FAA for ; Fri, 28 Oct 2022 09:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Vf6WNjRrnNoJD4F4zYNGY5IkKPLfI5Fyrgdl2dIKPkg=; b=OiJXxZFjIgvS2nP1y/trRByLMx V1XmqNfeE7TNpwiT+CMIBDPjRcvnUJ7vufyCZDwry5onEe2Ie6tkB+QiylpEVrZ5QLx6dXiygSZVL NdOxGlXWXXejqRo9/QPu65ZLCTOtVWk7wlVJTssUXAeQkSwg+u6uBEmMLNTmLjZ1WQfWzK+xgUixA Yp1mG+7ovLt6Jyq27wfG/37idoKwp35zTsdSKoWGE/p+WSAVAIbQWL6EAbpXu070RDl4fyrRWZ7g0 ncF+I5f1d6AbYcO3zxfazO4WFirlmfgdqnEawT/ex+0cNXARrQogSfHp0l6sMMmoVQQ3tD6c5V8v5 ysaWThAg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35010) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ooSVr-00006C-E5; Fri, 28 Oct 2022 17:47:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ooSVp-0002ia-75; Fri, 28 Oct 2022 17:47:17 +0100 Date: Fri, 28 Oct 2022 17:47:17 +0100 From: "Russell King (Oracle)" To: Yury Norov Cc: Catalin Marinas , Linus Torvalds , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , Mark Rutland , Will Deacon Subject: [PATCH 0/5] ARM: findbit assembly updates Message-ID: MIME-Version: 1.0 Content-Disposition: inline Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747950754410890144?= X-GMAIL-MSGID: =?utf-8?q?1747950754410890144?= Hi, This series updates the arm32 assembly versions of the findbit operations: - Document ARMv5 code that calculates the bit offset - Provide an updated ARMv7 implementation using the rbit instruction - Switch to use macros instead of duplicating mostly identical code - Switch to using word loads rather than byte loads - Add unwinder information for backtracing I've had it sitting around in-use for some time, and no issues have arisen. Tested also outside the kernel tree in userspace and results are the same with the previous implementation. Testing with the find_bit benchmark module shows that these operations coded in assembly are faster than the generic versions (previously posted), so I believe they're worth keeping. arch/arm/include/asm/assembler.h | 6 + arch/arm/lib/findbit.S | 230 +++++++++++++++------------------------ 2 files changed, 94 insertions(+), 142 deletions(-)