From patchwork Fri Mar 1 13:39:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Smirnov X-Patchwork-Id: 21206 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp1082435dyb; Fri, 1 Mar 2024 05:40:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXI0b2/AcbuSMQIQVp/tdqMh8JAmbhlDoYXcjPNhAYd09w0SEZc86bPQ7pHIKR5ccNB6fERS/2YMsheOwwA79L6moEQ9A== X-Google-Smtp-Source: AGHT+IEmuNu5JRqILh03SdnOopqhS1Oj55j3E5kvi/Jqk83hmmvQqVdMEpFT6mfcLBMf1j6kDZTu X-Received: by 2002:a05:6a00:1486:b0:6e5:109b:959 with SMTP id v6-20020a056a00148600b006e5109b0959mr1780526pfu.25.1709300409545; Fri, 01 Mar 2024 05:40:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709300409; cv=pass; d=google.com; s=arc-20160816; b=Byv/X1xdLfIIJzwpPuGOcw3cMIecZtOqAUM+qjoScpnjbmhTBvkkc9/Cw0aiUqc2x8 0RPekOevOe39OTBykKpAYeh/9ZuMzf4ZJgHgutIS6xNzR3qHCTosHlHC967Ht2BasgO7 4Qx+gaDW6DDwVR38Fpy7l91QAtoiq6UI37ptPgVfvQGnSaEJDnw0Ku5YXSrxlZ4VdkjB oO/FHQY/e8xKZDKYzdns5skViDjJTE+lOdKDa7S0M6W49PWYHvNzTgY6/wbPp0qfShlf wDkF6lpkDL3I2qClaE9sQg68jkoa4sMLXdFHXg698I4fBKRMTHqRkDqKsLjZ+To+euBe Ybaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=wOIyWu+vYxy3LoWl7ibc4LCJUEkWqxBv50Samg5PQ0A=; fh=vS2DIshGwiXnQOBX+JfohZLp+LIEjgFwWtpde/H2ycQ=; b=npMtnVY/rQdubfoy4bOh1hRfUTB6BC2LswfXmMG9IclUNEZyh4kzBBna+/uKIlJ94m 1xAZmuSsZ8/7KF60VZGyS46X2YL7Y/Wyt36xG78yJ9iljqJHUaW89xnRejKPk5MbU7Ku QhizaK1jbd21AH8QIftlMNeKjwbHHM7SxcqWUx2JDRQAGiTTFlAC81MtJrsBfShTecKu V+Oc42B79rhoU+SVtUGOmLGrrIU/hCp1Cn2E6n8HAojTRZwUwbJSV1ZPm0EnDXBlCL+f gvwk+oF8X2O7Fs0LaPkngfkoHpxUoStYCeIotr6CWWuCUM4r/PXvfHYkBWdjbtIeldkW /RiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-88495-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88495-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i123-20020a62c181000000b006e59edebc3bsi2765087pfg.242.2024.03.01.05.40.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:40:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88495-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-88495-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88495-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5D7E9281A55 for ; Fri, 1 Mar 2024 13:40:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E32466EB5C; Fri, 1 Mar 2024 13:39:46 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32886EEF7; Fri, 1 Mar 2024 13:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709300385; cv=none; b=ABLNJlQ3k0oAkV0ALG88dficE0pvxnLGUNWsbSYIhkjxXK0oaT64mTBCRGaUqPviLg29IOQaUD7Q9w/Ch5Qlxvm+JFWuNQx8mKGCOb4fCFkPKkTLwNTwWWZ6441CsaOk8Hk8rSEReUZfUfwZm4IG5MRNb8o5YTvHQTPljPe8l9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709300385; c=relaxed/simple; bh=E0+vbiUDxoe17ISOEKr8wcAHJ3zgj4S9zufaCp1mH30=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Q64+B5CoATWDJvv0UrpBEUzWppqLZJyIaoEE9ROzCyKwQTSQPEJZ0ey6qT3t7BW88dQpQHJ9nYykXWoXi+ynqsVA0lb+9rpdQXdVnbypBfP5FZRb5HJTZm34bAbJ69SpGOpSBcBIS0yhsTrvyVeQUaULT1aiYSoqtxxcCcn+yfU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from r.smirnovsmtp.omp.ru (10.189.215.22) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 1 Mar 2024 16:39:34 +0300 From: Roman Smirnov To: Marcel Holtmann CC: Roman Smirnov , Johan Hedberg , Luiz Augusto von Dentz , Sergey Shtylyov , , , Subject: [PATCH v2 0/2] Bluetooth: mgmt: remove useless NULL checks Date: Fri, 1 Mar 2024 13:39:14 +0000 Message-ID: <20240301133916.1268403-1-r.smirnov@omp.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 03/01/2024 13:19:36 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 183893 [Mar 01 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;r.smirnovsmtp.omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/01/2024 13:26:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/1/2024 10:14:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792309310220842444 X-GMAIL-MSGID: 1792331386184008675 Svace reports NULL check after dereference in mgmt_set_connectable_complete() and add_ext_adv_params_complete(). The following patches remove these checks. The second version has a more compact subjects compared to the first version. Found by Linux Verification Center (linuxtesting.org) with Svace. Roman Smirnov (2): Bluetooth: mgmt: remove useless NULL checks in mgmt_set_connectable_complete() Bluetooth: mgmt: remove useless NULL checks in add_ext_adv_params_complete() net/bluetooth/mgmt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)