From patchwork Fri Mar 1 08:07:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ethan Zhao X-Patchwork-Id: 21198 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp987266dyb; Fri, 1 Mar 2024 02:36:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUUqkQufdvb4P/5lFfx0EALSA2SQ+KBD9kwEJz5yb3HbEJEuw/Sh8cSD7clz+7vraxpCgP/LEGqvfpow0PnJckIEj8GBg== X-Google-Smtp-Source: AGHT+IG8YjInVBGM0LD9f5EnQwqrN/pm5LvGrVFrPMhmz4mAa946YEu2VXe7MkblJrk1oZQtANYF X-Received: by 2002:a17:906:3c17:b0:a43:86f3:b00b with SMTP id h23-20020a1709063c1700b00a4386f3b00bmr915743ejg.0.1709289397960; Fri, 01 Mar 2024 02:36:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709289397; cv=pass; d=google.com; s=arc-20160816; b=JbaXD7SF1kfXDjvLnlKv2ahEqYfjRJII1rXYn/EE1HRKB9JS3SkY5pxE6nTze1GJkG t/K9LmrX84qzVTceipp3LmaN14m6BWp7ZtSkHiv6Nae/u3t3roasXCn4q31fYuHj56W7 3DG+Zc4scZV1d9mww+eekKFt7AkNUrO3s9xK2L3f4S0XEBLEqUHQsjf3MKzV0J37ZpaB 6QV0arS+AwG7KS/iDH7UOqqBSS8DS8wHTzOvLHVh+ATmuWWg5HD4NPHWGvbmfy2PNx19 dBHPuIUgeHq+yQgHPS0FHzdeZH9k5fKDaydGnugRzpx2gv4oEYNDq5elo8mDxh9uwTeP kNyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=/i0ahgSPGlOBtDYzt8diwKM2CTSV1z5qcGim0B51DDQ=; fh=CcvPup2qFKOU+RSlxpmYRdCRaLkLlngXWCtLCjXBjlA=; b=Ti6ZluSl24bDgHVBpa6+fv+f/BYlMjtD9U73NYrWI2REVKEB0s4pSV9oNe8EOu8l+f iZeRZ/AIR5Q8fUGJB7Wr8REZxp3Ke/c9r6mSWPRQ6o9d7hPMGKpDWGgQdUyivl4W2l7t dCxtEMjQGrXlIgjqf1ejKJLQleMig2jFkSNxMDVtodD5XfF/v5ZzU5HoOYpZ9xwA3G4A tBt8eSmkkTtDGz8xNYWhHOsH19M+lfa4r8z85aLl1Yr5boBMYka6T17LVf0NSqV/vgGb mXegdbGVyqW/zlyGtmlRHTgZgFFZLyF0WnmU+fNCMh9wUSsQgRIaFYqPwn6iLX6Q/vOP 39/g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YPkDYd2X; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-88048-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88048-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e27-20020a170906081b00b00a448dacfa8bsi408939ejd.58.2024.03.01.02.36.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 02:36:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88048-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YPkDYd2X; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-88048-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88048-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 88C081F25983 for ; Fri, 1 Mar 2024 08:08:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 09A3F69D28; Fri, 1 Mar 2024 08:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YPkDYd2X" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6498A69970 for ; Fri, 1 Mar 2024 08:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709280467; cv=none; b=Lvj07yGuhg8WUu61ADuB2VbNIgCwBC0vZ5xapG8VwdJOGPuwbCDWhjrbxFqEt1MkEpTWqlInRkUdDlDDT9tynXUJn9aIA6QV2whwxDtC/jwExgUFGG1jwyqyj8pSiyTdTPosXJHGa/qHMbJealc4suZz6U5gUWHMqFdYmIbxB2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709280467; c=relaxed/simple; bh=vtBsxDUN0mZSlkutEWcnxc6lRCMfEsZZFVzveFyo3e0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NlAu0dIqUDNhay3wWY5BPHIloY/nSB1OkFASKa0oa47i1HZ86RtkA5iSeHN2YPx8vvv5oXYFh11XkKp85w1lS/MLhQEDJ9cmZWxhfL2aHneS8C+/LfGP1EF9dgj9Jjalug8JH3OZnntgpLqmPqLCOkGm4QpkQEJy9HViueb7YGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YPkDYd2X; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709280466; x=1740816466; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vtBsxDUN0mZSlkutEWcnxc6lRCMfEsZZFVzveFyo3e0=; b=YPkDYd2XgIlW4wzSomwfjhR3Sj2fSuV0ARCOCmQq4sk4DuWhfT9uZ/RE OwXw4CTQKKktycHystDryk9/GOlsKQK27o1shNgOZj153RnQkge8SR7Vp rdacUoiqzPDEt1qzEV34cZGUz5kFYgatmSkslQnzkXR9U+FLkhpyD/h1B bDc6AOhE/gjTDSO7opE5tbpvihAe6YNvbEw+RrR4lWMGdGNBgpW1UMQcw YlgTFWvhg2dMBHyconjhijWujYT9OvU1qJtPVPj0Mc7aD+9F7pdKFBQaP jHTnOotQBubLrftJKeuDDq935pqQwB1HbdC+70wDetVKwZW5vX8Ht0KSu w==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="15240393" X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="15240393" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 00:07:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,195,1705392000"; d="scan'208";a="8187457" Received: from unknown (HELO ply01-vm-store.amr.corp.intel.com) ([10.238.153.201]) by orviesa009.jf.intel.com with ESMTP; 01 Mar 2024 00:07:40 -0800 From: Ethan Zhao To: baolu.lu@linux.intel.com, bhelgaas@google.com, robin.murphy@arm.com, jgg@ziepe.ca Cc: kevin.tian@intel.com, dwmw2@infradead.org, will@kernel.org, lukas@wunner.de, yi.l.liu@intel.com, dan.carpenter@linaro.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Zhao Subject: [PATCH v14 0/3] fix vt-d hard lockup when hotplug ATS capable device Date: Fri, 1 Mar 2024 03:07:24 -0500 Message-Id: <20240301080727.3529832-1-haifeng.zhao@linux.intel.com> X-Mailer: git-send-email 2.31.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792319840060183815 X-GMAIL-MSGID: 1792319840060183815 This patchset is used to fix vt-d hard lockup reported when surprise unplug ATS capable endpoint device connects to system via PCIe switch as following topology. +-[0000:15]-+-00.0 Intel Corporation Ice Lake Memory Map/VT-d | +-00.1 Intel Corporation Ice Lake Mesh 2 PCIe | +-00.2 Intel Corporation Ice Lake RAS | +-00.4 Intel Corporation Device 0b23 | \-01.0-[16-1b]----00.0-[17-1b]--+-00.0-[18]----00.0 NVIDIA Corporation Device 2324 | +-01.0-[19]----00.0 Mellanox Technologies MT2910 Family [ConnectX-7] User brought endpoint device 19:00.0's link down by flapping it's hotplug capable slot 17:01.0 link control register, as sequence DLLSC response, pciehp_ist() will unload device driver and power it off, durning device driver is unloading an iommu device-TLB invalidation (Intel VT-d spec, or 'ATS Invalidation' in PCIe spec) request issued to that link down device, thus a long time completion/timeout waiting in interrupt context causes continuous hard lockup warnning and system hang. Other detail, see every patch commit log. patch [1&2] were tested by yehaorong@bytedance.com on stable v6.7-rc4. patch [1-3] passed compiling on stable v6.8-rc4 (Baolu's rbtree branch). This patch set is based on Baolu's device rbtree patchset https://lore.kernel.org/lkml/20240221153437.GB13491@ziepe.ca/t/ change log: v14: - made some adjustment to patch[3/3] per comment from Baolu, Dan, Bjorn. - add fixes tag to patch[3/3] per Dan's sugguestion. - add ack tag from Bjorn to patch[1/3] - add review tag from Dan. v13: - rebased on Baolu's rbtree patchset. - removed refactor patches [3/5][4/5] in v12. - amend commit description of patch[3/3]. - https://lore.kernel.org/lkml/2d1788da-521c-4531-a159-81d2fb801d6c@ linux.intel.com/T/ v12: - use base-commit tag to format patch. - fix building issue on v6.8-rc2 repported by lkp@intel.com. - https://lkml.org/lkml/2024/1/28/535 v11: - update per latest comment and suggestion from Baolu and YiLiu. - split refactoring patch into two patches, [3/5] for simplify parameters and [4/5] for pdev parameter passing. - re-order patches. - fold target device presence check into qi_check_fault(). - combine patch[2][5] in v10 into one patch[5]. - some commit description correctness. - add fixes tag to patch[2/5]. - rebased on 6.8rc1 - https://lkml.org/lkml/2024/1/25/1314 v10: - refactor qi_submit_sync() and its callers to get pci_dev instance, as Kevin pointed out add target_flush_dev to iommu is not right. v9: - unify all spelling of ATS Invalidation adhere to PCIe spec per Bjorn's suggestion. v8: - add a patch to break the loop for timeout device-TLB invalidation, as Bjorn said there is possibility device just no response but not gone. v7: - reorder patches and revise commit log per Bjorn's guide. - other code and commit log revise per Lukas' suggestion. - rebased to stable v6.7-rc6. v6: - add two patches to break out device-TLB invalidation if device is gone. v5: - add a patch try to fix the rare case (surprise remove a device in safe removal process). not work because surprise removal handling can't re-enter when another safe removal is in process. v4: - move the PCI device state checking after ATS per Baolu's suggestion. v3: - fix commit description typo. v2: - revise commit[1] description part according to Lukas' suggestion. - revise commit[2] description to clarify the issue's impact. v1: - https://lore.kernel.org/lkml/20231213034637.2603013-1-haifeng.zhao@ linux.intel.com/T/ Thanks, Ethan Ethan Zhao (3): PCI: make pci_dev_is_disconnected() helper public for other drivers iommu/vt-d: don't issue ATS Invalidation request when device is disconnected iommu/vt-d: improve ITE fault handling if target device isn't present drivers/iommu/intel/dmar.c | 22 ++++++++++++++++++++++ drivers/iommu/intel/pasid.c | 3 +++ drivers/pci/pci.h | 5 ----- include/linux/pci.h | 5 +++++ 4 files changed, 30 insertions(+), 5 deletions(-) base-commit: e60bf5aa1a74c0652cd12d0cdc02f5c2b5fe5c74