mbox series

[net,0/2] selftests: mptcp: fixes for diag.sh

Message ID 20240301-upstream-net-20240301-selftests-mptcp-diag-exit-timeout-v1-0-07cb2fa15c06@kernel.org
Headers
Series selftests: mptcp: fixes for diag.sh |

Message

Matthieu Baerts (NGI0) March 1, 2024, 5:11 p.m. UTC 
  Here are two patches fixing issues in MPTCP diag.sh kselftest:

- Patch 1 makes sure the exit code is '1' in case of error, and not the
  test ID, not to return an exit code that would be wrongly interpreted
  by the ksefltests framework, e.g. '4' means 'skip'.

- Patch 2 avoids waiting for unnecessary conditions, which can cause
  timeouts in some very slow environments.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Geliang Tang (1):
      selftests: mptcp: diag: return KSFT_FAIL not test_cnt

Matthieu Baerts (NGI0) (1):
      selftests: mptcp: diag: avoid extra waiting

 tools/testing/selftests/net/mptcp/diag.sh | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)
---
base-commit: 1c61728be22c1cb49c1be88693e72d8c06b1c81e
change-id: 20240301-upstream-net-20240301-selftests-mptcp-diag-exit-timeout-207d7925b7c0

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org March 4, 2024, 1:10 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 01 Mar 2024 18:11:21 +0100 you wrote:
> Here are two patches fixing issues in MPTCP diag.sh kselftest:
> 
> - Patch 1 makes sure the exit code is '1' in case of error, and not the
>   test ID, not to return an exit code that would be wrongly interpreted
>   by the ksefltests framework, e.g. '4' means 'skip'.
> 
> - Patch 2 avoids waiting for unnecessary conditions, which can cause
>   timeouts in some very slow environments.
> 
> [...]

Here is the summary with links:
  - [net,1/2] selftests: mptcp: diag: return KSFT_FAIL not test_cnt
    https://git.kernel.org/netdev/net/c/45bcc0346561
  - [net,2/2] selftests: mptcp: diag: avoid extra waiting
    https://git.kernel.org/netdev/net/c/f05d2283d111

You are awesome, thank you!