mbox series

[v4,0/4] iio: adc: ad7192: Add support for AD7194

Message ID 20240228122617.185814-1-alisa.roman@analog.com
Headers
Series iio: adc: ad7192: Add support for AD7194 |

Message

Alisa-Dariana Roman Feb. 28, 2024, 12:26 p.m. UTC 
  From: romandariana <alisa.roman@analog.com>

Dear maintainers,

Thank you all for the feedback!

I am submitting the upgraded series of patches for the ad7192 driver.

Please consider applying in order.

Thank you!

v3 -> v4
        - drop device properties patch, changes already applied to tree
        - change bindings and driver such that for AD7194 there are 16
        differential channels, by default set to AINx - AINCOM, which can be
        configured in devicetree however the user likes
        - corrected mistake regarding positive and negative channel macros:
        subtract 1 from the number corresponding to AIN input

v2 -> v3
	- add precursor patch to simply functions to only pass
	  ad7192_state
	- add patch to replace custom attribute
	- bindings patch: correct use of allOf and some minor changes to
	  the ad7194 example
	- add ad7194 patch:
		- use "ad7192 and similar"
		- ad7194 no longer needs attribute group
		- use callback function in chip_info to parse channels
		- move struct ad7192_chip_info
		- change position of parse functions
	- drop clock bindings patch

v1 -> v2
	- new commit with missing documentation for properties
	- add constraint for channels in binding
	- correct pattern for channels
	- correct commit message by adding "()" to functions
	- use in_range
	- use preferred structure in Kconfig

Kind regards,

Alisa-Dariana Roman (4):
  iio: adc: ad7192: Pass state directly
  iio: adc: ad7192: Use standard attribute
  dt-bindings: iio: adc: ad7192: Add AD7194 support
  iio: adc: ad7192: Add AD7194 support

 .../bindings/iio/adc/adi,ad7192.yaml          |  75 ++++++
 drivers/iio/adc/Kconfig                       |  11 +-
 drivers/iio/adc/ad7192.c                      | 218 ++++++++++++++----
 3 files changed, 250 insertions(+), 54 deletions(-)

Comments

Andy Shevchenko Feb. 28, 2024, 7:50 p.m. UTC | #1 
On Wed, Feb 28, 2024 at 02:26:13PM +0200, Alisa-Dariana Roman wrote:
> From: romandariana <alisa.roman@analog.com>

> Alisa-Dariana Roman (4):

Please fix and align the following:
- email From line (submitter)
- SoB tag(s)