From patchwork Sun Feb 25 14:12:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 20927 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp1593789dyb; Sun, 25 Feb 2024 06:13:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWDF2mEw8HtYN6MeyMinNxRMgiU4HWFkt3umBIOUak5tHB8BmLPbZa8mnKOXBxS5BV4msr/lyLNwPjRx1Ff1H7r0p0igg== X-Google-Smtp-Source: AGHT+IE087IE3cfFT67aqlWTm/uWgzpFCmtG85XpLB695cJdm9MQ/Y+fc+Y536LU7xYrjnF1uxU6 X-Received: by 2002:a05:620a:5646:b0:787:bb67:86c1 with SMTP id vw6-20020a05620a564600b00787bb6786c1mr6010383qkn.60.1708870401485; Sun, 25 Feb 2024 06:13:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708870401; cv=pass; d=google.com; s=arc-20160816; b=k4tllyzYFqRA30teWcdR+MwU1md8cnQ5alHdbD4sZ4sFuphCFLE+6sYEQFFxby2q+J OIlpa+EZTHtPN2tCXG7HX4WUcplADLjy9AQtHP/qojHxlwAlgJXN/j/Qwt+yFucJDPwi 84DbTy0jBdtmgFl+zpFHcxG3HYvK97Sg2NmvZOo6hywHhY3OPpPwgQJv0nI2imG5y2UG 3kXyVvvSVQE5YBIzhyG/llW8rmJjm4uK3CNijphoCESKME2x02ymaWU5NNarZOIu+tb6 SofUYQNxKB2rvsu3XMFScdDW6gmgXWxMoTEVAlPO3DQNp3e2af3pVRQQhhBqyd/u4EgK qYZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=4jp7b6W11oTt4eacy444Z/1g5qUWokbD1FKYrflZ4dE=; fh=yJ4Crdp4SkJotc27hxMunh/6fsW9TW5D/mUUW3AazDo=; b=dRg6P2nXzb0ney4+T65NbtXlN+/O4JSBrrpNucEbpCfR2oOZlV6NctRsQJ0RJRr/fi qLtM4TBHiafu1i7qahAFaG7OarKoW7x9W7K93vw/NoK9B5KXAM9r/oWVnuC6VC/Ej3US wsKUNjIAvuXI8I1WF0A1BfDl8g3C65O+9lkqAkaEqFRLK4UIyPtDxZg4N8JKtUoF2ib8 7BeDq/eGvj7qFFT6LPbIU7eoee/iuQUFAZeDtJ4rdlmBw+jh2HZDXVM9y1UWuTixyQSQ 8SxewzJpfhxNXyFz15OIShjtUdEmtc+ffBTdDAOSsU5WFzCvqtSQqlZ63U3Q+S1NYgHj 3rsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A2gkvpxf; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-80088-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80088-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s23-20020ae9f717000000b007871f016edbsi2982619qkg.620.2024.02.25.06.13.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 06:13:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80088-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A2gkvpxf; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-80088-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80088-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 488441C20A72 for ; Sun, 25 Feb 2024 14:13:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F92514A8D; Sun, 25 Feb 2024 14:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A2gkvpxf" Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 695DF12B87 for ; Sun, 25 Feb 2024 14:12:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708870372; cv=none; b=KJPcz1BAMfFW53HAUwweKZFXHVx+0nHhhxKbFjEV1GK5mCicQlghewV+5/NVjVNGQXP2e1/3F6PBahKPDZCl9n1M40IV8P/gMtgMoUQn389p9Puig3YZmLLLwwft30YFsoXjqbRHx/dcfUkbGVu6/ksTxxVtUkJ9+5Cxjmkdhvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708870372; c=relaxed/simple; bh=KOC17kShUQKZuxuTXp3eBvMi5MEvpIBdA3gtxscdztU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=coOCZZZ2iIzPGkzlhdsb95PipJGYyjTWueZJVNxmss1p2dFATAaLgGryYowu/LnqaV8p80uEb9vDRgyKy4uMNDjNbCUeYEKhQDkLPpAxJd+koa8vArsAfxS4Ll8jw66wyMpRz2658RmgvYeeXJN3XQKgU4pi+Bd+fp9A6jKgY90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A2gkvpxf; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-512ed314881so1834904e87.2 for ; Sun, 25 Feb 2024 06:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708870368; x=1709475168; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=4jp7b6W11oTt4eacy444Z/1g5qUWokbD1FKYrflZ4dE=; b=A2gkvpxfa197tacI+XrLMYh7ORjRFf6g4xSuUuBYfNjFvA1/+dx6LNx+pmOIUF20ik +mOuz1fd3IYRo2i2EojpP0ws3im3G2oW7NRCakxSsaM7iVGdZ2SEH0vLFlWXzINI+kit 1yIvLJ78pUfftDDeAFFsUyi5CaCLJ1bNXdT8spHf/k+i8IMfUSse1Z37NaKl2wE2tkRu DFKfmIx//5clhYToSWUZEx3Ul5SBojoEj3adJIT462wXSdWdqEALLfP+iNF2PjiPev1A zAbYZqqfJoEZcWtlz+l1eSJ3wVAgQhwbr8pcMzCMcUtr+p79UAb6QY2W5S/kCZiaWV0P 3CDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708870368; x=1709475168; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4jp7b6W11oTt4eacy444Z/1g5qUWokbD1FKYrflZ4dE=; b=D2tPVrOne0IGFFgHnlkrtYA3pKaADoXytac9ghrNruE66MAWa0AEfyLCONfWk9kde5 q9RcxkEVSwUcG1xcjCx31ngW64vRNWfYXvHq4BuJENdGLMbSub2+2QEKCxuQg47fHLPF W0ZrYkS6aHNr3jm5z4j93B01kT4E75yX7cS1skd/t+/XuGUyhiBf33Abxmfj8H6NYYQI QdbXU893iylN5Rhi1y0WvsMaokKk6EucV57EQAdY7kpLm9mQos7vFc64uYe7zOQolriR SK2oTOxIGXRV+d0/bLMqqkwrjbcGLjRKKEV424on0N0hu49Wn5/XAylCBXXyn+KKwLM9 zaog== X-Forwarded-Encrypted: i=1; AJvYcCVHAuEr/fHPxI5MtPwrZXAglnnpjgePGt83fp4+77xbvJl1kNubUH1L/V+EAyPPuaoz+UQzhffoKY1+5QIdxYA+qSpIFFgPi+IHS6yU X-Gm-Message-State: AOJu0Yx9HNC3CQpFFrUMr5w2HTLq+mN5IEh1M2bVe5nyALxR5n4vInDZ qKOfWYuYlexnYI/gXJYMjm2gexg1dZSP71DxEYIZYJaQn8bIjMvOb2QhTh3vtj9xfSENM4lBviF s X-Received: by 2002:a05:6512:3b99:b0:512:f68b:69de with SMTP id g25-20020a0565123b9900b00512f68b69demr1507476lfv.45.1708870368483; Sun, 25 Feb 2024 06:12:48 -0800 (PST) Received: from umbar.lan (dzyjmhybhls-s--zn36gy-3.rev.dnainternet.fi. [2001:14ba:a00e:a300:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id w13-20020ac254ad000000b00512e5bd2296sm522931lfk.217.2024.02.25.06.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 06:12:47 -0800 (PST) From: Dmitry Baryshkov Subject: [PATCH v3 0/3] drm/msm/dpu: debug commit_done timeouts Date: Sun, 25 Feb 2024 16:12:45 +0200 Message-Id: <20240225-fd-dpu-debug-timeout-v3-0-252f2b21cdcc@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAN1K22UC/4XNQQ6CMBCF4auYrh3TFtIWV97DuAA6hUmUkhYaD eHuFjbGhXH5v2S+WVjEQBjZ+bCwgIki+SFHcTywtq+HDoFsbia5LLngCpwFO85gsZk7mOiBfp4 AK6Edb1rDVcHy6RjQ0XNnr7fcPcXJh9f+JYlt/QMmAQKUrbSSxpSqFJc7DXXwJx86tolJfhTJz Q9FZqVyFddONNYa/aWs6/oGUhPVA/8AAAA= To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter Cc: Steev Klimaszewski , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1474; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=KOC17kShUQKZuxuTXp3eBvMi5MEvpIBdA3gtxscdztU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl20rfF+Ce8/b+rwxO9i085gWzGPOjk1Ty1z55/ p/vHHN8swSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdtK3wAKCRCLPIo+Aiko 1WFWB/0RI4QxaBJJDCkXRRz4JUQw4rpV3NyPXWfuMOmXh/wKqGkPNZdkp17kjSwd8f7zUJ+TiZ8 0psZLdDPQDomXTqCEM6R7gN0/rYgXQFjxZO65S5gPORP54iJ6pKy+gI1wKIAtRlG2NLokVCYeUn LPny3QhF7weIIJdJaqugDuYLEtbHDTIVq2OYzpxCaZAzNxx5UAGxovX7t7KEbljSQuUXxm4qDCS FoLlvXdVKFN4+TeEnhi3+lkHgREOECAaVE6tzCwIuhvSNlHICVkCPvvlb+oHCSBaGrS2O61YFJo /TjublUJ+Lo2EN6NFLCtZxVqY8rjRQWnqc29cZ4M87ZJ4hWn X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791880490000618950 X-GMAIL-MSGID: 1791880490000618950 In order to debug commit_done timeouts ([1]) display the sticky bits of the CTL_FLUSH register and capture the devcore dump when the first such timeout occurs. [1] https://gitlab.freedesktop.org/drm/msm/-/issues/33 Signed-off-by: Dmitry Baryshkov --- Changes in v3: - Capture the snapshot only on the first comit_done timeout (Abhinav) - Link to v2: https://lore.kernel.org/r/20240208-fd-dpu-debug-timeout-v2-1-9f907f1bdd87@linaro.org Changes in v2: - Added a call to msm_disp_snapshot_state() to trigger devcore dump (Abhinav) - Link to v1: https://lore.kernel.org/r/20240106-fd-dpu-debug-timeout-v1-1-6d9762884641@linaro.org --- Dmitry Baryshkov (3): drm/msm/dpu: make "vblank timeout" more useful drm/msm/dpu: split dpu_encoder_wait_for_event into two functions drm/msm/dpu: capture snapshot on the first commit_done timeout drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 83 +++++++++++++++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 22 +----- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/msm_drv.h | 10 --- 5 files changed, 69 insertions(+), 50 deletions(-) --- base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276 change-id: 20240106-fd-dpu-debug-timeout-e917f0bc8063 Best regards,