mbox series

[v1,0/3] Add support for detecting Controller Level PCIe Errors

Message ID 20240221140405.28532-1-root@hu-msarkar-hyd.qualcomm.com
Headers
Series Add support for detecting Controller Level PCIe Errors |

Message

root Feb. 21, 2024, 2:04 p.m. UTC 
  From: Mrinmay Sarkar <quic_msarkar@quicinc.com>

Synopsys Controllers provide capabilities to detect various controller
level errors. These can range from controller interface error to random
PCIe configuration errors. This patch intends to add support to detect
these errors and report it to userspace entity via sysfs, which can take
appropriate actions to mitigate the errors.

Also adding global irq support for PCIe RC and add corresponding change
in PCIe dt-bindings.

Mrinmay Sarkar (2):
  dt-bindings: PCI: qcom: Add global irq support for SA8775p
  arm64: dts: qcom: sa8775p: Enable global irq support for SA8775p

Nitesh Gupta (1):
  PCI: qcom: Add support for detecting Controller Level PCIe Errors

 .../devicetree/bindings/pci/qcom,pcie.yaml    |  26 +-
 arch/arm64/boot/dts/qcom/sa8775p.dtsi         |  12 +-
 drivers/pci/controller/dwc/pcie-designware.h  |  26 ++
 drivers/pci/controller/dwc/pcie-qcom.c        | 350 ++++++++++++++++++
 4 files changed, 408 insertions(+), 6 deletions(-)

Comments

Manivannan Sadhasivam Feb. 22, 2024, 5:22 a.m. UTC | #1 
+ Shradha

On Wed, Feb 21, 2024 at 07:34:01PM +0530, root wrote:
> From: Mrinmay Sarkar <quic_msarkar@quicinc.com>
> 

You are sending the patches from a wierd account. Please fix it.

> Synopsys Controllers provide capabilities to detect various controller
> level errors. These can range from controller interface error to random
> PCIe configuration errors. This patch intends to add support to detect
> these errors and report it to userspace entity via sysfs, which can take
> appropriate actions to mitigate the errors.
> 
> Also adding global irq support for PCIe RC and add corresponding change
> in PCIe dt-bindings.
> 

There is already a series submitted to add RAS support to DWC drivers [1] and
I've provided comments to check with EDAC maintainers on using the EDAC
framework. If they don't see this as a fit for their subsystem, then we can add
it in DWC drivers.

- Mani

[1] https://lore.kernel.org/all/20231130165514.GW3043@thinkpad/

> Mrinmay Sarkar (2):
>   dt-bindings: PCI: qcom: Add global irq support for SA8775p
>   arm64: dts: qcom: sa8775p: Enable global irq support for SA8775p
> 
> Nitesh Gupta (1):
>   PCI: qcom: Add support for detecting Controller Level PCIe Errors
> 
>  .../devicetree/bindings/pci/qcom,pcie.yaml    |  26 +-
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi         |  12 +-
>  drivers/pci/controller/dwc/pcie-designware.h  |  26 ++
>  drivers/pci/controller/dwc/pcie-qcom.c        | 350 ++++++++++++++++++
>  4 files changed, 408 insertions(+), 6 deletions(-)
> 
> -- 
> 2.40.1
>