From patchwork Tue Feb 20 11:44:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 20658 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp341470dyc; Tue, 20 Feb 2024 03:50:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUX158CQtw5NDxz2oDiJNTu5bsssEkp06R7LmaKW/DXHswIm3lfhMgSShrYvEgSQU55gKblNB7B1m/ynFIwYmxbGBJLrg== X-Google-Smtp-Source: AGHT+IEuqDIpZ5C5CzsmXpADFUViKyOSGnYK0h1EDfReCuTzpUv1mJnhN0yzOCdfgkn2D3TZmKit X-Received: by 2002:a17:902:e88a:b0:1db:e089:746f with SMTP id w10-20020a170902e88a00b001dbe089746fmr6937840plg.6.1708429835371; Tue, 20 Feb 2024 03:50:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708429835; cv=pass; d=google.com; s=arc-20160816; b=kiMPSSeS3O2ghFJuaW6eLyWRJ9sMRurULP+9iETFmxpgC34QeTh8pcFazzIp1qWq+N KoUy0/oq+qeTSX5B/wJUAgxLE+uKb4mvIhvRRgZL3Im9956memtBRkAjzJ9BGtQApZYq rJWMkDP6C/yToI/l6kJBmyvVX5f6xQowp8r6eVim24/NxJjo6fV/w1r3sC2qmzCnHual k+UEnoNQLvQEMsw0JzcODu9uqA5UqDybJ6A32ipNDdO2tncFuHXNOKm9A2bdgrERRqGd 3LXq5qJHAoeE+iBUszMjqNh7K31p84/+7rIfKad281d2FCpHZbkmT17oqm4vA/g+G2q2 QXdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:dkim-signature :subject; bh=xPhvAK2/CwxqosuPKJ0uCWAeLXDmPfN7jw3gdgYocrs=; fh=CIhmbM3N522iZfKAx68dio1DUnYohA/38dvKjB2Sibw=; b=DzwIMfgaCDZhsg17mUXBNbAeFPPPWUdC+t12r16RxwFg6dZza56QF2jeiPlSIv3mok ZBts2Esle2+HgQFW+7I9XaULvcEUVyszx0j8XwhTSPjom+grCN2fGRYOqgcCdN2H0owC PbBjL17QMTQDtRqmlizTcqFFrGt0jMzihwVjzSI0bcjtlHs405bT5FlL45/ZB+xqHTcP xcX0Kt3x5puUfbXSw89szAw7YvJEz5G3iNIJbXWx/9yLkPoPs3/b70GRUs/Aih406hIQ djsJoZ0x/brF56kSiNdwJug3x/vLCbLnsRM2xqCQ0s70Pbj9CGk8Z8W7h+WUrIXMjuFD vTdQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YmHq88Nj; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-72929-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72929-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h8-20020a170902680800b001dbc6f9e3a8si5535481plk.66.2024.02.20.03.50.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:50:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72929-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YmHq88Nj; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-72929-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72929-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 70E15B22B01 for ; Tue, 20 Feb 2024 11:45:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A28A867A18; Tue, 20 Feb 2024 11:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="YmHq88Nj" Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6482F657D7 for ; Tue, 20 Feb 2024 11:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429482; cv=none; b=cM17oT/d5eMoHTLwTW3QBBqoHsBsUYO4YntdhGmCjrpYvgIurS/syfaP9RHuFSpFi5HgncGgLa/xezCBm87523BRMP6z/KpgW5a6RcWrvunPhok6thRtyAU1n3Tvn9B/LMVwptbxZSX9gyAhIEvxV2+pSvvhbceofV531Z1evwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429482; c=relaxed/simple; bh=wFwGQOpNEBJ6RvCPo1NYthjN1KIzKMJfv7sjFw0IOrM=; h=Subject:MIME-Version:Content-Type:From:Date:Message-Id:To:Cc; b=KByJSQNBXccnm+aTS1QlF8PFUKkbBzIyYlTTFuN6sHoCwvGKVDorzrJBA5dsJgeEW9TYOWJiCw8Dq0Ixey69Ar6vLkWlX1Y6QiLCafbAPg+tiRo9QkDnJEs6odywrMIjtYsZhov6tamcAYJllR8dKFys8gsOuGaTMTedMfyR0Xw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=YmHq88Nj; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Subject: [PATCH RESEND 0/3] mm/zsmalloc: some cleanup for get/set_zspage_mapping() DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708429478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xPhvAK2/CwxqosuPKJ0uCWAeLXDmPfN7jw3gdgYocrs=; b=YmHq88Njyhm2Pr867Jk7e9cUM2YgV5Kw5R56B72cWgMekDcZeeLfL0BQPB9jq5YMk5MFmx mOIG0lcvWGGuVitAvxPsy8lXXPjObsqOO+eaM562LT9q7mhHjnN9CBmdLUdgnCr9Jp/3Bl 5wLfMRybgk/lk9sIi0HeifL5arIXVcg= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-b4-tracking: H4sIAJyQ1GUC/43OwY4CIQwG4FcxnMUAA4N68j02HmipDgkyZnDIqpl3t9mz2cyp+Zv8X/sWlaZEVR w3bzFRSzWNhYPebgQOoVxJpshZGGWsMkZJsPJVbyHnESVmCmW+S9erYLU7APQguAmhkoQpFBy4W+ac eTmk+hin59+lpnn8/I82LZV06IgsYox7f4LngyKjtMPxJs5sNrPCMewoH7UjD36P9pvTrXA6doL3Ti N/FDv45tgVjmXncnABLj0pZd0ppzL/7iI1cV6W5QM2/Mo3kwEAAA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 20 Feb 2024 11:44:28 +0000 Message-Id: <20240220-b4-zsmalloc-cleanup-v1-0-b7e9cbab9541@linux.dev> To: hannes@cmpxchg.org, Andrew Morton , Sergey Senozhatsky , nphamcs@gmail.com, yosryahmed@google.com, Minchan Kim Cc: linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1708429476; l=1438; i=chengming.zhou@linux.dev; s=20240220; h=from:subject:message-id; bh=wFwGQOpNEBJ6RvCPo1NYthjN1KIzKMJfv7sjFw0IOrM=; b=7GscvdD0HgdL3NVA9Yals2j5vg6+eQzCDNJ83CWGDzCEBZF3YqfAw/rT+BdvASJen2APnlDj8 yDqQN8Y7o79AW5g1RKPfWYqrkF7aqBy4VANvhGNrzttBKKGJLrKZ4eM X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=5+68Wfci+T30FoQos5RH+hfToF6SlC+S9LMPSPBFWuw= X-Migadu-Flow: FLOW_OUT X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791418523157827415 X-GMAIL-MSGID: 1791418523157827415 RESEND: - The sent patches were put into spam folder because of my mail problem, so resend after I fixed it, sorry! It should be ok this time. - Link to v1: https://lore.kernel.org/r/20240220-b4-zsmalloc-cleanup-v1-0-5c5ee4ccdd87@bytedance.com Hello, The discussion[1] with Sergey shows there are some cleanup works to do in get/set_zspage_mapping(): - the fullness returned from get_zspage_mapping() is not stable outside pool->lock, this usage pattern is confusing, but should be ok in this free_zspage path. - we seldom use the class_idx returned from get_zspage_mapping(), only free_zspage path use to get its class. - set_zspage_mapping() always set the zspage->class, but it's never changed after zspage allocated. Thanks for review and comments! [1] https://lore.kernel.org/all/a6c22e30-cf10-4122-91bc-ceb9fb57a5d6@bytedance.com/ Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky --- Chengming Zhou (3): mm/zsmalloc: remove set_zspage_mapping() mm/zsmalloc: remove_zspage() don't need fullness parameter mm/zsmalloc: remove get_zspage_mapping() mm/zsmalloc.c | 55 +++++++++++++------------------------------------------ 1 file changed, 13 insertions(+), 42 deletions(-) --- base-commit: 207636f0f52428f3b46540b212d6f93c6ac484cf change-id: 20240220-b4-zsmalloc-cleanup-560a4159bb6b Best regards,