From patchwork Mon Feb 19 09:57:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 20581 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1182272dyc; Mon, 19 Feb 2024 01:58:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU9NRb8NddmGzXZ0BOV1TXumZ7iL/AQ5XCkksTNzKx1mkGKMSI3oUGTsAcbBy3BiG1T2vIB77EzI0hYXVapZtBVB1Hs6Q== X-Google-Smtp-Source: AGHT+IFGWIr8VSZ1pVO7lnic4l4olTtmeNzVLiOmihKQnzOg09iHXmTygZyno/pOeYM1PWveqsxc X-Received: by 2002:a17:906:410:b0:a3e:70ee:3c9b with SMTP id d16-20020a170906041000b00a3e70ee3c9bmr2431983eja.13.1708336695010; Mon, 19 Feb 2024 01:58:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708336695; cv=pass; d=google.com; s=arc-20160816; b=bP38lmU8wQZfxTcUNiXby3DTMjnRDnODdCB6vf/nVT5ikUmnXR54jhdsKUqfkLX1ji rbWtFtP0pZ9HS37n1rqEnVRpTN5K1rkuVGW9MjcVne6wjEwh84cCRccsTEI5cyxe7sJc CcBaPtHXur+AAe4qKIYTRSIfh+7ui7bWfaDq8Mz3I3INDYLmbx0YvJx4w3dCdBiKhOAB jtEsHzBtwBQAzCVkl7Wqiz+yczKht3sxsMQXAhqflPeofe2ccX1Nxtp9yxjzOfkmXahL xOpqOqL2zWNR2foTKsMcy6Nz/+UtyH3eQ0zhMD3ZEDOhi5W49YIU+Hg1oNT9uyyXdGq+ X9mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=QBPYE/u6rB92zok9wzUSH3tsYUrT4F0FkyjBL0qsOhg=; fh=ocEshcd/USd1aFuYlb1x53ANst9TLaXM17ohmJb27hY=; b=mjstEdbvt8nqZvqc6alg6WhjhpQ0tTpXcjxXQDBjvrB8qZP1k+EaicEUJUKL4b+5WZ YFu1nJpihHHl9IEDoFC0VSXSwt5VEu65JSl8ff2p5uVpLw1Wd0yAXbwDJWsF7ii2RmmY T4z5ZjNmsf0FsAoJ3EPqmWcfvsk3cLH8Y1HaPJkk1sDEuxch06rS3Vzz1B/wYBk/f7we TGypjhHkJGe4JyijBXUy/DcTb8WM1C4J1bq/316Z8OiZMTmIy9TKoMV0sVD5KnUBHfU8 Vd7DKuOdtHMdrnx5TZdgg2rz9+FU7DPu8x2bctHQJ7Al2VgKAaCN4abXvhlra1TBTroc 0QIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QMigIibA; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71077-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71077-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qk34-20020a1709077fa200b00a3ecd47f937si153247ejc.667.2024.02.19.01.58.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 01:58:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71077-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QMigIibA; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71077-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71077-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9ECBD1F22B2F for ; Mon, 19 Feb 2024 09:58:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6BFF2563F; Mon, 19 Feb 2024 09:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QMigIibA" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C013324A1C for ; Mon, 19 Feb 2024 09:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708336673; cv=none; b=hPc3+ra2w12JyY7J7YPlWQH181nc1kLA2Pcmys9qVBrH6EpnxKrlXfj+rwk67KOjFOuNm8sGfZmovr1m8GYKEq35brCHmt+RkIG+MfbM+4K8SChA/YLfQ+GL1PFy25DQSCE+Jddb7PHZpuPotFEu4jVDBk79nKd9VRgXVN5oHsA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708336673; c=relaxed/simple; bh=yQZprAUO9Y649VqM9TcmEKXOmPL5c7uCyFbnjiNJiIU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bCrEl6pQFV750XkgrdWFvK1fpp95+m43gcZPVG2qCO5pY0UVgecXP+6/+SjhzqpKpf0x2DdaONRzHnPbVMCnBLyAdOTk623uWyqRsvwBzUtCPDPZsmyTmkOJQmmp0NEyLqUW2mDY27eQwMCpLW7Nufpm2FtpTJxfZiOBHKyp8bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QMigIibA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708336670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QBPYE/u6rB92zok9wzUSH3tsYUrT4F0FkyjBL0qsOhg=; b=QMigIibAgVr/28pidzLQteGP+82eu6jNW2GSvDYhJUwt66iIY/8ratX2Hd7Hn2G0p31V39 0RPtgvwY8W1+WXBRAElZWjCFgBXN6rjBgtSNvW5aj0g33d70PBlUh7+epMpECQVKJXiZMU cqDnU2Nni9H8280IZoYP6NYuw3EpOrU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-B5JagkbBOC6kl_y96s9-7w-1; Mon, 19 Feb 2024 04:57:47 -0500 X-MC-Unique: B5JagkbBOC6kl_y96s9-7w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D32B881C83; Mon, 19 Feb 2024 09:57:46 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.39.192.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B3BF8CEC; Mon, 19 Feb 2024 09:57:42 +0000 (UTC) From: Valentin Schneider To: dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , mleitner@redhat.com, David Ahern , Juri Lelli , Tomas Glozar , Sebastian Andrzej Siewior , Thomas Gleixner Subject: [PATCH v3 0/1] tcp/dcpp: Un-pin tw_timer Date: Mon, 19 Feb 2024 10:57:28 +0100 Message-ID: <20240219095729.2339914-1-vschneid@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791320858274395137 X-GMAIL-MSGID: 1791320858274395137 Hi, This is v3 of the series where the tw_timer is un-pinned to get rid of interferences in isolated CPUs setups. Eric mentionned rsk_timer needs looking into, but I haven't had the time to do that. It doesn't show up in our testing, which might be due to its relatively low timeout (IIUC 3s). Revisions ========= RFCv1 -> v2 ++++++++ o Added comment in inet_twsk_deschedule_put() to highlight the race o Added bh_disable patch v2 -> v3 ++++++++ o Dropped bh_disable patch o Rebased against latest Linus' tree Valentin Schneider (1): tcp/dcpp: Un-pin tw_timer net/dccp/minisocks.c | 16 +++++++--------- net/ipv4/inet_timewait_sock.c | 20 +++++++++++++++----- net/ipv4/tcp_minisocks.c | 16 +++++++--------- 3 files changed, 29 insertions(+), 23 deletions(-)