mbox series

[v2,0/8] Staging: vc04_services: bcm2835-camera: Fix code style checks

Message ID 20240217211246.28882-1-mo.c.weber@gmail.com
Headers
Series Staging: vc04_services: bcm2835-camera: Fix code style checks |

Message

Moritz C. Weber Feb. 17, 2024, 9:12 p.m. UTC 
  Resubmit these patches to fix multiple code style checks for better readability, consistency, and to address errors indicated by Gregs patch bot

Moritz C. Weber (8):
  Staging: vc04_services: bcm2835-camera: fix brace code style check
  Staging: vc04_services: bcm2835-camera: fix brace code style check
  Staging: vc04_services: bcm2835-camera: fix brace code style check
  Staging: vc04_services: bcm2835-camera: fix brace code style check
  Staging: vc04_services: bcm2835-camera: fix brace code style check
  Staging: vc04_services: bcm2835-camera: fix blank line style check
  Staging: vc04_services: bcm2835-camera: fix brace code style check
  Staging: vc04_services: bcm2835-camera: fix brace code style check

 .../bcm2835-camera/bcm2835-camera.c           | 61 +++++++++----------
 1 file changed, 28 insertions(+), 33 deletions(-)

Comments

Dan Carpenter Feb. 19, 2024, 7:38 a.m. UTC | #1 
On Sat, Feb 17, 2024 at 10:12:38PM +0100, Moritz C. Weber wrote:
> Resubmit these patches to fix multiple code style checks for better readability, consistency, and to address errors indicated by Gregs patch bot
> 
> Moritz C. Weber (8):
>   Staging: vc04_services: bcm2835-camera: fix brace code style check
>   Staging: vc04_services: bcm2835-camera: fix brace code style check
>   Staging: vc04_services: bcm2835-camera: fix brace code style check
>   Staging: vc04_services: bcm2835-camera: fix brace code style check
>   Staging: vc04_services: bcm2835-camera: fix brace code style check
>   Staging: vc04_services: bcm2835-camera: fix blank line style check
>   Staging: vc04_services: bcm2835-camera: fix brace code style check
>   Staging: vc04_services: bcm2835-camera: fix brace code style check

These are automatically rejected because you sent 8 patches with the
same subject.  But really they should just be one patch.  In v1 Greg
complained that you were changing a bunch of random stuff.  It's not
clear what was going on there because it was random text and there was
no way it would compile.

Was it an AI generated patch or what one earth happened?

Anyway, that was the issue, not that you need to break up the patch line
by line and send each line as a separate patch.

regards,
dan carpenter
Dan Carpenter Feb. 19, 2024, 8:17 a.m. UTC | #2 
On Mon, Feb 19, 2024 at 10:38:30AM +0300, Dan Carpenter wrote:
> On Sat, Feb 17, 2024 at 10:12:38PM +0100, Moritz C. Weber wrote:
> > Resubmit these patches to fix multiple code style checks for better readability, consistency, and to address errors indicated by Gregs patch bot
> > 
> > Moritz C. Weber (8):
> >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> >   Staging: vc04_services: bcm2835-camera: fix blank line style check

This blank line patch would be still separate of course.

> >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> >   Staging: vc04_services: bcm2835-camera: fix brace code style check

regards,
dan carpenter
Moritz C. Weber Feb. 19, 2024, 9:22 a.m. UTC | #3 
Ok.. thanks for the explanation. Did not want to ask back stupidly
what the script was actually complaining about without providing a
suggestion on what I understood what it was asking for. I will submit
a version 3 patch for the braces and a separate blank line patch with
both good cover letters.

Best regards,
Moritz

On Mon, Feb 19, 2024 at 9:17 AM Dan Carpenter <dan.carpenter@linaroorg> wrote:
>
> On Mon, Feb 19, 2024 at 10:38:30AM +0300, Dan Carpenter wrote:
> > On Sat, Feb 17, 2024 at 10:12:38PM +0100, Moritz C. Weber wrote:
> > > Resubmit these patches to fix multiple code style checks for better readability, consistency, and to address errors indicated by Gregs patch bot
> > >
> > > Moritz C. Weber (8):
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> > >   Staging: vc04_services: bcm2835-camera: fix blank line style check
>
> This blank line patch would be still separate of course.
>
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
> > >   Staging: vc04_services: bcm2835-camera: fix brace code style check
>
> regards,
> dan carpenter
>