mbox series

[v1,0/2] mmc: meson-mx-sdhc: two small cleanups

Message ID 20240217100200.1494980-1-martin.blumenstingl@googlemail.com
Headers
Series mmc: meson-mx-sdhc: two small cleanups |

Message

Martin Blumenstingl Feb. 17, 2024, 10:01 a.m. UTC 
  Hello Ulf,

here are two small cleanups for the meson-mx-sdhc driver.

The first one is resolves a TODO comment from when the driver was
originally introduced where devm_clk_hw_get_clk() was not available
yet. Nowadays it is and we can and should use it.

The second one removes an incorrect .card_hw_reset callback from the
driver's mmc_host_ops. This part has never been correct as we're
resetting the host controller, not the card. It didn't seem to cause
any issues so far, which is why I don't think that it's -stable
material.



Martin Blumenstingl (2):
  mmc: meson-mx-sdhc: Use devm_clk_hw_get_clk() for clock retrieval
  mmc: meson-mx-sdhc: Remove .card_hw_reset callback

 drivers/mmc/host/meson-mx-sdhc-clkc.c | 43 ++++++++++++++-------------
 drivers/mmc/host/meson-mx-sdhc-mmc.c  | 13 ++++----
 2 files changed, 28 insertions(+), 28 deletions(-)

Comments

Ulf Hansson Feb. 28, 2024, 1:03 p.m. UTC | #1 
On Sat, 17 Feb 2024 at 11:02, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hello Ulf,
>
> here are two small cleanups for the meson-mx-sdhc driver.
>
> The first one is resolves a TODO comment from when the driver was
> originally introduced where devm_clk_hw_get_clk() was not available
> yet. Nowadays it is and we can and should use it.
>
> The second one removes an incorrect .card_hw_reset callback from the
> driver's mmc_host_ops. This part has never been correct as we're
> resetting the host controller, not the card. It didn't seem to cause
> any issues so far, which is why I don't think that it's -stable
> material.
>
>
>
> Martin Blumenstingl (2):
>   mmc: meson-mx-sdhc: Use devm_clk_hw_get_clk() for clock retrieval
>   mmc: meson-mx-sdhc: Remove .card_hw_reset callback
>
>  drivers/mmc/host/meson-mx-sdhc-clkc.c | 43 ++++++++++++++-------------
>  drivers/mmc/host/meson-mx-sdhc-mmc.c  | 13 ++++----
>  2 files changed, 28 insertions(+), 28 deletions(-)

Applied for next, thanks!

Kind regards
Uffe