mbox series

[v2,0/2] clocksource: fix Tegra234 SoC Watchdog Timer.

Message ID 20240216210258.24855-1-pohsuns@nvidia.com
Headers
Series clocksource: fix Tegra234 SoC Watchdog Timer. |

Message

Pohsun Su Feb. 16, 2024, 9:02 p.m. UTC 
  This set of patches includes a fix for watchdog for it may not bark
due to self-pinging and adds WDIOC_GETTIMELEFT support.

--
Patchset v2 fixes a compilation error, a warning and updates copyright:

drivers/clocksource/timer-tegra186.c:263:22: error:
    implicit declaration of function 'FIELD_GET'
    [-Werror=implicit-function-declaration]
drivers/clocksource/timer-tegra186.c:414:15: warning:
    variable 'irq' set but not used [-Wunused-but-set-variable]

--
Differences between v2 and v1:

[PATCH v2 1/2] clocksource/drivers/timer-tegra186: add
 WDIOC_GETTIMELEFT support

 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Copyright (c) 2019-2020 NVIDIA Corporation. All rights reserved.
+ * Copyright (c) 2019-2024 NVIDIA Corporation. All rights reserved.
  */

+#include <linux/bitfield.h>
 #include <linux/clocksource.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>

[PATCH v2 2/2] clocksource/drivers/timer-tegra186: fix watchdog
 self-pinging.

 	struct tegra186_timer *tegra;
-	unsigned int irq;
 	int err;
 
 	tegra = devm_kzalloc(dev, sizeof(*tegra), GFP_KERNEL);

 	if (err < 0)
 		return err;
 
-	irq = err;
-
 	/* create a watchdog using a preconfigured timer */
 	tegra->wdt = tegra186_wdt_create(tegra, 0);
 	if (IS_ERR(tegra->wdt)) {

Pohsun Su (2):
  clocksource/drivers/timer-tegra186: add WDIOC_GETTIMELEFT support
  clocksource/drivers/timer-tegra186: fix watchdog self-pinging.

 drivers/clocksource/timer-tegra186.c | 71 ++++++++++++++++++----------
 1 file changed, 45 insertions(+), 26 deletions(-)