mbox series

[v2,0/6] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles

Message ID 20240216-net-v2-0-89bd4b7065c2@outlook.com
Headers
Series net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles |

Message

Yang Xiwen via B4 Relay Feb. 16, 2024, 10:01 a.m. UTC 
  Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
Changes in v2:
- replace email.
- hisi-femac: s/BUS/MACIF (Andrew Lunn)
- hisi-femac: add "hisilicon,hisi-femac" compatible since the driver
  seems generic enough for various SoCs
- hisi-femac-mdio: convert binding to YAML (Krzysztof Kozlowski)
- rewrite commit logs (Krzysztof Kozlowski)
- Link to v1: https://lore.kernel.org/r/20240216-net-v1-0-e0ad972cda99@outlook.com

---
Yang Xiwen (6):
      net: hisilicon: add support for hisi_femac core on Hi3798MV200
      net: hisi_femac: remove unused compatible strings
      dt-bindings: net: remove outdated hisilicon-femac
      dt-bindings: net: add hisilicon,hisi-femac
      net: mdio: hisi-femac: make clock optional
      dt-bindings: net: hisilicon-femac-mdio: convert to YAML

 .../bindings/net/hisilicon,hisi-femac-mdio.yaml    |  48 +++++++++
 .../bindings/net/hisilicon,hisi-femac.yaml         | 117 +++++++++++++++++++++
 .../bindings/net/hisilicon-femac-mdio.txt          |  22 ----
 .../devicetree/bindings/net/hisilicon-femac.txt    |  41 --------
 drivers/net/ethernet/hisilicon/hisi_femac.c        |  94 ++++++++++++-----
 drivers/net/mdio/mdio-hisi-femac.c                 |   2 +-
 6 files changed, 235 insertions(+), 89 deletions(-)
---
base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d
change-id: 20240216-net-9a208e17c40f

Best regards,

Comments

Andrew Lunn Feb. 16, 2024, 1:37 p.m. UTC | #1 
On Fri, Feb 16, 2024 at 06:01:59PM +0800, Yang Xiwen via B4 Relay wrote:
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
> ---
> Changes in v2:
> - replace email.
> - hisi-femac: s/BUS/MACIF (Andrew Lunn)
> - hisi-femac: add "hisilicon,hisi-femac" compatible since the driver
>   seems generic enough for various SoCs
> - hisi-femac-mdio: convert binding to YAML (Krzysztof Kozlowski)
> - rewrite commit logs (Krzysztof Kozlowski)
> - Link to v1: https://lore.kernel.org/r/20240216-net-v1-0-e0ad972cda99@outlook.com

Generally, you wait for discussion to finish before posting a new
version. Also, netdev requests you wait a minimum of 24 hours between
versions.

Having discussion happening on two different versions of a patchset
at once just causes confusion.

    Andrew

---
pw-bot: cr
Yang Xiwen Feb. 16, 2024, 1:38 p.m. UTC | #2 
On 2/16/2024 9:37 PM, Andrew Lunn wrote:
> On Fri, Feb 16, 2024 at 06:01:59PM +0800, Yang Xiwen via B4 Relay wrote:
>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>> ---
>> Changes in v2:
>> - replace email.
>> - hisi-femac: s/BUS/MACIF (Andrew Lunn)
>> - hisi-femac: add "hisilicon,hisi-femac" compatible since the driver
>>    seems generic enough for various SoCs
>> - hisi-femac-mdio: convert binding to YAML (Krzysztof Kozlowski)
>> - rewrite commit logs (Krzysztof Kozlowski)
>> - Link to v1: https://lore.kernel.org/r/20240216-net-v1-0-e0ad972cda99@outlook.com
> Generally, you wait for discussion to finish before posting a new
> version. Also, netdev requests you wait a minimum of 24 hours between
> versions.
>
> Having discussion happening on two different versions of a patchset
> at once just causes confusion.
Sorry for that, it's the first time i send netdev patches.
>      Andrew
>
> ---
> pw-bot: cr
Andrew Lunn Feb. 16, 2024, 2:11 p.m. UTC | #3 
On Fri, Feb 16, 2024 at 09:38:31PM +0800, Yang Xiwen wrote:
> On 2/16/2024 9:37 PM, Andrew Lunn wrote:
> > On Fri, Feb 16, 2024 at 06:01:59PM +0800, Yang Xiwen via B4 Relay wrote:
> > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
> > > ---
> > > Changes in v2:
> > > - replace email.
> > > - hisi-femac: s/BUS/MACIF (Andrew Lunn)
> > > - hisi-femac: add "hisilicon,hisi-femac" compatible since the driver
> > >    seems generic enough for various SoCs
> > > - hisi-femac-mdio: convert binding to YAML (Krzysztof Kozlowski)
> > > - rewrite commit logs (Krzysztof Kozlowski)
> > > - Link to v1: https://lore.kernel.org/r/20240216-net-v1-0-e0ad972cda99@outlook.com
> > Generally, you wait for discussion to finish before posting a new
> > version. Also, netdev requests you wait a minimum of 24 hours between
> > versions.
> > 
> > Having discussion happening on two different versions of a patchset
> > at once just causes confusion.
> Sorry for that, it's the first time i send netdev patches.

Reading this might help you:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

	Andrew