mbox series

[0/4] Fix vendor strings on Rockchip boards

Message ID 20240214040731.3069111-1-tim@feathertop.org
Headers
Series Fix vendor strings on Rockchip boards |

Message

Tim Lunn Feb. 14, 2024, 4:07 a.m. UTC 
  A couple of rockchip boards incorrectly list their vendor as Rockchip
when they are in fact not manufactured by Rockchip.

Fix the vendor strings to correctly list the manufacturer


Tim Lunn (4):
  dt-bindings: arm: rockchip: Correct vendor for Orange Pi RK3399 board
  dt-bindings: arm: rockchip: Correct vendor for Banana Pi R2 Pro
  arm64: dts: rockchip: adjust vendor on Banana Pi R2 Pro board
  arm64: dts: rockchip: adjust vendor on orangepi rk3399 board

 Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++----
 arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts    | 2 +-
 arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

Comments

Dragan Simic Feb. 14, 2024, 4:14 a.m. UTC | #1 
Hello Tim,

On 2024-02-14 05:07, Tim Lunn wrote:
> A couple of rockchip boards incorrectly list their vendor as Rockchip
> when they are in fact not manufactured by Rockchip.
> 
> Fix the vendor strings to correctly list the manufacturer

Just checking, have you verified that the old, incorrect "compatible"
strings from the board dts files aren't used anywhere in the kernel 
code,
such as in some drivers?

Otherwise, for the entire series:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> Tim Lunn (4):
>   dt-bindings: arm: rockchip: Correct vendor for Orange Pi RK3399 board
>   dt-bindings: arm: rockchip: Correct vendor for Banana Pi R2 Pro
>   arm64: dts: rockchip: adjust vendor on Banana Pi R2 Pro board
>   arm64: dts: rockchip: adjust vendor on orangepi rk3399 board
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++----
>  arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts    | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts  | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)
Tim Lunn Feb. 14, 2024, 4:27 a.m. UTC | #2 
Hi Dragan,

On 2/14/24 15:14, Dragan Simic wrote:
> Hello Tim,
>
> On 2024-02-14 05:07, Tim Lunn wrote:
>> A couple of rockchip boards incorrectly list their vendor as Rockchip
>> when they are in fact not manufactured by Rockchip.
>>
>> Fix the vendor strings to correctly list the manufacturer
>
> Just checking, have you verified that the old, incorrect "compatible"
> strings from the board dts files aren't used anywhere in the kernel code,
> such as in some drivers?
>
Yes I checked that, there are no remaining references to the 
old/incorrect compatible strings in kernel code

Regards
    Tim
> Otherwise, for the entire series:
>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
>
>> Tim Lunn (4):
>>   dt-bindings: arm: rockchip: Correct vendor for Orange Pi RK3399 board
>>   dt-bindings: arm: rockchip: Correct vendor for Banana Pi R2 Pro
>>   arm64: dts: rockchip: adjust vendor on Banana Pi R2 Pro board
>>   arm64: dts: rockchip: adjust vendor on orangepi rk3399 board
>>
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++----
>>  arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts    | 2 +-
>>  arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts  | 2 +-
>>  3 files changed, 6 insertions(+), 6 deletions(-)
Conor Dooley Feb. 14, 2024, 6:12 p.m. UTC | #3 
On Wed, Feb 14, 2024 at 03:27:08PM +1100, Tim Lunn wrote:
> Hi Dragan,
> 
> On 2/14/24 15:14, Dragan Simic wrote:
> > Hello Tim,
> > 
> > On 2024-02-14 05:07, Tim Lunn wrote:
> > > A couple of rockchip boards incorrectly list their vendor as Rockchip
> > > when they are in fact not manufactured by Rockchip.
> > > 
> > > Fix the vendor strings to correctly list the manufacturer
> > 
> > Just checking, have you verified that the old, incorrect "compatible"
> > strings from the board dts files aren't used anywhere in the kernel code,
> > such as in some drivers?
> > 
> Yes I checked that, there are no remaining references to the old/incorrect
> compatible strings in kernel code

What about other code? Like a BSD or a bootloader? If nothing is using
them
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Fixes tags I think wouldn't go amiss, but I'm not expecting a resend
with them.

Cheers,
Conor.
Dragan Simic Feb. 14, 2024, 6:30 p.m. UTC | #4 
Hello Conor,

On 2024-02-14 19:12, Conor Dooley wrote:
> On Wed, Feb 14, 2024 at 03:27:08PM +1100, Tim Lunn wrote:
>> On 2/14/24 15:14, Dragan Simic wrote:
>> > On 2024-02-14 05:07, Tim Lunn wrote:
>> > > A couple of rockchip boards incorrectly list their vendor as Rockchip
>> > > when they are in fact not manufactured by Rockchip.
>> > >
>> > > Fix the vendor strings to correctly list the manufacturer
>> >
>> > Just checking, have you verified that the old, incorrect "compatible"
>> > strings from the board dts files aren't used anywhere in the kernel code,
>> > such as in some drivers?
>> >
>> Yes I checked that, there are no remaining references to the 
>> old/incorrect
>> compatible strings in kernel code
> 
> What about other code? Like a BSD or a bootloader? If nothing is using
> them
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

I just quickly checked U-Boot and it's fine.

> Fixes tags I think wouldn't go amiss, but I'm not expecting a resend
> with them.
Tim Lunn Feb. 15, 2024, 12:28 a.m. UTC | #5 
Hi Conor,

On 2/15/24 05:12, Conor Dooley wrote:
> On Wed, Feb 14, 2024 at 03:27:08PM +1100, Tim Lunn wrote:
>> Hi Dragan,
>>
>> On 2/14/24 15:14, Dragan Simic wrote:
>>> Hello Tim,
>>>
>>> On 2024-02-14 05:07, Tim Lunn wrote:
>>>> A couple of rockchip boards incorrectly list their vendor as Rockchip
>>>> when they are in fact not manufactured by Rockchip.
>>>>
>>>> Fix the vendor strings to correctly list the manufacturer
>>> Just checking, have you verified that the old, incorrect "compatible"
>>> strings from the board dts files aren't used anywhere in the kernel code,
>>> such as in some drivers?
>>>
>> Yes I checked that, there are no remaining references to the old/incorrect
>> compatible strings in kernel code
> What about other code? Like a BSD or a bootloader? If nothing is using
> them
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Fixes tags I think wouldn't go amiss, but I'm not expecting a resend
> with them.
I've added the fixes tags to the email thread.

Regards
   Tim
>
> Cheers,
> Conor.
Heiko Stübner Feb. 27, 2024, 11:13 p.m. UTC | #6 
On Wed, 14 Feb 2024 15:07:27 +1100, Tim Lunn wrote:
> A couple of rockchip boards incorrectly list their vendor as Rockchip
> when they are in fact not manufactured by Rockchip.
> 
> Fix the vendor strings to correctly list the manufacturer
> 
> 
> Tim Lunn (4):
>   dt-bindings: arm: rockchip: Correct vendor for Orange Pi RK3399 board
>   dt-bindings: arm: rockchip: Correct vendor for Banana Pi R2 Pro
>   arm64: dts: rockchip: adjust vendor on Banana Pi R2 Pro board
>   arm64: dts: rockchip: adjust vendor on orangepi rk3399 board
> 
> [...]

Applied, thanks!

[1/4] dt-bindings: arm: rockchip: Correct vendor for Orange Pi RK3399 board
      commit: db51e128df1010653aab71c07e06280e37fecaeb
[2/4] dt-bindings: arm: rockchip: Correct vendor for Banana Pi R2 Pro
      commit: a03fd4b3bebc9775c921a965c4c22b1a0d3a2503
[3/4] arm64: dts: rockchip: adjust vendor on Banana Pi R2 Pro board
      commit: 437644753208092f642b7669c69da606aa07dfb4
[4/4] arm64: dts: rockchip: adjust vendor on orangepi rk3399 board
      commit: 7ec958ed6a32daad36918d200b594f33cb4e0dd7

Best regards,