mbox series

[v3,0/5] usb: dwc3-am62: module removal and errata fixes

Message ID 20240214-for-v6-9-am62-usb-errata-3-0-v3-0-147ec5eae18c@kernel.org
Headers
Series usb: dwc3-am62: module removal and errata fixes |

Message

Roger Quadros Feb. 14, 2024, 9:46 a.m. UTC 
  Hi,

This series fixes errors during module removal. It also
implements PHY core voltage selection as per TI recommendation
and workaround for Errata i2409 [1].

The workaround needs PHY2 region to be present in device node.
The device tree patch will be sent later after the DT binding doc
is merged.

[1] - https://www.ti.com/lit/er/sprz487d/sprz487d.pdf

Changelog in each file

v2: https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
v1: https://lore.kernel.org/all/20240201121220.5523-1-rogerq@kernel.org/

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Roger Quadros (5):
      usb: dwc3-am62: call of_platform_depopulate in .remove()
      usb: dwc3-am62: fix error on module removal
      usb: dwc3-am62: Fix PHY core voltage selection
      dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space
      usb: dwc3-am62: add workaround for Errata i2409

 .../devicetree/bindings/usb/ti,am62-usb.yaml       |  8 +++-
 drivers/usb/dwc3/dwc3-am62.c                       | 45 ++++++++++++++++------
 2 files changed, 39 insertions(+), 14 deletions(-)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240206-for-v6-9-am62-usb-errata-3-0-233024ea8e9d

Best regards,

Comments

Roger Quadros Feb. 23, 2024, 1:17 p.m. UTC | #1 
Hi Thinh,

On 14/02/2024 11:46, Roger Quadros wrote:
> Hi,
> 
> This series fixes errors during module removal. It also
> implements PHY core voltage selection as per TI recommendation
> and workaround for Errata i2409 [1].
> 
> The workaround needs PHY2 region to be present in device node.
> The device tree patch will be sent later after the DT binding doc
> is merged.
> 
> [1] - https://www.ti.com/lit/er/sprz487d/sprz487d.pdf
> 
> Changelog in each file
> 
> v2: https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
> v1: https://lore.kernel.org/all/20240201121220.5523-1-rogerq@kernel.org/
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> Roger Quadros (5):
>       usb: dwc3-am62: call of_platform_depopulate in .remove()
>       usb: dwc3-am62: fix error on module removal
>       usb: dwc3-am62: Fix PHY core voltage selection
>       dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space
>       usb: dwc3-am62: add workaround for Errata i2409

Any feedback on this series? Thanks!

> 
>  .../devicetree/bindings/usb/ti,am62-usb.yaml       |  8 +++-
>  drivers/usb/dwc3/dwc3-am62.c                       | 45 ++++++++++++++++------
>  2 files changed, 39 insertions(+), 14 deletions(-)
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240206-for-v6-9-am62-usb-errata-3-0-233024ea8e9d
> 
> Best regards,
Thinh Nguyen Feb. 23, 2024, 10:25 p.m. UTC | #2 
On Fri, Feb 23, 2024, Roger Quadros wrote:
> Hi Thinh,
> 
> On 14/02/2024 11:46, Roger Quadros wrote:
> > Hi,
> > 
> > This series fixes errors during module removal. It also
> > implements PHY core voltage selection as per TI recommendation
> > and workaround for Errata i2409 [1].
> > 
> > The workaround needs PHY2 region to be present in device node.
> > The device tree patch will be sent later after the DT binding doc
> > is merged.
> > 
> > [1] - https://urldefense.com/v3/__https://www.ti.com/lit/er/sprz487d/sprz487d.pdf__;!!A4F2R9G_pg!ZBXH4OebB2sFGs4Y04X6e3Uyr3AKcppsXCLY9XG2ET3RFRgS_i-xq7Jwps-uF-74gPOolfZo9gtZ4TjDCTp5$ 
> > 
> > Changelog in each file
> > 
> > v2: https://urldefense.com/v3/__https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/__;!!A4F2R9G_pg!ZBXH4OebB2sFGs4Y04X6e3Uyr3AKcppsXCLY9XG2ET3RFRgS_i-xq7Jwps-uF-74gPOolfZo9gtZ4d-cSehP$ 
> > v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20240201121220.5523-1-rogerq@kernel.org/__;!!A4F2R9G_pg!ZBXH4OebB2sFGs4Y04X6e3Uyr3AKcppsXCLY9XG2ET3RFRgS_i-xq7Jwps-uF-74gPOolfZo9gtZ4YnYBTMg$ 
> > 
> > Signed-off-by: Roger Quadros <rogerq@kernel.org>
> > ---
> > Roger Quadros (5):
> >       usb: dwc3-am62: call of_platform_depopulate in .remove()
> >       usb: dwc3-am62: fix error on module removal
> >       usb: dwc3-am62: Fix PHY core voltage selection
> >       dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space
> >       usb: dwc3-am62: add workaround for Errata i2409
> 
> Any feedback on this series? Thanks!
> 

They look good to me.

BR,
Thinh