mbox series

[v1,0/2] hugetlb: two small improvements of hugetlb init parallelization

Message ID 20240213111347.3189206-1-gang.li@linux.dev
Headers
Series hugetlb: two small improvements of hugetlb init parallelization |

Message

Gang Li Feb. 13, 2024, 11:13 a.m. UTC 
  This series includes two improvements: fixing the PADATA Kconfig warning
and a potential bug in gather_bootmem_prealloc_parallel. Please refer to
the specific commit message for details.

For Andrew:
If you want me to include these two fixes into the previous series[1], I
would be happy to send v6. Otherwise, you can directly apply these two
patches.

[1]. https://lore.kernel.org/lkml/20240126152411.1238072-1-gang.li@linux.dev/

Gang Li (2):
  padata: downgrade padata_do_multithreaded to serial execution for
    non-SMP
  hugetlb: process multiple lists in gather_bootmem_prealloc_parallel

 fs/Kconfig             |  2 +-
 include/linux/padata.h | 13 +++++++++----
 mm/hugetlb.c           | 15 +++++++++++----
 3 files changed, 21 insertions(+), 9 deletions(-)

Comments

Paul E. McKenney Feb. 13, 2024, 2:16 p.m. UTC | #1 
On Tue, Feb 13, 2024 at 07:13:45PM +0800, Gang Li wrote:
> This series includes two improvements: fixing the PADATA Kconfig warning
> and a potential bug in gather_bootmem_prealloc_parallel. Please refer to
> the specific commit message for details.
> 
> For Andrew:
> If you want me to include these two fixes into the previous series[1], I
> would be happy to send v6. Otherwise, you can directly apply these two
> patches.
> 
> [1]. https://lore.kernel.org/lkml/20240126152411.1238072-1-gang.li@linux.dev/

Thank you!

Tested-by: Paul E. McKenney <paulmck@kernel.org>

> Gang Li (2):
>   padata: downgrade padata_do_multithreaded to serial execution for
>     non-SMP
>   hugetlb: process multiple lists in gather_bootmem_prealloc_parallel
> 
>  fs/Kconfig             |  2 +-
>  include/linux/padata.h | 13 +++++++++----
>  mm/hugetlb.c           | 15 +++++++++++----
>  3 files changed, 21 insertions(+), 9 deletions(-)
> 
> -- 
> 2.20.1
>
Gang Li Feb. 19, 2024, 3:03 a.m. UTC | #2 
On 2024/2/13 19:13, Gang Li wrote:
> This series includes two improvements: fixing the PADATA Kconfig warning
> and a potential bug in gather_bootmem_prealloc_parallel. Please refer to
> the specific commit message for details.
> 
> For Andrew:
> If you want me to include these two fixes into the previous series[1], I
> would be happy to send v6. Otherwise, you can directly apply these two
> patches.
> 
> [1]. https://lore.kernel.org/lkml/20240126152411.1238072-1-gang.li@linux.dev/

Hi Andrew,
A gentle ping here :).

Do you want to apply these two patches, or would you like me to
include them into the original patch and send out v6?

> 
> Gang Li (2):
>    padata: downgrade padata_do_multithreaded to serial execution for
>      non-SMP
>    hugetlb: process multiple lists in gather_bootmem_prealloc_parallel
> 
>   fs/Kconfig             |  2 +-
>   include/linux/padata.h | 13 +++++++++----
>   mm/hugetlb.c           | 15 +++++++++++----
>   3 files changed, 21 insertions(+), 9 deletions(-)
>
Andrew Morton Feb. 20, 2024, 1:52 a.m. UTC | #3 
On Mon, 19 Feb 2024 11:03:29 +0800 Gang Li <gang.li@linux.dev> wrote:

> On 2024/2/13 19:13, Gang Li wrote:
> > This series includes two improvements: fixing the PADATA Kconfig warning
> > and a potential bug in gather_bootmem_prealloc_parallel. Please refer to
> > the specific commit message for details.
> > 
> > For Andrew:
> > If you want me to include these two fixes into the previous series[1], I
> > would be happy to send v6. Otherwise, you can directly apply these two
> > patches.
> > 
> > [1]. https://lore.kernel.org/lkml/20240126152411.1238072-1-gang.li@linux.dev/
> 
> Hi Andrew,
> A gentle ping here :).
> 
> Do you want to apply these two patches, or would you like me to
> include them into the original patch and send out v6?

The patchset is now rather a mess and I'm not confidently identifying
which issues remain open and which are addressed.

So yes, a full redo and resend would be preferred, please.

Links which I collected are:

https://lkml.kernel.org/r/202402020454.6EPkP1hi-lkp@intel.com
https://lkml.kernel.org/r/20240204072525.1986626-1-gang.li@linux.dev
https://lkml.kernel.org/r/6A148F29-68B2-4365-872C-E6AB599C55F6@linux.dev
https://lkml.kernel.org/r/j7xb7m5cy374ngbdm23rvryq6vy6jxtewtu3abjeidhho4bly7@t3aawaeybxlk
Gang Li Feb. 20, 2024, 6:17 a.m. UTC | #4 
On 2024/2/20 09:52, Andrew Morton wrote:
> On Mon, 19 Feb 2024 11:03:29 +0800 Gang Li <gang.li@linux.dev> wrote:
> 
>> On 2024/2/13 19:13, Gang Li wrote:
>>> This series includes two improvements: fixing the PADATA Kconfig warning
>>> and a potential bug in gather_bootmem_prealloc_parallel. Please refer to
>>> the specific commit message for details.
>>>
>>> For Andrew:
>>> If you want me to include these two fixes into the previous series[1], I
>>> would be happy to send v6. Otherwise, you can directly apply these two
>>> patches.
>>>
>>> [1]. https://lore.kernel.org/lkml/20240126152411.1238072-1-gang.li@linux.dev/
>>
>> Hi Andrew,
>> A gentle ping here :).
>>
>> Do you want to apply these two patches, or would you like me to
>> include them into the original patch and send out v6?
> 
> The patchset is now rather a mess and I'm not confidently identifying
> which issues remain open and which are addressed.
> 
> So yes, a full redo and resend would be preferred, please.
> 
> Links which I collected are:
> 
> https://lkml.kernel.org/r/202402020454.6EPkP1hi-lkp@intel.com
> https://lkml.kernel.org/r/20240204072525.1986626-1-gang.li@linux.dev
> https://lkml.kernel.org/r/6A148F29-68B2-4365-872C-E6AB599C55F6@linux.dev
> https://lkml.kernel.org/r/j7xb7m5cy374ngbdm23rvryq6vy6jxtewtu3abjeidhho4bly7@t3aawaeybxlk

In summary, there is two issues based on v5[1] and all are fixed by my
patch.

Scattered discussions led to some confusion, I'll make it clear in the
next version.

Thanks.

[1]. 
https://lore.kernel.org/lkml/20240126152411.1238072-1-gang.li@linux.dev/