From patchwork Mon Feb 12 14:03:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 20250 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp2468618dyd; Mon, 12 Feb 2024 06:40:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVw26MLtcM483LzhktdMn/fxGtQ9Xa5vR2cmQh8fktuAEcgR7w6+dbjq3aPpHyCp+mRRW3WmffJ2uOpdMCusdwjy59c0A== X-Google-Smtp-Source: AGHT+IEapMX4264HtEyjDQ84JWC1i5Olqqjv1wd6VldpdQ69lMZvWmZ2o9rjN6sMnP0Nrvd1EVLA X-Received: by 2002:a05:6a21:1518:b0:19c:6297:13b1 with SMTP id nq24-20020a056a21151800b0019c629713b1mr5485260pzb.58.1707748807454; Mon, 12 Feb 2024 06:40:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707748807; cv=pass; d=google.com; s=arc-20160816; b=uqAYj5qdULmnkdtYU9ZjPgFmevrAc1kHBIHR5pGu5yXWmpSd3pgO63luQ0ndn04+pq hnvq32NoFgz/fXEdS1W+ECSgupluK8NicaxHam2osWekRTgMWytkWr/FbV/Us5+A6BnV 8ZB74G0JePn8Jk6f6zC6v700tfSY5ogQsp0IZvFkE7seYg5ZLJa2uEcrfwyfdDlWyr3K RrOv7NaxXW/ogJ3pE5lr1+H++OhU91I5pUwAq6tm9DKdM/gu6V/bKuUGau0LbQNPIUjl MHNi2ZrorPiP82gpVBze8vXYfNmPzDqPZh4427ImkECwrsikqGFhMvvp+aZhCman1CmD OYCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3fwygQHFsBzQHW5VKr94J8/MYzLiHXjL2S+HWa6z3Po=; fh=Fgc7pHFG8l2N8+npUKEiDvmWWRNVav+LUQpar15svXU=; b=hFJpuknfoGX2kCWhmzL2Zy8GYKEq3nk06FjcxUIB5ImuKAJbjiqRTwCVoIrnLlIjx6 eVZX9FapJdbchGxirsDB6jTGnR7Ig76w0uMEu47fVDnA/HXQUe2Q3Gkj0RwuacosNPNx PNkXGankNTCtOt9GqEBhxv+QqiA+TwU98doK5sz/+6u3b3p8UNDyuEqq+EHqntKv9dej gSIK9XFrJuDf+fp84l2xLiW80oVslb+yBzALnqqNOqyA4Rac6wUW131G2ZVWdJGF7gzv ROIERB95r02t593K/iW6Jxm38kD6iXGHpzZg5ZBml6e8V2OUi06l2elQALVBf6bvKcST 8BMg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="WSa0/Y2x"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-61786-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61786-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCVhAtE+cvE8JgIA+gzA+WEh6Cd+1Mel/pb3owe3iG6zLTTVczaSwUDnw2CLay80MOqJB6tHU5b1cr2Pe5MFWUgL+LU6Uw== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id r18-20020a62e412000000b006e0733b3439si5055648pfh.296.2024.02.12.06.40.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 06:40:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61786-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="WSa0/Y2x"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-61786-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61786-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 23BB7B2D7A7 for ; Mon, 12 Feb 2024 14:08:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 42DC13D0DA; Mon, 12 Feb 2024 14:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WSa0/Y2x" Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807873D0B5 for ; Mon, 12 Feb 2024 14:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707746622; cv=none; b=ZLx+U7j0El+zzq7h6Cg7yGg8CEZH+W/ZagK3nCfYLwY8IhwzTfgA/gSWGehy7p+yJaCt9d0G7aJWPWJo4Q/M0LEJwZkuZB3xkbAQ8O1a38bZAXcKFMl5gt1cOL2WMuWD/SPbWT4i/yAWtmGy5gs+s2QLWjnufgj61LizaugB1jA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707746622; c=relaxed/simple; bh=6tebE1i+8uRkrGpkVZOD3OOkqyqqHXPKa5dm8fJa6M0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lXajdFyEY8BHMlKtrxYRBOdLQ3C5DaaZcefA53QAJHM2QSQQXyEi8dD242WssIzecAxFimcdAhI5lw46N1c50a8Ndih2y32XaxVycKDFCkxocTyKGsKyV0UqRMWvsebBYUikQqwt16WCoB82NCiW8zH52R+XM9hv7P7TzlylxCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WSa0/Y2x; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4114e0a2978so2953075e9.3 for ; Mon, 12 Feb 2024 06:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707746618; x=1708351418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3fwygQHFsBzQHW5VKr94J8/MYzLiHXjL2S+HWa6z3Po=; b=WSa0/Y2xruKgwRhYkos26f5TnMdopytcyGZ/2b+X46r6Cj4iGnC6XYt9Ef9bdzuc6Q j7UDZQKQXJxWsa4115fJrL/GBXqdJzEg6JRGq1TyipXHvbFmjnkKLCJ5m5yVJoyEb1Tp cz1HdlK0VQPYoGgEdS5EJtGQfuKwMOUIvG5Vnc09wsB5+BMb8p0WsS4hwcDFQ0MYuaoE FQr/f/LGOpqTiZRlQNoKyI3qs85Dqy0N6dCD1tkgvkVbkKtiAHJp87l5bJOkl3L/aixP DBo/4TUBJc0/k2Bn/dslunQ1SxkKvec0swzuQlIuRtqD9yyAa/RSBkuInAh+ljrvJhPM HW6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707746618; x=1708351418; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3fwygQHFsBzQHW5VKr94J8/MYzLiHXjL2S+HWa6z3Po=; b=htJmgRZcgwJwrKU14ev5CeI9EFJK3IF1IpC0+oJ8qxNbV1pX0zjvdt380g5PIdwWdo D1hxnfasuKVVgNzTvDef7oXRGfvE4suNMoQz33MWZk1Cf3AU0n+H4U7nrLEu+T6Cs1fH dasrECsV2ktNde3tj5NojgJr2hkqlsSWBnYbvBvoGuU/tMR8pTSMeLdhw+uaDWwkVFL7 l9JnBJa3lIaRowXSQ8Ih37WySqE+AWuUrAmcaxV/+DzErBrZml9H7DE62o26cSbCy+Fk xx5N6QYCZMm4FN3B/NdkoTwdbtMsiEWhSBMwnc2CqbGd7r1i/vgR0rNnNkhP2ostVmkG jsoA== X-Forwarded-Encrypted: i=1; AJvYcCWkFInIiQ3GO+rkhAeGOVPcyfW59sg0DuDn8B83w/GNRxQGi4ub95HJhXuAT+z1DrmWOqXJmwzqcuZsPmXp8AhlXxbtA3SrmjRvXE6A X-Gm-Message-State: AOJu0Yx4R1iZIPWFWaJAhn+PkKPwrAf+ha/6kdxBnlawwC06G7IpfMpp n/fAaBt8rRE+FyDxeh3WRtFG7HtxQeGtC5wbfwtRidNQJPUT9Ke0Ygav3IILwYc= X-Received: by 2002:a05:600c:470c:b0:411:6f3f:4950 with SMTP id v12-20020a05600c470c00b004116f3f4950mr661113wmo.32.1707746617687; Mon, 12 Feb 2024 06:03:37 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVdE45X2RafVhK2EB+ykUZM9RvsPvrceDujHA//0jL+xxiP+4n1I1kYEwYqurMODq5CHI+cESHCgB6fBwCHf9Xe22zXIx2Qp7f/YjU3mw8LTOD+1vj7bezY4XjEO/3zcENm4GqTW3M5CvhgMXi2jzkXChD/FxCupB7nqxUz2UJrXQ894bvh8F2cTIt65lcSMSVyaCrkdNQHSBj0maQ8PTDCMQhiTq9z7/kEIBba3MjC3wq2yDG2cGt+iUjz3oYUZ41m5M2zPFExn19FZe1ndbXtsVXM0miaZC/FNF5xb74Pvce3Jx5iD2XfkIocvW09knSlasadcXCVOllRvE0g+sp95i61XerBAXzF5ujl16KXolDWSLmQIkPAuoYnUcur2Hd99mN6/F4KMfLmZUBYSFidrpIF/TuzVyhDsCgSUqS0xc/eTw+0Feg1mV0kWGx5zQf0KW0KcDfdwYogWTmSPBIXsB9t/lCNYk28KW54EHhxKJrkZDT77HYOskEsNcJPwo9mLRbeBizP1ItF0+EynUm+c7Vau4Z0qk7sXwd/MeJ8T69ADyktROfI0c6uoFQWETNzeeYhs9bF7BLRi1ZfttHOMOngSAvkfRCz/eVue91GbMmKMmk= Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id v9-20020a5d4b09000000b0033b843786e1sm2135356wrq.51.2024.02.12.06.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 06:03:35 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, arnd@arndb.de, Tudor Ambarus Subject: [PATCH v2 00/12] spi: s3c64xx: remove OF alias ID dependency Date: Mon, 12 Feb 2024 14:03:19 +0000 Message-ID: <20240212140331.915498-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790704413228458721 X-GMAIL-MSGID: 1790704413228458721 The driver was wrong as it assumed that the alias values in devicetree have a particular meaning in identifying instances. This immediately breaks when there is a dtb file that does not use the same alias values, e.g. because it only needs some of the SPI ports. Tested gs101 SPI with spi-loopback-test, all went fine. I updated exynos850 as it uses the same USI.SPI_VERSION as gs101. Maybe Sam can test exynos850, if not, we can drop that patch (12/12). v2: - update bindings to consider the asymmetric case where the RX FIFO depth can differ from the TX FIFO depth - update commit message in patch 11/12 to describe the GS101 change (I was wrongly mentioning exynos 850). Tudor Ambarus (12): spi: dt-bindings: introduce FIFO depth properties spi: s3c64xx: define a magic value spi: s3c64xx: allow full FIFO masks spi: s3c64xx: determine the fifo depth only once spi: s3c64xx: retrieve the FIFO depth from the device tree spi: s3c64xx: allow FIFO depth to be determined from the compatible spi: s3c64xx: let the SPI core determine the bus number spi: s3c64xx: introduce s3c64xx_spi_set_port_id() spi: s3c64xx: get rid of the OF alias ID dependency spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id spi: s3c64xx: switch gs101 to new port config data spi: s3c64xx: switch exynos850 to new port config data .../bindings/spi/spi-controller.yaml | 27 ++++ drivers/spi/spi-s3c64xx.c | 142 ++++++++++++++---- 2 files changed, 138 insertions(+), 31 deletions(-)