From patchwork Mon Feb 12 07:56:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Herve Codina X-Patchwork-Id: 20234 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp2295785dyd; Mon, 12 Feb 2024 00:16:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX/cjBzm1kYpU0dJzQ4wLRmjPoGYO19oPe26tdwN9OT2ouHlDHoS4wRw2VKCeoE6yVbPpc0VhpV4DJbk+JcJHO+/AjY3g== X-Google-Smtp-Source: AGHT+IEHCzqCiF2/K4ZKYCFKAVxEFAJMro72S1S2nHxHBtWKaCMkWE57JkHz18ZYC+anETFysoLP X-Received: by 2002:a05:6a20:c707:b0:19e:b89f:99ff with SMTP id hi7-20020a056a20c70700b0019eb89f99ffmr5617923pzb.3.1707725800983; Mon, 12 Feb 2024 00:16:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707725800; cv=pass; d=google.com; s=arc-20160816; b=wB6jw7HNE6qtsk4ubEy94dfOBtqsGXxiPv8plrWjnIueZimDfHlHseddhBmhG/Vxkn eqYmRF81jjn0J3kV3+NX1W+V6ofJmWo4QzP4GJ5tLcuKYN1lorzpcPuPmtVLoac0jgKZ fSxAN20uc8yNX1RXP9X1Gr7Ahwq3Kv6pS3yqYz52fNjZwtmFi8GJKqc9D1F5sguwJ/9G CgVEzLkuZsqWww42XP9FmAfJ4hcZwbLC+QiWsS4V8TwK1GZzJbBeJkQdIVlwVTo8vwHl 4MFdqwAWN9qiLVL6I0fjMkf1qMCRJt/nhEmx932XQk5VIecsqivIGb/MaIodTyMkAin7 CfLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=YSfZQ+fRkCMgKK8xfkXLcaIY0CpWpwvD1FeC5lzh3h8=; fh=uPk1AjkfQ68QpsCw9xlLMkjlcdM4HU1ma6pt94VMx/M=; b=nsQvnC5hmgzZa2gRl46KL0r9FtKGjvMBOLDK/qSxQVXodVX+poWm7lR8GwCjdlWcJT /5hVV1wvTGWlPgZzwG6qWlZicNWHsuTi4S9PiImCHUyh68Bs3DFyxpFSOTED39IQYnqe niiWA0vRPqksd8OBTCzBnfG5d/1wR5oD8h/CJfvhJ/HFMUmPj6bkByKqZhJJ2mcNNJ0M JXJ8K3amPSFR7qsTjmQ42QualABy+N5Tr30i05+oVgWgJnMOznYTlPICh0rINyKEYG3j 5l6Ijl5UYgN44LEtnZaNYTqiuvN4vBC9LIKYAiFymdH8Rhm0UQOHwh3D1fhGrUqxZbbj TKOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=BwS+m6qg; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-61162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61162-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com X-Forwarded-Encrypted: i=2; AJvYcCVRoiqn30KU5bTGrTAwZZvell7eDm/sShmqAP0Bl8gHr3wbWfIX50fLsedaUJ4GHPUoTs59jSw6p19KBeM3P+jxx13p5g== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id n10-20020a17090a9f0a00b00296a394fab4si3011154pjp.60.2024.02.12.00.16.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 00:16:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=BwS+m6qg; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-61162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61162-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C1862B221CF for ; Mon, 12 Feb 2024 07:58:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E014012E4A; Mon, 12 Feb 2024 07:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BwS+m6qg" Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A020B79C0; Mon, 12 Feb 2024 07:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707724632; cv=none; b=i5K9QHI25RAB01ha421hMMVG2X+++Jd8g+FRvD/kJgEpn6TdHxFTBo2hwCZX7hTygZztGnvbzwRiYkoflBoBaxvZvXZl61Gu53NskziVbJ2efnupb8+9W0YqE7o0H3D+IlqAz2cSfteccXeiD4s1cbYcl6FPqtVOznjhlj0xbsw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707724632; c=relaxed/simple; bh=akj2o61fKpwaYPHm8Yxzo/FzHPHlKlIu1XNMHBAC0LY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=a7G9q/jGeWIkQr4s68Uy3qBb8ZvFMJoOvli5yfD/KCtYPP5JTWzgjhLDovwVSfQMlRPNQA5BQGcZcB3bvIY9ak12e/azXOnDdzTBZhJOsl7VXrc7v13vWWMO7OegEH72hJ+Ez8xXtDW+4KBZh8bTNJCPLne/EdLr1mPvG+H4onI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BwS+m6qg; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPA id 7E36340006; Mon, 12 Feb 2024 07:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707724622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YSfZQ+fRkCMgKK8xfkXLcaIY0CpWpwvD1FeC5lzh3h8=; b=BwS+m6qgkhMcZiklPjTbn01zfstqn6kmW83bm3eK6557hU+1f0mlrBNyjuYS4SRFnoel5h DXVKJ+eBew0Fl7ZRwlt+3iGFbV0bfXUe/pIrQQtWzfYejsLtAqgNUv2lZb9tesZeHYghH3 0xedqZ60TFSiyH7L++d0wtoQFJ+fLQ9E6ftqUhLm5l2D5cuxqnEC1FtPnFIvcYxreDCrir opmRtVYl9ACNfrrkPMHo8joDpDN6sZEa80ZE0qEN66a1YO/8s9zsaebNOlzk3HNf75VvHg pj8RuQxB2/BbzrIqerDICZr1JyH6JiER8TsOBtzuh/nfWjKrVJ22lZjlhxsDPA== From: Herve Codina To: Vadim Fedorenko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Herve Codina , Yury Norov , Andy Shevchenko , Rasmus Villemoes Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn , Mark Brown , Christophe Leroy , Thomas Petazzoni Subject: [PATCH v3 RESEND 0/6] Add support for QMC HDLC Date: Mon, 12 Feb 2024 08:56:28 +0100 Message-ID: <20240212075646.19114-1-herve.codina@bootlin.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790679289950766000 X-GMAIL-MSGID: 1790680289597549689 Hi, Note: Resent this v3 series with missing maintainers added in CC. This series introduces the QMC HDLC support. Patches were previously sent as part of a full feature series and were previously reviewed in that context: "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1] In order to ease the merge, the full feature series has been split and needed parts were merged in v6.8-rc1: - "Prepare the PowerQUICC QMC and TSA for the HDLC QMC driver" [2] - "Add support for framer infrastructure and PEF2256 framer" [3] This series contains patches related to the QMC HDLC part (QMC HDLC driver): - Introduce the QMC HDLC driver (patches 1 and 2) - Add timeslots change support in QMC HDLC (patch 3) - Add framer support as a framer consumer in QMC HDLC (patch 4) Compare to the original full feature series, a modification was done on patch 3 in order to use a coherent prefix in the commit title. I kept the patches unsquashed as they were previously sent and reviewed. Of course, I can squash them if needed. Compared to the previous iteration: https://lore.kernel.org/linux-kernel/20240130084035.115086-1-herve.codina@bootlin.com/ this v3 series: - Remove 'inline' function specifier from .c file. - Fixed a bug introduced in the previous iteration. - Remove one lock/unlock sequence in the QMC HDCL xmit path. - Use bitmap_from_u64(). Best regards, Hervé [1]: https://lore.kernel.org/linux-kernel/20231115144007.478111-1-herve.codina@bootlin.com/ [2]: https://lore.kernel.org/linux-kernel/20231205152116.122512-1-herve.codina@bootlin.com/ [3]: https://lore.kernel.org/linux-kernel/20231128132534.258459-1-herve.codina@bootlin.com/ Changes v2 -> v3 - Patch 1 Remove 'inline' function specifier from .c file. Fix a bug introduced when added WARN_ONCE(). The warn condition must be desc->skb (descriptor used) instead of !desc->skb. Remove a lock/unlock section locking the entire qmc_hdlc_xmit() function. - Patch 5 Use bitmap_from_u64() everywhere instead of bitmap_from_arr32() and bitmap_from_arr64(). Changes v1 -> v2 - Patch 1 Use the same qmc_hdlc initialisation in qmc_hcld_recv_complete() than the one present in qmc_hcld_xmit_complete(). Use WARN_ONCE() - Patch 3 (new patch in v2) Make bitmap_onto() available to users - Patch 4 (new patch in v2) Introduce bitmap_off() - Patch 5 (patch 3 in v1) Use bitmap_*() functions - Patch 6 (patch 4 in v1) No changes Changes compare to the full feature series: - Patch 3 Use 'net: wan: fsl_qmc_hdlc:' as commit title prefix Patches extracted: - Patch 1 : full feature series patch 7 - Patch 2 : full feature series patch 8 - Patch 3 : full feature series patch 20 - Patch 4 : full feature series patch 27 Herve Codina (6): net: wan: Add support for QMC HDLC MAINTAINERS: Add the Freescale QMC HDLC driver entry bitmap: Make bitmap_onto() available to users bitmap: Introduce bitmap_off() net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support net: wan: fsl_qmc_hdlc: Add framer support MAINTAINERS | 7 + drivers/net/wan/Kconfig | 12 + drivers/net/wan/Makefile | 1 + drivers/net/wan/fsl_qmc_hdlc.c | 807 +++++++++++++++++++++++++++++++++ include/linux/bitmap.h | 3 + lib/bitmap.c | 45 +- 6 files changed, 874 insertions(+), 1 deletion(-) create mode 100644 drivers/net/wan/fsl_qmc_hdlc.c