mbox series

[v1,0/4] Fixes/improvements to metric output

Message ID 20240209204947.3873294-1-irogers@google.com
Headers
Series Fixes/improvements to metric output |

Message

Ian Rogers Feb. 9, 2024, 8:49 p.m. UTC 
  A small addition to allow NaNs to be encoded in metrics and then 3
fixes to various metric related issues.

Ian Rogers (4):
  perf expr: Allow NaN to be a valid number
  perf expr: Fix "has_event" function for metric style events
  perf stat: Avoid metric-only segv
  perf metric: Don't remove scale from counts

 tools/perf/util/expr.c         | 20 +++++++++++++++++++-
 tools/perf/util/expr.l         |  9 +++++++++
 tools/perf/util/stat-display.c |  2 +-
 tools/perf/util/stat-shadow.c  |  7 +------
 4 files changed, 30 insertions(+), 8 deletions(-)

Comments

Liang, Kan Feb. 13, 2024, 2:28 p.m. UTC | #1 
On 2024-02-09 3:49 p.m., Ian Rogers wrote:
> A small addition to allow NaNs to be encoded in metrics and then 3
> fixes to various metric related issues.
> 
> Ian Rogers (4):
>   perf expr: Allow NaN to be a valid number
>   perf expr: Fix "has_event" function for metric style events
>   perf stat: Avoid metric-only segv
>   perf metric: Don't remove scale from counts
>

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan


>  tools/perf/util/expr.c         | 20 +++++++++++++++++++-
>  tools/perf/util/expr.l         |  9 +++++++++
>  tools/perf/util/stat-display.c |  2 +-
>  tools/perf/util/stat-shadow.c  |  7 +------
>  4 files changed, 30 insertions(+), 8 deletions(-)
>
Namhyung Kim Feb. 14, 2024, 7:07 p.m. UTC | #2 
On Fri, 9 Feb 2024 12:49:43 -0800, Ian Rogers wrote:
> A small addition to allow NaNs to be encoded in metrics and then 3
> fixes to various metric related issues.
> 
> Ian Rogers (4):
>   perf expr: Allow NaN to be a valid number
>   perf expr: Fix "has_event" function for metric style events
>   perf stat: Avoid metric-only segv
>   perf metric: Don't remove scale from counts
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,