Message ID | 20240208135045.3728927-1-tudor.ambarus@linaro.org |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-58175-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp178846dyd; Thu, 8 Feb 2024 05:52:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHhBxG9mVGPrrAl4YOLVsXQ0CLGVpJarUUxVYG7VDH/lKwB50op3FwABSyrqki82vWgdsE X-Received: by 2002:ac8:4e4b:0:b0:42b:ee9f:be42 with SMTP id e11-20020ac84e4b000000b0042bee9fbe42mr12297412qtw.4.1707400326767; Thu, 08 Feb 2024 05:52:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707400326; cv=pass; d=google.com; s=arc-20160816; b=OanUNUQBdGekqxUZM5hmZNc/+K8e6t5z3eGKe3Wf5I7476JQAWId5fjEitjkCWB1aP 5f0NfZCRvraEwyQe3cZ1e3rARR9tsVdt2/er9I2GdpApmr0eFiufx68qASPxabNnnD2g Jh9DQZDPiaVTx9NsntgMEHwWFKUMI5y9enEznUuwRonnW15CEXlTB8aU1c9xlfvQWH4M pZrrcKSHt1X/BEEUcNuj9uoV4M0RLzDcsK9F9aCpn1lKMnm2WO3LhVUAngXxiKG+9FKT EMqZ6vbvi3jsdGpDp6/p2mDhnLb9cK04r8BsM6AcMW5RXBkeJfCjU5fTi6n/AlT5N7H0 1lXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ezIckqSjaHOJly+ofLnXueELrOHkQXapSLYglkjVtiI=; fh=B0qCldvpDStsLu26n9DG1kVSRxebr+0kTwx6LZMBfKM=; b=lhXsTnq0fkSljqEjn0VJhyLvnXrSJjrwWeIEvEcMgFx6JVfeuMTQxFcVlJ6OxVBC7A bO67twEA/AauXe4MTK1LDTj4QmQ7DB+TQPh0x5rKHIpuxCyw3bmtdY7zxZa7Chhy12iW zXv/5qf2W5uIs+mrSuytwmRs9DcwnDts8lp0/3UhmLkGXJYa4QLONguyk2X1ecxgNduC sz2k9HDVq/+vuJNifS+xBae+iGyY1A8hlgLLbIb4N06OKq7VFgxIorWyF8gC5qnG5hv/ WRjSDP1WRTu52Cx+kGI/fAfplbB58JmqS63/K3fUmOwJKT0fnHhVHZmAAgMT8d4liKEU 7Tgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LFtzZU7F; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-58175-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58175-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCWrWfCACLLYbHWxBoSDeD4UcO69pSuFDLtcc6g0hEsMb/rHJo3VK7BpCKdQodfv0TQ6rI3d4vpnDpmWkcdUOGJqI1WFhw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h22-20020ac87d56000000b0042c4d0b3a8esi59893qtb.70.2024.02.08.05.52.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 05:52:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58175-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LFtzZU7F; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-58175-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58175-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 71F191C28655 for <ouuuleilei@gmail.com>; Thu, 8 Feb 2024 13:51:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE8AE7A734; Thu, 8 Feb 2024 13:51:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LFtzZU7F" Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F08D768E1 for <linux-kernel@vger.kernel.org>; Thu, 8 Feb 2024 13:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707400256; cv=none; b=O8mdbpPrjzxXkOtDNiZmH2LIVfrq3BFT7A+CiGEK12RBn9/pJGO6oNmL5paAb/IktcbHYPuJb5iro6kD+QRR0mVQ82OnVK03m7fF9erhvCIgHCnLNLV92EoRZuuWTXS6GC6qfdF3KeQL+jyIt4IwefXB5gm6SUZss+FB0UlqO7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707400256; c=relaxed/simple; bh=rkU81zi0IpYhhc5gOUB/YrsotltKHmP2oeD/quouCyo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MbahCQAk/3Y2jQwN1VehxvibMbwsc1tyRN1mnUBnH+ldw8EOl1q8D2ZoTa1qYnFR/MqTwc13upYHu9/r9E2eRHxlAEFsEUTDcQmCmiqA0Y64p8PzDHV6TLBft6hmpIdhQjuKwM2+oILUgs2Mp5dVkmobEv3iFHVvXWwL0HjJwGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LFtzZU7F; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4105006bf11so917655e9.3 for <linux-kernel@vger.kernel.org>; Thu, 08 Feb 2024 05:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707400253; x=1708005053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ezIckqSjaHOJly+ofLnXueELrOHkQXapSLYglkjVtiI=; b=LFtzZU7F9m4Z/POSlfDcxhPT+d9urSlOb+okSHqn4i1lAooje9RiGkzz+U4K3T635i mTfZM5B/HGr7YEvBNxHRheEmyuGl0YAK4yTa2/T9MFiYbZ4I/Kr8rmiIJhVo85ImHOll AvH1dp95/38LQ7O8R74bXH1O5xVqef64seyQi7ow2U+B8WEesFlGBxLf47Pzr9A+c6mt bamejG5bKrsZ2HYxdETcRtUe5Vu2D/FbzbC/I16LXzR4EcDxf0TJp+ng4vRN3Fxg5VFK Fn5slJMmmq8ljTN5lgLiMZtI7Jl8DF5wEZXQgGzAlC0vvtuoR6vi5+hwELNBdPflkSmo iPlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707400253; x=1708005053; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ezIckqSjaHOJly+ofLnXueELrOHkQXapSLYglkjVtiI=; b=uNqYUqMEuS8DCQkJtfF4kbOJPXadORVzO4oY4WxARMRQ1AePv/d/zSyhDypa88jZhd na61lTZJhYOQpF2S51zDJytyGG/bFnx9DsHbwV7ZOBN4xXN39wo2XGZ1a5X7r82JDYn+ 32t/dqXKxyy/VUSFBZWB9kHCP9TTsFG6hoVgw+bxIB1G/YaES4fsHd6iwO3An9wQUFy+ b/fCVOf3BTcD52bH9rf7TlpQjh44DXLi592pyAWVep1X+3NiHmpS+YZoEUPqB4FbzOdx YgFI/07sbxCaTHhIBH+V8P3afGvO911TItR84IiMCg7t77dyunCPOLp2T+jsVnD3Cb8V eOnw== X-Gm-Message-State: AOJu0Ywaj6q5Wwr/jhykqjILBTFAgVrHvgRg+hJgcswCh54wwPL2P6Ez 27YmA936PJDriJNtrJi+nkNNKHEcs0OVc+Xgbk3G4vOdifJ+IR4f3FlBEqVB7nI= X-Received: by 2002:a05:6000:1208:b0:33b:3ceb:99cf with SMTP id e8-20020a056000120800b0033b3ceb99cfmr5543737wrx.67.1707400252929; Thu, 08 Feb 2024 05:50:52 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUe+IA8lClHorFvbt+R7LYrtzl9JaTfah+IU2ztSQn2l67Okgaei3aZz4l8mQjnMAtX65LLUAuq8KW9RX6Xejg3SPycB7enkRe/JD4vuAn2TWGDR3OkAkhhA6sRJEL6DwLNi4bPyCsEw8KS35tAj4AoO23/RhqfO0hHVn6BtuwrWbtQarWlEBAXjxSyBRkRJtK6drm7xDeJqVbvghCVRDFnSVAwr8P9W1UevPnA/Q9uEKdvfdIo3awYkoDvyWIsVuWV/Sz8ELSzlPWZ1/ebQof/VC4yCEWVjOM6edN+zz2C31ItxIlhiTk+7zfkvfrRBckeQTH7BmHhOy7vfI8NUO5NoUI8+NxVrRzmbvUnQLxGcMjHn47EqK7KwS5w/xS5xCUoruB98DC17flAcA/9ykOzp2V3sH8vI3Rgp66FWjG5gUo1i3C0JaXSueYB/ZTrKtw07bjVaLDqaf8B1Psm5/0h89ZiSLkOe60LnwaGK4O/m7/DxtJcwYqOF2RjL3ehs2LBvTXU7v5aKH3uv1kr1rMIW25K/nNRqW+D+a0A2rBwBuNC5axZAmCLgjO0Q6cRcsVC/2p0aZJtHWDq0k+R/YMFrKombP0nST5YR2EjSg== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id m20-20020a056000181400b0033b43a5f53csm3618820wrh.103.2024.02.08.05.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 05:50:52 -0800 (PST) From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH 00/12] spi: s3c64xx: remove OF alias ID dependency Date: Thu, 8 Feb 2024 13:50:33 +0000 Message-ID: <20240208135045.3728927-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790339005365251228 X-GMAIL-MSGID: 1790339005365251228 |
Series |
spi: s3c64xx: remove OF alias ID dependency
|
|
Message
Tudor Ambarus
Feb. 8, 2024, 1:50 p.m. UTC
The driver was wrong as it assumed that the alias values in devicetree have a particular meaning in identifying instances. This immediately breaks when there is a dtb file that does not use the same alias values, e.g. because it only needs some of the SPI ports. Tested gs101 SPI with spi-loopback-test, all went fine. I updated exynos850 as it uses the same USI.SPI_VERSION as gs101. Maybe Sam can test exynos850, if not, we can drop that patch. The patch set has some dependencies. One has to apply first the gs101 addition [1], then the simple cleanup from [2], then this patch set. [1] https://lore.kernel.org/linux-spi/20240207111516.2563218-1-tudor.ambarus@linaro.org/ [2] https://lore.kernel.org/linux-spi/20240207120431.2766269-1-tudor.ambarus@linaro.org/ Cheers, ta Tudor Ambarus (12): spi: dt-bindings: introduce the ``fifo-depth`` property spi: s3c64xx: define a magic value spi: s3c64xx: allow full FIFO masks spi: s3c64xx: determine the fifo depth only once spi: s3c64xx: retrieve the FIFO depth from the device tree spi: s3c64xx: allow FIFO depth to be determined from the compatible spi: s3c64xx: let the SPI core determine the bus number spi: s3c64xx: introduce s3c64xx_spi_set_port_id() spi: s3c64xx: get rid of the OF alias ID dependency spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id spi: s3c64xx: switch gs101 to new port config data spi: s3c64xx: switch exynos850 to new port config data .../bindings/spi/spi-controller.yaml | 5 + drivers/spi/spi-s3c64xx.c | 142 ++++++++++++++---- 2 files changed, 116 insertions(+), 31 deletions(-)