From patchwork Wed Feb 7 14:52:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 20059 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2281705dyb; Wed, 7 Feb 2024 06:53:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXPXmWZ7mvg7bRlEkq9UV30l5I1RxCWfdQAB3skWtEwMyIY+UXnqhZCdEzdSNwRD2VhI/Wso9AAxHgT55x4HoJhDMd0/w== X-Google-Smtp-Source: AGHT+IE3pNWpuyKFXJDN0x0bA6i33Ak+fg2CLir7k2Bi6CK4hW/jStbCGkuixA2Y4SxhMPIYBvPm X-Received: by 2002:a62:e80b:0:b0:6e0:3b97:377 with SMTP id c11-20020a62e80b000000b006e03b970377mr3092890pfi.33.1707317622304; Wed, 07 Feb 2024 06:53:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707317622; cv=pass; d=google.com; s=arc-20160816; b=xsx44Qwh/J5AWl9/eKAFd5R4w5k4Xl7EK0ptCiKxAajT0il+/N8DeThMX2XSqMTyZi F9WrIq1IZRie6+ht+Rml9TD6FotpJoD16hqfJ6KDmWlypf8ZpqLdbAqLwRHZKCfj7zpj uh371qOvldZrFJ9vCM82HTLoKIGVgXuIIPtIPA/hqidxOqNfWYyHDtGhytLqXSS2o2/P OGk29mqvNmhthuo6VUyamoHDUAOSJuAVmcTX2M6HLroF/1Wq/jI+vev5nR4HcavzF6tx R3fJNpQbpsjD+FMu8/8+RMHltXbIZaAFe9NdbeKFwDPHlbejE7gYJKd3inr8UrupKCkJ 5eSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=mE06ENnVWqBTCRJ6dk+NTA+VvH3d3TbOoqSEznAMgR8=; fh=Xz3b3/XzwGy28nDhWmkv8ssnffXksdYD37htWCLu4o4=; b=nzR/8hIHvejNS8sLIeDhadm4p0KzK5M6BAnBiV6SUQdcwCLZpahKwOr0BdNS4un3wK V2rh9GLlV9v8rofoEGdAFY18icUmWwGz412bjNQ7u4GlpCiwaTceDpM+y0Yn24fwL4c2 ykZpXA+7r7+dIFzh9cbNossj4hqVuCQJsieTnDiWQCmHRDcNlKU/6g7R/xNKID7CgD2z A03No1zu2QjhLMAou48w23PxR9+xrQGVtyHL2tz5bYqFQMUOad6h0sscyZCI6Uc5QfJV z6gQS8wK+uFK0+FyrauJ9GyhwM2SSDl2J82QGnZ+CisVQBTsHhjAln3ggBdNipKiPUNE 4qZA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=XFzFNkTF; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-56659-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56659-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com X-Forwarded-Encrypted: i=2; AJvYcCWVqgudh10qGhz6gEqNx6+WYtA1xIqZEaZ3Wz60evFz+3XpEuZ0oy7ZQoKFvKmGivzXL5YWaBXE+VklQOMC4ryMwijVAw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b27-20020a63931b000000b005d8e3a180cbsi1705974pge.841.2024.02.07.06.53.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 06:53:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56659-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=XFzFNkTF; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-56659-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56659-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 045DE28B4D2 for ; Wed, 7 Feb 2024 14:53:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6EECE7F7DC; Wed, 7 Feb 2024 14:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="XFzFNkTF" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FB547CF03 for ; Wed, 7 Feb 2024 14:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317597; cv=none; b=FJFHgTp1XyyVuvYRtRPgXLGkMCRqJ+i2bBeWI1dTZcXQcVI/jH1XWx/9O7adK097MOKotC1dM/1oBcUpJooxkXzQO9IrDye67zCgInE6RlZUmej+/48zj/8zTDooZ+f225yQw1WGXnA7ezIRfqj5xYli2/MCrnnXOReUsFrKsjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317597; c=relaxed/simple; bh=7dhx+O2PyaDEDeGc1HBTFc5NQvFFIflUo1Mzmg6Ym7U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VxpYOR/ZifxaFz/v4T9x23rU5e3+Y3Z4AFMZ+q9IhkcYqTgxR1TTd9EgfjfLb7Mj2AOAyqnCTfHVuxpSRdoyVafyR8b1fByl7GTTggOHQtMyqNTaszgQLU6aMpBhJu6ZesC5UdUqudWzYmMmflvAKLESFMC83UbUfbI0NuwqjWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=XFzFNkTF; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1707317594; bh=7dhx+O2PyaDEDeGc1HBTFc5NQvFFIflUo1Mzmg6Ym7U=; h=From:To:Cc:Subject:Date:From; b=XFzFNkTFM1aH23cD74LkWG3zPLnD/HBJr9y4S6RvFGQimYbG20ztzBGPyq0S1HKw/ Az8LXxflEtm+V9AK7gIAtY9M/PdzthysoHX0YBvtAiycfa8fXBIrENQn83KTRgSkH3 eeUCLDrHrJWMiwm46p0w0uydiq2FYbKqIm5rYe/9FPi6lGza5N4QHinfYOZLNdHeP+ pj/vP3wHY9lCUEN7LweLzugDIHXqpCQaYZkb10g77w5/E3uoH1mQxSDFtx7xcl6EcA eynQlhkUCiIOVJQj2D1McyAZPyh2285nXFJd7+c9fZi2NcXlkhTjubO5hxE5ZVSRjg PXDZv9bJKWSRg== Received: from IcarusMOD.eternityproject.eu (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 778283782059; Wed, 7 Feb 2024 14:53:13 +0000 (UTC) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: fshao@chromium.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: [PATCH v5 0/9] MediaTek DRM - DSI driver cleanups Date: Wed, 7 Feb 2024 15:52:58 +0100 Message-ID: <20240207145307.1626009-1-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790252282640511359 X-GMAIL-MSGID: 1790252282640511359 Changes in v5: - Changed patch 1 to not fix the DSI_PS_SEL mask for newer SoCs Changes in v4: - Added a fix for RGB666 formats setting and for wrong register definitions for packed vs loosely packed formats - Added a commit to make use of mipi_dsi_pixel_format_to_bpp() helper instead of open coding the same Changes in v3: - Rebased over next-20240131 - Added bitfield.h inclusion in patch 3 - Added three more cleanup commits to the mix to simplify the probe function and remove gotos. Changes in v2: - Rebased over next-20231213 This series performs some cleanups for mtk_dsi, enhancing human readability, using kernel provided macros where possible and also reducing code size. Tested on MT8173 and MT8192 Chromebooks (using a DSI<->DP bridge) and on MT6795 Sony Xperia M5 (DSI video mode panel). AngeloGioacchino Del Regno (9): drm/mediatek: dsi: Use GENMASK() for register mask definitions drm/mediatek: dsi: Fix DSI RGB666 formats and definitions drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}() drm/mediatek: dsi: Use bitfield macros where useful drm/mediatek: dsi: Replace open-coded instance of HZ_PER_MHZ drm/mediatek: dsi: Register DSI host after acquiring clocks and PHY drm/mediatek: dsi: Simplify with dev_err_probe and remove gotos drm/mediatek: dsi: Compress of_device_id entries and add sentinel drm/mediatek: dsi: Use mipi_dsi_pixel_format_to_bpp() helper function drivers/gpu/drm/mediatek/mtk_dsi.c | 310 ++++++++++++----------------- 1 file changed, 126 insertions(+), 184 deletions(-)