mbox series

[v2,0/4] Add support for QoS configuration

Message ID 20240205145606.16936-1-quic_okukatla@quicinc.com
Headers
Series Add support for QoS configuration |

Message

Odelu Kukatla Feb. 5, 2024, 2:56 p.m. UTC 
  This series adds QoS support for QNOC type device which can be found on 
SC7280 platform. It adds support for programming priority,
priority forward disable and urgency forwarding. This helps in
priortizing the traffic originating from different interconnect masters
at NOC(Network On Chip).

Changes in v2:
 - Updated regmap_update to make use GENMASK and FIELD_PREP.
 - Removed the regmap structure from qcom_icc_node.
 - Made qcom_icc_rpmh_configure_qos() static
 - Removed qcom_icc_rpmh_map() API, inlined the code in probe
   function.
 - Updated declarations to reverse christmas tree fashion.

Odelu Kukatla (4):
  interconnect: qcom: icc-rpmh: Add QoS configuration support
  interconnect: qcom: sc7280: enable QoS configuration
  dt-bindings: interconnect: add clock property to configure QoS on
    SC7280
  arm64: dts: qcom: sc7280: Add clocks for QoS configuration

 .../interconnect/qcom,sc7280-rpmh.yaml        |  49 +++
 arch/arm64/boot/dts/qcom/sc7280.dtsi          |   3 +
 drivers/interconnect/qcom/icc-rpmh.c          | 161 ++++++++-
 drivers/interconnect/qcom/icc-rpmh.h          |  32 ++
 drivers/interconnect/qcom/sc7280.c            | 332 ++++++++++++++++++
 5 files changed, 573 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Feb. 5, 2024, 3:12 p.m. UTC | #1 
On 05/02/2024 15:56, Odelu Kukatla wrote:
> Enable QoS configuration for the master ports with predefined values
> for priority and urgency.
> 
> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
> ---
>  drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
>  1 file changed, 332 insertions(+)
> 
> diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c
> index 7d33694368e8..438f927935e5 100644
> --- a/drivers/interconnect/qcom/sc7280.c
> +++ b/drivers/interconnect/qcom/sc7280.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
>   * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
>   *
>   */
>  
> @@ -16,29 +17,53 @@
>  #include "icc-rpmh.h"
>  #include "sc7280.h"
>  
> +static struct qcom_icc_qosbox qhm_qspi_qos = {

Why this cannot be const?

> +	.num_ports = 1,
> +	.port_offsets = { 0x7000 },
> +	.prio = 2,
> +	.urg_fwd = 0,


Best regards,
Krzysztof
Konrad Dybcio Feb. 6, 2024, 9:07 a.m. UTC | #2 
On 2/5/24 15:56, Odelu Kukatla wrote:
> This series adds QoS support for QNOC type device which can be found on
> SC7280 platform. It adds support for programming priority,
> priority forward disable and urgency forwarding. This helps in
> priortizing the traffic originating from different interconnect masters
> at NOC(Network On Chip).
> 
> Changes in v2:
>   - Updated regmap_update to make use GENMASK and FIELD_PREP.
>   - Removed the regmap structure from qcom_icc_node.
>   - Made qcom_icc_rpmh_configure_qos() static
>   - Removed qcom_icc_rpmh_map() API, inlined the code in probe
>     function.
>   - Updated declarations to reverse christmas tree fashion.

You ignored some of my previous review comments without a response.

Konrad
Odelu Kukatla Feb. 22, 2024, 10:54 a.m. UTC | #3 
On 2/6/2024 2:37 PM, Konrad Dybcio wrote:
> 
> 
> On 2/5/24 15:56, Odelu Kukatla wrote:
>> This series adds QoS support for QNOC type device which can be found on
>> SC7280 platform. It adds support for programming priority,
>> priority forward disable and urgency forwarding. This helps in
>> priortizing the traffic originating from different interconnect masters
>> at NOC(Network On Chip).
>>
>> Changes in v2:
>>   - Updated regmap_update to make use GENMASK and FIELD_PREP.
>>   - Removed the regmap structure from qcom_icc_node.
>>   - Made qcom_icc_rpmh_configure_qos() static
>>   - Removed qcom_icc_rpmh_map() API, inlined the code in probe
>>     function.
>>   - Updated declarations to reverse christmas tree fashion.
> 
> You ignored some of my previous review comments without a response.
> 
> Konrad

Thanks Konrad! i replied to all of your comments.
I will send V3 with all the comments addressed.

Thanks,
Odelu