From patchwork Sun Feb 4 23:40:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 19911 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp575558dyb; Sun, 4 Feb 2024 15:41:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFr6/SfBvzZWQ+c5isX1taK7NKZbeSrw3a+yCugyGjxxPWvlsE4M/pCWYTkLYyEhWSoA06 X-Received: by 2002:a17:902:a5ca:b0:1d7:5eef:4d5 with SMTP id t10-20020a170902a5ca00b001d75eef04d5mr12556127plq.49.1707090115045; Sun, 04 Feb 2024 15:41:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707090115; cv=pass; d=google.com; s=arc-20160816; b=nFUVVT7Z9Ahvr4jhuQxu2wGirrKLLmq9bQfIolHic2+rIbd2TOq/pX84bTuFkjtSIh hTwgaKK7pYyOTY5DWlOOc/BTx7mwPeRF4ENBWDa1f+lynre/LrApxXRyowUT2wMsZjyX 0irFbxV1T0ppcU+Ce5/3hN9+ONXqb0FojB2rwNjaf14pPNqLu3cYhzvgU/qSyshTyEAA 09oxhYVby0BUx3OJgF6Zd/np9R3XB9wgsE/Yef389891CEwTdPCjFVv54yviGYg71Ono IQH2dkCgjEBL8Gh5HUhmQrQXvUETVph655fhNelbncilp0qfwB7gQB6prxvEUanhFO0y Lk3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=ofMfbIjqFytnpEYWawM8vASgAHDc01IrEgzRrZALl3A=; fh=uP0B7BN6m/DwQ6hlqSsrHgJrx/Ke7YXR/2UVU7c2/Gc=; b=wt2aABZSe/0srJa+kVWo4VIiZA+A0amTQ88aBjvm79x29D7CkL4XkbZ63uG/KbGw6V 7wq9E26DiuDkTL2A6DCBIajy8I+6SDOwmres4/ntDqBCK0qfbOE9LHu9j0nPoGwS+ruH VLLCw9EBkxUIePKfHq2/B97bzQBELQCxHGRWaywg83v9SBAJDCYftl4hpLM6J263E6vX IqTTgzrmxklIxANU3qRxGUZhBxivoD6lPI7MNh/w/g9mfMwYwh2fIKvHdZozKhuXXbGS o2s5QrghC36TGsFVRt7ZvarhbwX332YsVgUf9HkBiouDJAHIDYwpbt/Ggv61C0Xc/B0z vF1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=eBhb6YHz; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-51950-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51950-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=1; AJvYcCXYcaDugwbLYSSMBZqIU2V5KrpDvEj0EiYMhcY3Zx2fOkHvzwSxRVXRfEs2F01xzJnxGwusjXHZiTDuyxL1lI5yi3LMlg== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q12-20020a170902eb8c00b001d8d6c1fcbcsi5437160plg.64.2024.02.04.15.41.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 15:41:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51950-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=eBhb6YHz; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-51950-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51950-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CB45028271F for ; Sun, 4 Feb 2024 23:41:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DA22012E63; Sun, 4 Feb 2024 23:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="eBhb6YHz" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45F69BE5B; Sun, 4 Feb 2024 23:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707090046; cv=none; b=QzQxaqYKFQQZzr2kGr3lhGzBKP10157V8AwXwNyZkGlY4GND/t+lLIQucncrlTGU1qis9Nqex59y3AVEdu3zp1bfetLz4v42kRxyYZr0ssb0CGUXC3hcD1fVjBsZ7waMJeDxYpTsVycXhBlfR8M1IOfE2x0eb8HJheQcaC3GumE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707090046; c=relaxed/simple; bh=xTLNlRe9zpFCH+NSfLBy79yr+GAoL3YfMnIrGZaTLxU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Qjzj74sndKTkRTBL+hdJYrdBaqEGCygr6LrvvsfgVGP9COkmxtGxJVD7rPRmw0MN/pdNE5Gdr+0y699inZHyhId6E+tCcvsOb29mFWPPm3Oj5rL1JOPo0qEsQKW63KcgG/WCR6/5M4lsUF9U6oRWyHLc+aqqNGlXUiMaAkEpUJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=eBhb6YHz; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=Cc:To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:From:Sender:Reply-To:Subject:Date:Message-ID:To: Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Content-Disposition:In-Reply-To:References; bh=ofMfbIjqFytnpEYWawM8vASgAHDc01IrEgzRrZALl3A=; b=eBhb6YHzTA0gYHZgNDf9Zod3lL 7NQnM5GNtN6wANB+ki7+CQSFvuLosaBr92vdf+M+HTUXxqSVha4SS8Ch3vm2K0x5oVQgwPiG0pmyw mvkoLInmj5SV1jQfNgp1oEZEN5sGAWatxlYodEXiYtBDaXgTenF5pDtodGSN/yBC0fL8=; Received: from c-76-156-36-110.hsd1.mn.comcast.net ([76.156.36.110] helo=thinkpad.home.lunn.ch) by vps0.lunn.ch with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rWm6A-006z7T-0Z; Mon, 05 Feb 2024 00:40:30 +0100 From: Andrew Lunn Subject: [PATCH 0/8] drivers: net: Convert EEE handling to use linkmode bitmaps Date: Sun, 04 Feb 2024 17:40:17 -0600 Message-Id: <20240204-keee-u32-cleanup-v1-0-fb6e08329d9a@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGEgwGUC/x3M0QpAMBSH8VfRuXZqZrS8ilxgf5xotEVK3t1y+ bv4vocigiBSkz0UcEmU3ScUeUbj0vsZLC6ZtNJGaWV4BcBnqXnc0Pvz4MHWrramss4qStkRMMn 9L9vufT8UihgyYgAAAA== To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ariel Elior , Manish Chopra , Jesse Brandeburg , Tony Nguyen Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Andrew Lunn X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1999; i=andrew@lunn.ch; h=from:subject:message-id; bh=xTLNlRe9zpFCH+NSfLBy79yr+GAoL3YfMnIrGZaTLxU=; b=owEBbQKS/ZANAwAKAea/DcumaUyEAcsmYgBlwCBn8ggPNVIXSaz7IAvAixB8ka53ggNMSY2Zc vicaxrWtMeJAjMEAAEKAB0WIQRh+xAly1MmORb54bfmvw3LpmlMhAUCZcAgZwAKCRDmvw3LpmlM hG+VD/0TtJaWfgHoLdXUBMZQUhJbJSj69wqg80e7HoEDOYeyGWGwJ2wkFhMXkTzvjg011y2gFgj zALmvZsfxriALcG44ySLy82tVTE4Hij9IAV8rAcgn8msp1M7p708ctj8xZU+p1G1R9Tt0XtPF8M hI1f4AnAdPCAz3Wx0b6cKMl6P6LAYnYG+vLsjTWCiEp6WnW9V+CFgVAGeIrfoRvXTHKAkM4vnqe 1DVzDxkalb2adpWWyhqGQmQY+N+dlERDDV8Cdfrw0z5ax2NIiZa3eIf1ovgz/SNgqzF5s2vmvot x9T/aoJ7qMBAazsfF4Z3sarXBWkOehFlBQZD0bBkN7MWVx6fBKp9t+f/6jNJRF6ZgIgJWapwGoz pa+dv3jwI77GHHq2VXO0kMe5sde/XpLzmavHeuCBZ0a0a//CkuMvjc+eHMVwYpqVAvd7sLrJTOW 2yfZX4lt9/RsnCfrhNBjIht7H9KnGSpPShFfvNSKOJ5JRdFYhEbJ3tMdV5ZLNlnifaK5I+uSwVC swAFQBR1rgwp3dyCvH8PYwbHorQkGR8+uGphBacdWtMSveS588U5tzQSXaZ1aLosyBvT0Rnenpe jsRprUFXHnumRUuSEZnq4IRBK7RxhGYrUjgPRaJjRV2Pf3kv4fYRIR/o1G6NjaUfnf9vKjpEha9 mLrKi2q/9IJSeBA== X-Developer-Key: i=andrew@lunn.ch; a=openpgp; fpr=61FB1025CB53263916F9E1B7E6BF0DCBA6694C84 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790013724260088131 X-GMAIL-MSGID: 1790013724260088131 EEE has until recently been limited to lower speeds due to the use of the legacy u32 for link speeds. This restriction has been lifted, with the use of linkmode bitmaps. This patchset convert some MAC drivers still using the old _u32 to link modes, with the aim of soon being able to remove the legacy _u32 members in the keee structure. A couple of Intel drivers do odd things with EEE, setting the autoneg bit. It is unclear why, no other driver does, ethtool does not display it, and EEE is always negotiated. One patch in this series deletes this code. Comments on why its actually useful and should be kept are gratefully received. Signed-off-by: Andrew Lunn --- Andrew Lunn (8): net: usb: r8152: Use linkmode helpers for EEE net: usb: ax88179_178a: Use linkmode helpers for EEE net: qlogic: qede: Use linkmode helpers for EEE net: ethernet: ixgbe: Convert EEE to use linkmodes net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities net: intel: e1000e: Use linkmode helpers for EEE net: intel: igb: Use linkmode helpers for EEE net: intel: igc: Use linkmode helpers for EEE drivers/net/ethernet/intel/e1000e/ethtool.c | 17 +++++-- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +-- drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++++++++----- drivers/net/ethernet/intel/igc/igc_ethtool.c | 13 ++--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 48 ++++++++++--------- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 +++++++++++++++--------- drivers/net/usb/Kconfig | 1 + drivers/net/usb/ax88179_178a.c | 9 ++-- drivers/net/usb/r8152.c | 31 ++++++------ 9 files changed, 123 insertions(+), 96 deletions(-) --- base-commit: ffabe98cb576097b77d404d39e8b3df03caa986a change-id: 20240204-keee-u32-cleanup-b86d68458d80 Best regards,