From patchwork Fri Feb 2 14:57:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 19848 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:9bc1:b0:106:209c:c626 with SMTP id op1csp482192dyc; Fri, 2 Feb 2024 06:58:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhe+ndzmsaiM9R85KLa0DiKsdBafzeQIq1Q6DtxYtSF8yAn+YZ+FoS/2ipmJt01pNsAyMt X-Received: by 2002:a05:622a:1748:b0:42b:f6a6:4058 with SMTP id l8-20020a05622a174800b0042bf6a64058mr3812452qtk.15.1706885893304; Fri, 02 Feb 2024 06:58:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706885893; cv=pass; d=google.com; s=arc-20160816; b=UUp3G+ssOKdTr6T4vsRTIu3Owo8kTrSE9kVYnJiTb6sMcWLxJaKY/aFMyTl08Fd3dn lswx08ghV2P7KvHi8xG75HnzpvOdP36vGbkXy19C40HnpVA15dmBmSLeXHeclrAajNIm 4MZsAnspjPAH5G2wUnAxeY5/ta+TYTgluo4YaqQzwtlhSN6CR3TI4+EiAnJFDJA+csq/ jG2VftDpcKIYZ/nI6kTdAdfz++I3epIFg/D3BZZpcFAgR1N51pg4Cq8dftveWzM4Lp3f icJlw0dd2P0NeLLmkgrpRLqbw6jGUHB38yXqH4BOj89h7ZGJ7WZ+MiQpuazQETDydkE3 VeVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=l52rEpkUwMDo2Zba4o6n3vS7Nj2bBzY4EMwlY5C0Lrw=; fh=e4vvYwTjP2IQ6idcY2nlZG2/Nrrj+6Poc4DUNOGQuVg=; b=SWmpI2FsAHHqMhAl53iiOKkrlGwn0ht+d2be1ePpnrn86yFBtkcxfma8bceaJEMe/j vrMylhAB39z9qECJRCv9uYYQxpP8WRYHswyYL5CAfzGCBKHKUiEUDaWYn/CDxLUk56Rv COe0RyqldDo7u/tY4y4T50B86HS+t3i7xvBHLKRa+iEbboXiwtTQeDUSQm1xAS/ScWt4 yzjBG4TEu4U9KHgic/MNFYSIUDUvs+k5ARBdUkcomiiHyh9n2yN/8yN4i2yct8bWqx7D hnorD6NvHuoCMANxsbEPjuwLXav1GTYW+bsiOzhNVMucSW7UyXApx0CCs+LWc0tS/AlK i3ow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HXlVuTVW; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-49974-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49974-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCVEgb1zskZlsiskmqdGDX/MiJ9At8rIupGa1rCqm682+w8juFxqU9Y9mRkbI1uoViRIwlm4HAlsJU+8VMq+v5+aPI2OPg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e7-20020a05622a110700b0042beb38a633si2228724qty.659.2024.02.02.06.58.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 06:58:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-49974-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HXlVuTVW; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-49974-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49974-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1C5B11C2248E for ; Fri, 2 Feb 2024 14:58:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 868DE145B3B; Fri, 2 Feb 2024 14:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HXlVuTVW" Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF9213E228 for ; Fri, 2 Feb 2024 14:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706885865; cv=none; b=sHpPkL8/QCT/3JQ7WCu1v6jQfbv065pjJMlV6lBDrlWsRacqZpCttd10Ro/yl/hC3eWwgQF50GSSi7UK5QSoJK7VACXG6TZtjxk8IZ9wCIQfgIg4w0ilcpcBMilf0kCD4ZvtjO0S5qeaGHf0llnKfOHzKjYX61rOQ4/xvUgdt0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706885865; c=relaxed/simple; bh=1lr2rBMrd5PP9mf2/qYecMEIsW1HFWq9nzMWPG42CwU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p2xOzSrOFRaFKUCSp/7ud15oCA63Evi335IdoCvBvYxkTNZOnwWARDyi/HU+SVIyommyp7E4NitEoJ7uytaYTZDJ6fF4wKiIXfESrol1GzmXSl5QM2kpw5GNUFtaZidZG+50rvJbPkM8NIKhzy/DiCdlTKv8tuE0U0LhMpZsOsg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HXlVuTVW; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-55ef0465507so2704558a12.3 for ; Fri, 02 Feb 2024 06:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706885861; x=1707490661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=l52rEpkUwMDo2Zba4o6n3vS7Nj2bBzY4EMwlY5C0Lrw=; b=HXlVuTVWjOBipZFR6zrTdfrSzLGE/AX8072WeeE8sBmtc5tgrbFoEkgNvr69T6MOyP QU59ra1r3M/I2OcX99vE5AQLg8anWQIKq1oN8QteCz8WdwRAucvCuk9Ym7D1xJbz6LjL zzMSwElKHaUJXMSLjAQekGBqPUFipfByvsj/gv3nZEb97ISc/vU1QlgkzlHZoVrz/gYX Z09bshnKLo34HZgHhisW8ZxAdHj3YCE2CZcLqXAjz+ynKYQzxUOpaOGEqzpDkByxX3x5 l5MMqxZc5FexLa3iH5N9IUoJbEnIboF0y1mgsM0v87vKNrbXOLMVA86DV4ffln2Mg7NV vdwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706885861; x=1707490661; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l52rEpkUwMDo2Zba4o6n3vS7Nj2bBzY4EMwlY5C0Lrw=; b=xLR5ymAkk9o0cuhR9vEZHa6myDLr1mMU+vwUU5BqhV4ZGCPD3uMwc90GzupJqeyeXn 5qH7i3rLRJzw7sfY1ogdnHc1prt95bWKyRjjzsy2LNIudLmpOXWQ32MJTe+8HrToZhGa tkH9p9vV1gMj2XkUY0QoTtD8H3Cvv4ZcQaYrhHwxwTxL6muUYD13BnRDecAxP9/k6LjJ PasDaZwUsTiAHQkMuYh6N3T2i4/vQhc2wjT9XJpjAxjSHxpe7tnnuN4NbMYTQlnorYO8 MEYTImsZs4nUAT+VsmSC9pB6NuQVZDESD1uENKBWEBt/piUHrfBuMU0Ikh2l+yHDjHPE F5aQ== X-Gm-Message-State: AOJu0YzO48zti38LI0rlllmsY/qmRvkWDwz1vOmAnTXRHa+K9mC/oovt Khae4RPvX/gS1YdPU3I+YxeDRK/kfmI47D/dYO/DJu3ZQaFPip0B3gq1IP5Ymqw= X-Received: by 2002:a17:906:e81:b0:a36:47fa:4b8c with SMTP id p1-20020a1709060e8100b00a3647fa4b8cmr3882383ejf.9.1706885861548; Fri, 02 Feb 2024 06:57:41 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW4Iv63M/sjFwyyZ1Yu7E+K3YAMIe1KCna8PUJk0ZmO0ce1i2Rn/R+uTov2FgTh8yK0bj2GwDkaEy7jlYd5Cnb1HeLqb1wJmaJfFsd0A6Vx5Q1TGqtTFKxcB6NJ78G9cOaMvk03bz0v73YDKz9cFnCNVPYU//cKkkpm1vCEQ18xTR5GV+bZTygz57akm1li4rjnGL+KiXmHhDcvqzB2vFnIk1VzxNVOyiFkgAaqQP7P/WkvvVfwOJSohxwL11G5hJUXv+SXZVHVYyZgDtLiKYJ/7myzmDUIVInFXWPXpLfb3AKmcesoVd36DVav68luW4IlngpXcYHek8+gkuIPc5Vjquok8g+DIRDmtDrRcBdeenBhmKAu39XVDFyb3Q6AyiXVZAzMSTRnz7u7kQgFVKDOxEmlnwslHEVW4b+T36YHoWTUTfljbNVUyWObqqZE8XlkgEsjRieRrAVKI1heQe09kB0KaE/Ty0VwvZXE3T7qvEQPrslhht2qF2QkPMiWCB8id731HiKTPpcFSq3J+LZh0JqkT744LAB6scIVn5HNHjOR1fGesgT60SDOtiq500F+18lwkgw0ysFpqQ3jEY3h62B9YC+kkY+aTKpBvVQppC3ohOZW3OCDM3AU4nfGm/ll2UVgWl/9hIex2gAYigTNeGlgzFNMjTQKe+PX1WSgYWNkA6Vdi6XIEMC4MWZWGRJX6+q6L8tjpw== Received: from gpeter-l.lan (host-92-21-139-67.as13285.net. [92.21.139.67]) by smtp.gmail.com with ESMTPSA id t8-20020a17090616c800b00a36c60180aesm957200ejd.60.2024.02.02.06.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 06:57:40 -0800 (PST) From: Peter Griffin To: arnd@arndb.de, krzysztof.kozlowski@linaro.org, linux@roeck-us.net, wim@linux-watchdog.org, alim.akhtar@samsung.com, jaewon02.kim@samsung.com, semen.protsenko@linaro.org Cc: kernel-team@android.com, peter.griffin@linaro.org, alexey.klimov@linaro.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-fsd@tesla.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v3 0/2] Add regmap support to exynos-pmu for protected PMU regs Date: Fri, 2 Feb 2024 14:57:29 +0000 Message-ID: <20240202145731.4082033-1-peter.griffin@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789799582527501135 X-GMAIL-MSGID: 1789799582527501135 Hi folks, This is a v3 of the series to add support for protected PMU registers found on gs101 and derivative SoCs. In v2 and later it was re-worked to be based on a regmap abstraction that I think leads to a much neater overall solution. The advantage of the regmap abstraction is that most leaf drivers that read/write PMU registers need minimal changes. Example of Exynos drivers that require PMU register access are: * watchdog * usb phy * mipi phy * ufs phy This series has been tested on Pixel 6 / gs101. If the various maintainers/ contributors of other Exynos SoCs like exynos850, exynosautov9, exynos5422 etc can test these patches on your respective systems that would be most appreciated! The expectation is this series would be merged via Krzysztofs Samsung Exynos tree. regards, Peter Changes since v2 - Add select REGMAP to Kconfig - Add constant for SET/CLEAR bits - Replace kerneldoc with one line comment - Fix kerneldoc for EXPORT_SYMBOL_GPL funcs - remove superflous extern keyword - dev_err_probe() on probe error - shorten regmcfg name - no compatibles inside probe, use match data - don't mix declarations with/without initializations - tensor_sec_reg_read() use mmio to avoid access restrictions - Collect up Reviewed-by - const for regmap_config structs Changes since v1: - Refactor to use custom regmap to abstract SMC register access (Sam / Guenter) - Add deferred probing support (Saravana / Krzysztof) v2 lore: https://lore.kernel.org/lkml/20240129211912.3068411-1-peter.griffin@linaro.org/ v1 lore: https://lore.kernel.org/all/20240122225710.1952066-1-peter.griffin@linaro.org/ Peter Griffin (2): soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs drivers/soc/samsung/Kconfig | 1 + drivers/soc/samsung/exynos-pmu.c | 233 ++++++++++++++++++++++++- drivers/soc/samsung/exynos-pmu.h | 1 + drivers/watchdog/Kconfig | 1 - drivers/watchdog/s3c2410_wdt.c | 8 +- include/linux/soc/samsung/exynos-pmu.h | 11 +- 6 files changed, 245 insertions(+), 10 deletions(-)