mbox series

[net-next,v6,00/15] net: ravb: Prepare for suspend to RAM and runtime PM support (part 1)

Message ID 20240202084136.3426492-1-claudiu.beznea.uj@bp.renesas.com
Headers
Series net: ravb: Prepare for suspend to RAM and runtime PM support (part 1) |

Message

claudiu beznea Feb. 2, 2024, 8:41 a.m. UTC 
  From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Hi,

This series prepares ravb driver for runtime PM support and adjust the
already existing suspend to RAM code to work for RZ/G3S (R9A08G045) SoC.

As there are IP versions that switch to module standby when disabling
the clocks, and because of module standby IP switches to reset and
the register content is lost, to be able to have runtime PM supported
for all IP variants, the configuration operations were moved all to
ravb_open()/ravb_close() letting the ravb_probe() and ravb_remove()
to deal with resource parsing and allocation/free.

The ethtool and IOCTL APIs that could have been run asyncronously
were adapted to return if the interface is down. As explained in
each individual commits description, this should be harmless.

Along with it, the series contains preparatory cleanups.

The series has been tested on the boards with the following device trees:
- r8a7742-iwg21d-q7.dts
- r8a774a1-hihope-rzg2m-ex.dts 
- r9a07g043u11-smarc-rzg2ul.dts
- r9a07g054l2-smarc-rzv2l.dts
- r9a07g044l2-smarc-rzg2l.dts

Thank you,
Claudiu Beznea

Changes in v6:
- fixed typo in patch 08/15
- re-arranged the tags as my b4 am/shazam placed the Rb tags
  before author's Sob tag
  
Changes in v5:
- collected tags
- fixed typos in patches description
- improved description for patch 07/15
- collected tags

Changes in v4:
- changed cover letter title and keep on 15 patches in series to cope
  with requirement at [1]
- add dependency on RESET_CONTROLLER in patch "net: ravb: Make reset
  controller support mandatory"
- use pm_runtime_active() in patch "net: ravb: Move the IRQs get and
  request in the probe function"
- set config more before reading the mac address in patch "net: ravb: Set
  config mode in ndo_open and reset mode in ndo_close"
- collected tags
  
[1] https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html#tl-dr

Changes in v3:
- collected tags
- addressed review comments
- squashed patch 17/21 ("net: ravb: Keep clock request operations grouped
  together") from v2 in patch 07/19 ("net: ravb: Move reference clock
  enable/disable on runtime PM APIs") from v3
- check for ndev->flags & IFF_UP in patch 17/19 and 18/19 instead of
  checking netif_running()
- dropped patch 19/21 ("net: ravb: Do not set promiscuous mode if the
  interface is down") as the changes there are not necessary as
  ndev->flags & IFF_UP is already checked at the beginning of
  __dev_set_rx_mode()
- remove code from ravb_open() introduced by patch 20/21
  ("net: ravb: Do not apply RX CSUM settings to hardware if the interface
  is down") from v2 as this is not necessary; driver already takes
  care of this in ravb_emac_init_rcar()

Changes in v2:
- rework the driver (mainly, ravb_open() contains now only resource
  allocation and parsing leaving the settings to ravb_open(); ravb_remove()
  has been adapted accordingly) to be able to use runtime PM for all
  IP variants; due to this number of patches increased
- adjust previous series to review comments
- collected tags
- populated driver's own runtime PM ops with enable/disable of reference
  clock

Claudiu Beznea (15):
  net: ravb: Let IP-specific receive function to interrogate descriptors
  net: ravb: Rely on PM domain to enable gptp_clk
  net: ravb: Make reset controller support mandatory
  net: ravb: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and
    pm_ptr()
  net: ravb: Use tabs instead of spaces
  net: ravb: Assert/de-assert reset on suspend/resume
  net: ravb: Move reference clock enable/disable on runtime PM APIs
  net: ravb: Move getting/requesting IRQs in the probe() method
  net: ravb: Split GTI computation and set operations
  net: ravb: Move delay mode set in the driver's ndo_open API
  net: ravb: Move DBAT configuration to the driver's ndo_open API
  net: ravb: Move PTP initialization in the driver's ndo_open API for
    ccc_gac platorms
  net: ravb: Set config mode in ndo_open and reset mode in ndo_close
  net: ravb: Simplify ravb_suspend()
  net: ravb: Simplify ravb_resume()

 drivers/net/ethernet/renesas/Kconfig     |   1 +
 drivers/net/ethernet/renesas/ravb.h      |   6 +-
 drivers/net/ethernet/renesas/ravb_main.c | 738 +++++++++++------------
 3 files changed, 352 insertions(+), 393 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 6, 2024, 10:20 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri,  2 Feb 2024 10:41:21 +0200 you wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Hi,
> 
> This series prepares ravb driver for runtime PM support and adjust the
> already existing suspend to RAM code to work for RZ/G3S (R9A08G045) SoC.
> 
> [...]

Here is the summary with links:
  - [net-next,v6,01/15] net: ravb: Let IP-specific receive function to interrogate descriptors
    https://git.kernel.org/netdev/net-next/c/2b993bfdb47b
  - [net-next,v6,02/15] net: ravb: Rely on PM domain to enable gptp_clk
    https://git.kernel.org/netdev/net-next/c/e1da043f2b2d
  - [net-next,v6,03/15] net: ravb: Make reset controller support mandatory
    https://git.kernel.org/netdev/net-next/c/b1768e3dc477
  - [net-next,v6,04/15] net: ravb: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr()
    https://git.kernel.org/netdev/net-next/c/6ccc22a5afcb
  - [net-next,v6,05/15] net: ravb: Use tabs instead of spaces
    https://git.kernel.org/netdev/net-next/c/7493bb4c400c
  - [net-next,v6,06/15] net: ravb: Assert/de-assert reset on suspend/resume
    https://git.kernel.org/netdev/net-next/c/c5c0714e2950
  - [net-next,v6,07/15] net: ravb: Move reference clock enable/disable on runtime PM APIs
    https://git.kernel.org/netdev/net-next/c/a654f6e875b7
  - [net-next,v6,08/15] net: ravb: Move getting/requesting IRQs in the probe() method
    https://git.kernel.org/netdev/net-next/c/32f012b8c01c
  - [net-next,v6,09/15] net: ravb: Split GTI computation and set operations
    https://git.kernel.org/netdev/net-next/c/f384ab481cab
  - [net-next,v6,10/15] net: ravb: Move delay mode set in the driver's ndo_open API
    https://git.kernel.org/netdev/net-next/c/23698a9abb62
  - [net-next,v6,11/15] net: ravb: Move DBAT configuration to the driver's ndo_open API
    https://git.kernel.org/netdev/net-next/c/cd1fb46e02de
  - [net-next,v6,12/15] net: ravb: Move PTP initialization in the driver's ndo_open API for ccc_gac platorms
    https://git.kernel.org/netdev/net-next/c/a6a85ba36fd0
  - [net-next,v6,13/15] net: ravb: Set config mode in ndo_open and reset mode in ndo_close
    https://git.kernel.org/netdev/net-next/c/76fd52c10077
  - [net-next,v6,14/15] net: ravb: Simplify ravb_suspend()
    https://git.kernel.org/netdev/net-next/c/b07bc55cbb1c
  - [net-next,v6,15/15] net: ravb: Simplify ravb_resume()
    https://git.kernel.org/netdev/net-next/c/e95273fe4d02

You are awesome, thank you!