Message ID | 20240202001733.91455-1-dharma.b@microchip.com |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-49029-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:9bc1:b0:106:209c:c626 with SMTP id op1csp112050dyc; Thu, 1 Feb 2024 16:18:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuRicjvEWi+HlrowFc3hGW0q7tp5/QNO3Q/RnrOBAewupxeyPjjOyzS8WJ6JRPUd94cS+Q X-Received: by 2002:a05:6808:10ca:b0:3be:b23a:8509 with SMTP id s10-20020a05680810ca00b003beb23a8509mr966785ois.1.1706833119644; Thu, 01 Feb 2024 16:18:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706833119; cv=pass; d=google.com; s=arc-20160816; b=iRt5DIrHg/wO4QQst8hdR5uN8AG0YyEgz1m8Ig1T685d0T3d1FLGypd5jjtcLWOmJA LEOgaq9XFlKbzDxDJtrRzCDAYaweX0BcKivmM3RQpoT4r6YWdLPV/CbSUidy7YSYsoGd oFTbwi5pZMGpexmRDOTrbEBgmknlE9/6V+ux2U8SgYssqA9/K70ofhMnQygTFHIpF0XK IvCrj2OgirBCUUdTcizbG4Tcxk5tNpSfd//9Svo71pGvrlI5pHiI/hRH+zjbetry6AVf KEdaNfhl0NhyDmxd/Icf5fi+PGNO8Lak7ZcrMi3WBy/TY/e/g1ksPm5EQ5JUgokM6GOj 2wXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=P6rOkuc1+KRWtTawGAwYSdKOtc6m4jgwE7N3ydLJXqI=; fh=IzvdG+p+6cRb4M42J1ui5pXcbLXwpJhsNDQ0RI66GKU=; b=z6Tnlqvb/cnTtlNtv3X+0ww8e84MF+CQEStlvmgLY48+vyvPfgUZUipbCQj1iykAMV XTBe/8FE0QKhv4dTozwO15bhE5s1+uFeiMtadSjOShvzlb4bZJk35v/dSNIclfqlJeKR HXwElVVHQCKjmWNl6DHQAMi1Qy8F4RxoEn78BD2ykCYrN0Hr4GNr0/P309e9jUABe852 VZwr7whaoZeVoX5aeRuO2cfLGOqXEP7bggocGdeZI5gxvu5o/vJLH8ObFpzcaCN5yu9x cAXITOED3Nv+l52Cf8gq3oC5OPRZMJoq4NljdRLQYi8+KEZw4+XEwTUYMySVk8jZKALH ZBbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=KkQWEYMw; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-49029-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49029-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com X-Forwarded-Encrypted: i=1; AJvYcCUh697naj466XTUC+SEYv6NLnQ4XWL2E7dWJ6TDhZzweiR5cKXfhpzPuaeutZTnJbda3jwHnEIOz3lU4PYX05T+2oD98A== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t22-20020a05622a149600b0042bfc2b2ea3si732721qtx.543.2024.02.01.16.18.39 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 16:18:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-49029-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=KkQWEYMw; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-49029-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-49029-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6DC181C23DB3 for <ouuuleilei@gmail.com>; Fri, 2 Feb 2024 00:18:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0AC11872; Fri, 2 Feb 2024 00:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="KkQWEYMw" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EAC97E9; Fri, 2 Feb 2024 00:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706833101; cv=none; b=ZhsUhMrjtizB/fBxMoSb/czm1PEZcBkSE8OthbdjZhaI/l52FJydDI5ZLE2fUVOKTcnu86Fk0BqAsBp96qbPUQPiEKH5/JEKH8sYKFpvx0geC9fp9UdwAH7aGfXzKieQd3dBar9eNtcCb12shSRdEjNGWdZo1DipGCu73Piluuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706833101; c=relaxed/simple; bh=6lCpe1JWBv0gIutmOVn15+H+ejUjuih0/bmRqdymfH0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=h2sCnjKAYOoMSnmIJt2dqj1HWFNTxYsmDtzZ/CautBDmxMU40cPXmKJJFI6uBOYaUXbjEnPq92HEqrGijnrMU4cMXyraztd2qDWVc5dLbeS4e9GGSuthk6OtZSPDOsJi0mSdWG9Ps7tXEMKQQUVvfr45iOEeL84kRO8GRdph238= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=KkQWEYMw; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1706833099; x=1738369099; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6lCpe1JWBv0gIutmOVn15+H+ejUjuih0/bmRqdymfH0=; b=KkQWEYMwJZTDr8dc/K+oE0lrlSLa2x22T49eBxn/3roWFr9+SUB99qok 5ne2eQeIbm2yL2WQXP6lieMWIoTbVr8IONhNMjPZdSlhJMFkNlxyQK9iJ uYOwOcTDBvlAPfaFPdhfSz+WzOhyJgQUIIbWU/o+QqfdOHLoJjLH9aKBf urQODbmxIGmTrCLDAw9+5cNpzs7V2woe33eM/liVEW23C+XIppy61ebKs APsWdpVAXKEKse9WyX2NNU8VjZkAhyOFzhHLpTmgdj7YOPvf6hHsuFISF cOAZ5T1DCPaT687J0dwy6XsDQH8tZwEkCqMFn52912LNEDhdducdX0YbY Q==; X-CSE-ConnectionGUID: q2aqr2bnSse6ZnRLstrm9A== X-CSE-MsgGUID: ZMDnp1A7QAq47c0BW+chNg== X-IronPort-AV: E=Sophos;i="6.05,236,1701154800"; d="scan'208";a="15650200" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2024 17:18:18 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 17:17:45 -0700 Received: from che-lt-i70843lx.amer.actel.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 1 Feb 2024 17:17:37 -0700 From: Dharma Balasubiramani <dharma.b@microchip.com> To: <sam@ravnborg.org>, <bbrezillon@kernel.org>, <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <claudiu.beznea@tuxon.dev>, <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <lee@kernel.org>, <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>, <linux-pwm@vger.kernel.org> CC: <hari.prasathge@microchip.com>, <manikandan.m@microchip.com>, "Dharma Balasubiramani" <dharma.b@microchip.com> Subject: [linux][PATCH v6 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema Date: Fri, 2 Feb 2024 05:47:30 +0530 Message-ID: <20240202001733.91455-1-dharma.b@microchip.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789575465594702596 X-GMAIL-MSGID: 1789744245100512118 |
Series |
Convert Microchip's HLCDC Text based DT bindings to JSON schema
|
|
Message
Dharma Balasubiramani
Feb. 2, 2024, 12:17 a.m. UTC
Converted the text bindings to YAML and validated them individually using following commands $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ changelogs are available in respective patches. Dharma Balasubiramani (3): dt-bindings: display: convert Atmel's HLCDC to DT schema dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format .../atmel/atmel,hlcdc-display-controller.yaml | 63 ++++++++++++ .../bindings/display/atmel/hlcdc-dc.txt | 75 -------------- .../devicetree/bindings/mfd/atmel,hlcdc.yaml | 99 +++++++++++++++++++ .../devicetree/bindings/mfd/atmel-hlcdc.txt | 56 ----------- .../bindings/pwm/atmel,hlcdc-pwm.yaml | 35 +++++++ .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------ 6 files changed, 197 insertions(+), 160 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt
Comments
On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. This > alignment with the specific hardware requirements ensures accurate device tree > configuration for systems utilizing the HLCDC IP. > > [...] Applied, thanks! [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format commit: cb946db1335b599ece363d33966bf653ed0fa58a -- Lee Jones [李琼斯]
On 08/02/2024 11:43, Lee Jones wrote: > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >> Convert the atmel,hlcdc binding to DT schema format. >> >> Align clocks and clock-names properties to clearly indicate that the LCD >> controller expects lvds_pll_clk when interfaced with the lvds display. This >> alignment with the specific hardware requirements ensures accurate device tree >> configuration for systems utilizing the HLCDC IP. >> >> [...] > > Applied, thanks! > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > commit: cb946db1335b599ece363d33966bf653ed0fa58a > Next is still failing. Dharma, You must explain and clearly mark dependencies between patches. Lee, Can you pick up two previous patches as well? Best regards, Krzysztof
On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: > On 08/02/2024 11:43, Lee Jones wrote: > > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > >> Convert the atmel,hlcdc binding to DT schema format. > >> > >> Align clocks and clock-names properties to clearly indicate that the LCD > >> controller expects lvds_pll_clk when interfaced with the lvds display. This > >> alignment with the specific hardware requirements ensures accurate device tree > >> configuration for systems utilizing the HLCDC IP. > >> > >> [...] > > > > Applied, thanks! > > > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > commit: cb946db1335b599ece363d33966bf653ed0fa58a > > > > Next is still failing. Failing in the sense of dtbs_check, right? > Dharma, > You must explain and clearly mark dependencies between patches. > > Lee, > Can you pick up two previous patches as well? I applied the pwm patch now. If Lee wants to pick up this one via his tree that would be fine for me, too. If that's the case please tell me, then I'll drop it from my for-next branch again. Feel free to add my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch #2 then. Best regards Uwe
On 15/02/2024 11:02, Uwe Kleine-König wrote: > On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: >> On 08/02/2024 11:43, Lee Jones wrote: >>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >>>> Convert the atmel,hlcdc binding to DT schema format. >>>> >>>> Align clocks and clock-names properties to clearly indicate that the LCD >>>> controller expects lvds_pll_clk when interfaced with the lvds display. This >>>> alignment with the specific hardware requirements ensures accurate device tree >>>> configuration for systems utilizing the HLCDC IP. >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >>> commit: cb946db1335b599ece363d33966bf653ed0fa58a >>> >> >> Next is still failing. > > Failing in the sense of dtbs_check, right? No, bindings were failing. dt_binding_check. This must not fail, so kind of bummer... > >> Dharma, >> You must explain and clearly mark dependencies between patches. >> >> Lee, >> Can you pick up two previous patches as well? > > I applied the pwm patch now. If Lee wants to pick up this one via his > tree that would be fine for me, too. If that's the case please tell me, > then I'll drop it from my for-next branch again. Feel free to add > my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch > #2 then. At least next is happy. > Best regards, Krzysztof
Hello Krzysztof, On Thu, Feb 15, 2024 at 07:44:53PM +0100, Krzysztof Kozlowski wrote: > On 15/02/2024 11:02, Uwe Kleine-König wrote: > > On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: > >> On 08/02/2024 11:43, Lee Jones wrote: > >>> Applied, thanks! > >>> > >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > >>> commit: cb946db1335b599ece363d33966bf653ed0fa58a > >>> > >> > >> Next is still failing. > > > > Failing in the sense of dtbs_check, right? > > No, bindings were failing. dt_binding_check. This must not fail, so kind > of bummer... > > >> Dharma, > >> You must explain and clearly mark dependencies between patches. > >> > >> Lee, > >> Can you pick up two previous patches as well? > > > > I applied the pwm patch now. If Lee wants to pick up this one via his > > tree that would be fine for me, too. If that's the case please tell me, > > then I'll drop it from my for-next branch again. Feel free to add > > my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch > > #2 then. > > At least next is happy. The pwm binding is in next now (as 0fa319a1427f7c8d0af4c255316624f7e6f649a0) but dt_binding_check still tells me (among others): Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml This is what you meant, right? This goes away as soon as the first patch (dt-bindings: display: convert Atmel's HLCDC to DT schema) is applied, too. So next isn't completely happy yet. Best regards Uwe
On 16/02/2024 09:43, Uwe Kleine-König wrote: >>> I applied the pwm patch now. If Lee wants to pick up this one via his >>> tree that would be fine for me, too. If that's the case please tell me, >>> then I'll drop it from my for-next branch again. Feel free to add >>> my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch >>> #2 then. >> >> At least next is happy. > > The pwm binding is in next now (as > 0fa319a1427f7c8d0af4c255316624f7e6f649a0) but dt_binding_check still > tells me (among others): > > Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml: > Error in referenced schema matching $id: http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml > > This is what you meant, right? This goes away as soon as the first patch Yeah, apparently there was more than one dependency. > (dt-bindings: display: convert Atmel's HLCDC to DT schema) is applied, > too. So next isn't completely happy yet. Sigh... Best regards, Krzysztof
Hi Krzysztof, On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 08/02/2024 11:43, Lee Jones wrote: >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >>> Convert the atmel,hlcdc binding to DT schema format. >>> >>> Align clocks and clock-names properties to clearly indicate that the LCD >>> controller expects lvds_pll_clk when interfaced with the lvds display. This >>> alignment with the specific hardware requirements ensures accurate device tree >>> configuration for systems utilizing the HLCDC IP. >>> >>> [...] >> >> Applied, thanks! >> >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >> commit: cb946db1335b599ece363d33966bf653ed0fa58a >> > > Next is still failing. > > Dharma, > You must explain and clearly mark dependencies between patches. I sincerely apologize for any confusion caused by the oversight. I have organized the patches according to their dependencies in the patch series, but unfortunately, I neglected to explicitly mention these dependencies. I understand the importance of clear communication in our collaborative efforts. Please feel free to provide guidance on how I can assist you further in resolving this matter. > > Lee, > Can you pick up two previous patches as well? > > Best regards, > Krzysztof > -- With Best Regards, Dharma B.
On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > Hi Krzysztof, > > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On 08/02/2024 11:43, Lee Jones wrote: > >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > >>> Convert the atmel,hlcdc binding to DT schema format. > >>> > >>> Align clocks and clock-names properties to clearly indicate that the LCD > >>> controller expects lvds_pll_clk when interfaced with the lvds display. This > >>> alignment with the specific hardware requirements ensures accurate device tree > >>> configuration for systems utilizing the HLCDC IP. > >>> > >>> [...] > >> > >> Applied, thanks! > >> > >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > >> commit: cb946db1335b599ece363d33966bf653ed0fa58a > >> > > > > Next is still failing. > > > > Dharma, > > You must explain and clearly mark dependencies between patches. > > I sincerely apologize for any confusion caused by the oversight. I have > organized the patches according to their dependencies in the patch > series, but unfortunately, I neglected to explicitly mention these > dependencies. I understand the importance of clear communication in our > collaborative efforts. Please feel free to provide guidance on how I can > assist you further in resolving this matter. If this continues to be an issue, I can just remove the commit.
Hi Lee, On 20/02/24 1:50 pm, Lee Jones wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > >> Hi Krzysztof, >> >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On 08/02/2024 11:43, Lee Jones wrote: >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >>>>> Convert the atmel,hlcdc binding to DT schema format. >>>>> >>>>> Align clocks and clock-names properties to clearly indicate that the LCD >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This >>>>> alignment with the specific hardware requirements ensures accurate device tree >>>>> configuration for systems utilizing the HLCDC IP. >>>>> >>>>> [...] >>>> >>>> Applied, thanks! >>>> >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >>>> commit: cb946db1335b599ece363d33966bf653ed0fa58a >>>> >>> >>> Next is still failing. >>> >>> Dharma, >>> You must explain and clearly mark dependencies between patches. >> >> I sincerely apologize for any confusion caused by the oversight. I have >> organized the patches according to their dependencies in the patch >> series, but unfortunately, I neglected to explicitly mention these >> dependencies. I understand the importance of clear communication in our >> collaborative efforts. Please feel free to provide guidance on how I can >> assist you further in resolving this matter. > > If this continues to be an issue, I can just remove the commit. There won't be any issue if both pwm and display binding goes before the mfd binding. Could you please pick the display binding as well? > > -- > Lee Jones [李琼斯] -- With Best Regards, Dharma B.
Hello, On Tue, Feb 20, 2024 at 08:20:26AM +0000, Lee Jones wrote: > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > > On 08/02/2024 11:43, Lee Jones wrote: > > >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > > >>> Convert the atmel,hlcdc binding to DT schema format. > > >>> > > >>> Align clocks and clock-names properties to clearly indicate that the LCD > > >>> controller expects lvds_pll_clk when interfaced with the lvds display. This > > >>> alignment with the specific hardware requirements ensures accurate device tree > > >>> configuration for systems utilizing the HLCDC IP. > > >>> > > >>> [...] > > >> > > >> Applied, thanks! > > >> > > >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > >> commit: cb946db1335b599ece363d33966bf653ed0fa58a > > >> > > > > > > Next is still failing. > > If this continues to be an issue, I can just remove the commit. The missing part in next is that patch 1 isn't included. So the options are: a) Someone (dri or dt folks?) merges patch 1 This fixes the state in next, though some commits stay around that fail dt_binding_check b) Someone (mfd or dt?) merges all 3 patches in one go and the two patches already applied are dropped. This makes dt_binding_check happy for all revs. For me a) is good enough, but I guess the dri people are not aware there is something to do for them?! Would be nice if Sam or Boris commented. Best regards Uwe
On 20/02/2024 04:34, Dharma.B@microchip.com wrote: > Hi Krzysztof, > > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 08/02/2024 11:43, Lee Jones wrote: >>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >>>> Convert the atmel,hlcdc binding to DT schema format. >>>> >>>> Align clocks and clock-names properties to clearly indicate that the LCD >>>> controller expects lvds_pll_clk when interfaced with the lvds display. This >>>> alignment with the specific hardware requirements ensures accurate device tree >>>> configuration for systems utilizing the HLCDC IP. >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >>> commit: cb946db1335b599ece363d33966bf653ed0fa58a >>> >> >> Next is still failing. >> >> Dharma, >> You must explain and clearly mark dependencies between patches. > > I sincerely apologize for any confusion caused by the oversight. I have > organized the patches according to their dependencies in the patch Does it mean that all your other patchsets which contain multiple patches have dependencies? That would be the meaning of above approach. Unfortunately that's not good... I'll comment in other places for individual issues. Best regards, Krzysztof
On Tue, Feb 20, 2024 at 08:30:38AM +0000, Dharma.B@microchip.com wrote: > Hi Lee, > > On 20/02/24 1:50 pm, Lee Jones wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > > > >> Hi Krzysztof, > >> > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> > >>> On 08/02/2024 11:43, Lee Jones wrote: > >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > >>>>> Convert the atmel,hlcdc binding to DT schema format. > >>>>> > >>>>> Align clocks and clock-names properties to clearly indicate that the LCD > >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This > >>>>> alignment with the specific hardware requirements ensures accurate device tree > >>>>> configuration for systems utilizing the HLCDC IP. > >>>>> > >>>>> [...] > >>>> > >>>> Applied, thanks! > >>>> > >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > >>>> commit: cb946db1335b599ece363d33966bf653ed0fa58a > >>>> > >>> > >>> Next is still failing. > >>> > >>> Dharma, > >>> You must explain and clearly mark dependencies between patches. > >> > >> I sincerely apologize for any confusion caused by the oversight. I have > >> organized the patches according to their dependencies in the patch > >> series, but unfortunately, I neglected to explicitly mention these > >> dependencies. I understand the importance of clear communication in our > >> collaborative efforts. Please feel free to provide guidance on how I can > >> assist you further in resolving this matter. > > > > If this continues to be an issue, I can just remove the commit. > > There won't be any issue if both pwm and display binding goes before the > mfd binding. > > Could you please pick the display binding as well? As this is still not resolved, I've applied the display binding. Not ideal, but should fix next. Rob
On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > Hi Lee, > > On 20/02/24 1:50 pm, Lee Jones wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > > > >> Hi Krzysztof, > >> > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> > >>> On 08/02/2024 11:43, Lee Jones wrote: > >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > >>>>> Convert the atmel,hlcdc binding to DT schema format. > >>>>> > >>>>> Align clocks and clock-names properties to clearly indicate that the LCD > >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This > >>>>> alignment with the specific hardware requirements ensures accurate device tree > >>>>> configuration for systems utilizing the HLCDC IP. > >>>>> > >>>>> [...] > >>>> > >>>> Applied, thanks! > >>>> > >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > >>>> commit: cb946db1335b599ece363d33966bf653ed0fa58a > >>>> > >>> > >>> Next is still failing. > >>> > >>> Dharma, > >>> You must explain and clearly mark dependencies between patches. > >> > >> I sincerely apologize for any confusion caused by the oversight. I have > >> organized the patches according to their dependencies in the patch > >> series, but unfortunately, I neglected to explicitly mention these > >> dependencies. I understand the importance of clear communication in our > >> collaborative efforts. Please feel free to provide guidance on how I can > >> assist you further in resolving this matter. > > > > If this continues to be an issue, I can just remove the commit. > > There won't be any issue if both pwm and display binding goes before the > mfd binding. > > Could you please pick the display binding as well? Only with an ACK from the relevant Maintainers.
On Thu, 22 Feb 2024, Rob Herring wrote: > On Tue, Feb 20, 2024 at 08:30:38AM +0000, Dharma.B@microchip.com wrote: > > Hi Lee, > > > > On 20/02/24 1:50 pm, Lee Jones wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > > > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote: > > > > > >> Hi Krzysztof, > > >> > > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > >>> > > >>> On 08/02/2024 11:43, Lee Jones wrote: > > >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > > >>>>> Convert the atmel,hlcdc binding to DT schema format. > > >>>>> > > >>>>> Align clocks and clock-names properties to clearly indicate that the LCD > > >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This > > >>>>> alignment with the specific hardware requirements ensures accurate device tree > > >>>>> configuration for systems utilizing the HLCDC IP. > > >>>>> > > >>>>> [...] > > >>>> > > >>>> Applied, thanks! > > >>>> > > >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > >>>> commit: cb946db1335b599ece363d33966bf653ed0fa58a > > >>>> > > >>> > > >>> Next is still failing. > > >>> > > >>> Dharma, > > >>> You must explain and clearly mark dependencies between patches. > > >> > > >> I sincerely apologize for any confusion caused by the oversight. I have > > >> organized the patches according to their dependencies in the patch > > >> series, but unfortunately, I neglected to explicitly mention these > > >> dependencies. I understand the importance of clear communication in our > > >> collaborative efforts. Please feel free to provide guidance on how I can > > >> assist you further in resolving this matter. > > > > > > If this continues to be an issue, I can just remove the commit. > > > > There won't be any issue if both pwm and display binding goes before the > > mfd binding. > > > > Could you please pick the display binding as well? > > As this is still not resolved, I've applied the display binding. Not > ideal, but should fix next. Works for me.