mbox series

[v2,0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c

Message ID 20240201140459.438479-1-meir6264@Gmail.com
Headers
Series Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c |

Message

meir elisha Feb. 1, 2024, 2:04 p.m. UTC 
  Checkpatch fix series for rtw_mlme.c

---
Changes in v2:
 - Remove dead code
 - Fix comment in _rtw_join_timeout_handler()

Meir Elisha (4):
  Staging: rtl8723bs: Remove unnecessary braces
  Staging: rtl8723bs: Remove extra spaces
  Staging: rtl8723bs: Fix block comments warning
  Staging: rtl8723bs: fix else after break warning

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 227 ++++++++--------------
 1 file changed, 81 insertions(+), 146 deletions(-)

Comments

Philipp Hortmann Feb. 1, 2024, 9:26 p.m. UTC | #1 
On 2/1/24 15:04, Meir Elisha wrote:
> Checkpatch fix series for rtw_mlme.c
> 
> ---
> Changes in v2:
>   - Remove dead code
>   - Fix comment in _rtw_join_timeout_handler()
> 
> Meir Elisha (4):
>    Staging: rtl8723bs: Remove unnecessary braces
>    Staging: rtl8723bs: Remove extra spaces
>    Staging: rtl8723bs: Fix block comments warning
>    Staging: rtl8723bs: fix else after break warning
> 
>   drivers/staging/rtl8723bs/core/rtw_mlme.c | 227 ++++++++--------------
>   1 file changed, 81 insertions(+), 146 deletions(-)
> 

Hi Meir,

please keep the emailaddess send from and the Signed-off-by emailaddress 
exactly the same. The difference is the
"G" of gmail. One time it is upper case and one time lower case.

The changelog for the coverletter is good but the changelog for each 
patch is missing. There the "---" are missing with chagelog.

Please use more unique descriptions for your patches. "Remove extra 
spaces" can be an issue for hundred of times in a driver.
Look into accepted patches of the git for better examples.

I think the maintainer will not like your patch description. He will 
typically respond with:

- You did not specify a description of why the patch is needed, or
   possibly, any description at all, in the email body.  Please read the
   section entitled "The canonical patch format" in the kernel file,
   Documentation/process/submitting-patches.rst for what is needed in
   order to properly describe the change.

Very important here is the why and not to describe what you did.
Look into accepted patches of the git for better examples.

Thanks for your support.

Bye Philipp