mbox series

[v2,0/4] Add 8qm SMMU information

Message ID 20240201-8qm_smmu-v2-0-3d12a80201a3@nxp.com
Headers
Series Add 8qm SMMU information |

Message

Frank Li Feb. 1, 2024, 8:22 p.m. UTC 
  Change at v2
- Remove iM95 for fec.

To: Ulf Hansson <ulf.hansson@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Shawn Guo <shawnguo@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
To: Pengutronix Kernel Team <kernel@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
To: NXP Linux Team <linux-imx@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
To: Shenwei Wang <shenwei.wang@nxp.com>
To: Clark Wang <xiaoning.wang@nxp.com>
To: David S. Miller <davem@davemloft.net>
To: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: linux-mmc@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: imx@lists.linux.dev

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (4):
      dt-bindings: mmc: fsl-imx-esdhc: add iommus property
      dt-bindings: net: fec: add iommus property
      arm64: dts: imx8qm: add smmu node
      arm64: dts: imx8qm: add smmu stream id information

 .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml     |  3 ++
 Documentation/devicetree/bindings/net/fsl,fec.yaml |  3 ++
 arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi  |  6 ++++
 arch/arm64/boot/dts/freescale/imx8qm.dtsi          | 41 ++++++++++++++++++++++
 4 files changed, 53 insertions(+)
---
base-commit: 99748ff5ee0953610765e9d0cd6015c2eb0f7ace
change-id: 20240201-8qm_smmu-6318da8e9017

Best regards,

Comments

Jakub Kicinski Feb. 2, 2024, 7:05 p.m. UTC | #1 
On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
>       dt-bindings: mmc: fsl-imx-esdhc: add iommus property
>       dt-bindings: net: fec: add iommus property
>       arm64: dts: imx8qm: add smmu node
>       arm64: dts: imx8qm: add smmu stream id information
> 
>  .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml     |  3 ++
>  Documentation/devicetree/bindings/net/fsl,fec.yaml |  3 ++
>  arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi  |  6 ++++
>  arch/arm64/boot/dts/freescale/imx8qm.dtsi          | 41 ++++++++++++++++++++++

Any preference on whether all these go via a platform tree,
or should we pick up the net patch to netdev? I guess taking
the DTB via netdev would be the usual way to handle this?
Frank Li Feb. 2, 2024, 10:28 p.m. UTC | #2 
On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> >       dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> >       dt-bindings: net: fec: add iommus property
> >       arm64: dts: imx8qm: add smmu node
> >       arm64: dts: imx8qm: add smmu stream id information
> > 
> >  .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml     |  3 ++
> >  Documentation/devicetree/bindings/net/fsl,fec.yaml |  3 ++
> >  arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi  |  6 ++++
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi          | 41 ++++++++++++++++++++++
> 
> Any preference on whether all these go via a platform tree,
> or should we pick up the net patch to netdev? I guess taking
> the DTB via netdev would be the usual way to handle this?

Supposed dt-bindings go through netdev tree.

without dt-bindings, just DTB_CHECK warning. No strict dependence
relationship between dt-bindings doc and dts file. 

Frank
Krzysztof Kozlowski Feb. 5, 2024, 9:25 a.m. UTC | #3 
On 02/02/2024 23:28, Frank Li wrote:
> On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
>> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
>>>       dt-bindings: mmc: fsl-imx-esdhc: add iommus property
>>>       dt-bindings: net: fec: add iommus property
>>>       arm64: dts: imx8qm: add smmu node
>>>       arm64: dts: imx8qm: add smmu stream id information
>>>
>>>  .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml     |  3 ++
>>>  Documentation/devicetree/bindings/net/fsl,fec.yaml |  3 ++
>>>  arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi  |  6 ++++
>>>  arch/arm64/boot/dts/freescale/imx8qm.dtsi          | 41 ++++++++++++++++++++++
>>
>> Any preference on whether all these go via a platform tree,
>> or should we pick up the net patch to netdev? I guess taking
>> the DTB via netdev would be the usual way to handle this?
> 
> Supposed dt-bindings go through netdev tree.
> 
> without dt-bindings, just DTB_CHECK warning. No strict dependence
> relationship between dt-bindings doc and dts file. 

Please make it easier for maintainers and sent entirely independent
patches for different subsystems in SEPARATE patchsets.

There is no dependency here between anything. Combining it, OTOH, brings
the questions about such dependency and makes it a bit more difficult to
apply for each maintainer.

Best regards,
Krzysztof
Frank Li Feb. 5, 2024, 7:55 p.m. UTC | #4 
On Mon, Feb 05, 2024 at 10:25:46AM +0100, Krzysztof Kozlowski wrote:
> On 02/02/2024 23:28, Frank Li wrote:
> > On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
> >> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> >>>       dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> >>>       dt-bindings: net: fec: add iommus property
> >>>       arm64: dts: imx8qm: add smmu node
> >>>       arm64: dts: imx8qm: add smmu stream id information
> >>>
> >>>  .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml     |  3 ++
> >>>  Documentation/devicetree/bindings/net/fsl,fec.yaml |  3 ++
> >>>  arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi  |  6 ++++
> >>>  arch/arm64/boot/dts/freescale/imx8qm.dtsi          | 41 ++++++++++++++++++++++
> >>
> >> Any preference on whether all these go via a platform tree,
> >> or should we pick up the net patch to netdev? I guess taking
> >> the DTB via netdev would be the usual way to handle this?
> > 
> > Supposed dt-bindings go through netdev tree.
> > 
> > without dt-bindings, just DTB_CHECK warning. No strict dependence
> > relationship between dt-bindings doc and dts file. 
> 
> Please make it easier for maintainers and sent entirely independent
> patches for different subsystems in SEPARATE patchsets.
> 
> There is no dependency here between anything. Combining it, OTOH, brings
> the questions about such dependency and makes it a bit more difficult to
> apply for each maintainer.

Understand, but without dts change, it is not easy to understand why need
change dt-binding files.

Frank

> 
> Best regards,
> Krzysztof
>
Shawn Guo Feb. 6, 2024, 10:50 a.m. UTC | #5 
On Fri, Feb 02, 2024 at 11:05:11AM -0800, Jakub Kicinski wrote:
> On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
> >       dt-bindings: mmc: fsl-imx-esdhc: add iommus property
> >       dt-bindings: net: fec: add iommus property
> >       arm64: dts: imx8qm: add smmu node
> >       arm64: dts: imx8qm: add smmu stream id information
> > 
> >  .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml     |  3 ++
> >  Documentation/devicetree/bindings/net/fsl,fec.yaml |  3 ++
> >  arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi  |  6 ++++
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi          | 41 ++++++++++++++++++++++
> 
> Any preference on whether all these go via a platform tree,
> or should we pick up the net patch to netdev? I guess taking
> the DTB via netdev would be the usual way to handle this?

No, it's not.  Taking DTS changes through arch/platform tree is the
usual way.

Shawn
Jakub Kicinski Feb. 6, 2024, 3:41 p.m. UTC | #6 
On Tue, 6 Feb 2024 18:50:51 +0800 Shawn Guo wrote:
> > Any preference on whether all these go via a platform tree,
> > or should we pick up the net patch to netdev? I guess taking
> > the DTB via netdev would be the usual way to handle this?  
> 
> No, it's not.  Taking DTS changes through arch/platform tree is the
> usual way.

I said DTB.
patchwork-bot+netdevbpf@kernel.org Feb. 19, 2024, 7:50 p.m. UTC | #7 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 01 Feb 2024 15:22:40 -0500 you wrote:
> Change at v2
> - Remove iM95 for fec.
> 
> To: Ulf Hansson <ulf.hansson@linaro.org>
> To: Rob Herring <robh+dt@kernel.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Shawn Guo <shawnguo@kernel.org>
> To: Sascha Hauer <s.hauer@pengutronix.de>
> To: Pengutronix Kernel Team <kernel@pengutronix.de>
> To: Fabio Estevam <festevam@gmail.com>
> To: NXP Linux Team <linux-imx@nxp.com>
> To: Wei Fang <wei.fang@nxp.com>
> To: Shenwei Wang <shenwei.wang@nxp.com>
> To: Clark Wang <xiaoning.wang@nxp.com>
> To: David S. Miller <davem@davemloft.net>
> To: Eric Dumazet <edumazet@google.com>
> To: Jakub Kicinski <kuba@kernel.org>
> To: Paolo Abeni <pabeni@redhat.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: imx@lists.linux.dev
> 
> [...]

Here is the summary with links:
  - [v2,1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property
    (no matching commit)
  - [v2,2/4] dt-bindings: net: fec: add iommus property
    https://git.kernel.org/netdev/net-next/c/5983e5df8630
  - [v2,3/4] arm64: dts: imx8qm: add smmu node
    (no matching commit)
  - [v2,4/4] arm64: dts: imx8qm: add smmu stream id information
    (no matching commit)

You are awesome, thank you!
Shawn Guo Feb. 23, 2024, 2:07 a.m. UTC | #8 
On Tue, Feb 06, 2024 at 07:41:51AM -0800, Jakub Kicinski wrote:
> On Tue, 6 Feb 2024 18:50:51 +0800 Shawn Guo wrote:
> > > Any preference on whether all these go via a platform tree,
> > > or should we pick up the net patch to netdev? I guess taking
> > > the DTB via netdev would be the usual way to handle this?  
> > 
> > No, it's not.  Taking DTS changes through arch/platform tree is the
> > usual way.
> 
> I said DTB.

If the DTB here means Device Tree Blob which is generated by DTC (Device
Tree Compiler) taking DTS (Device Tree Source) as input, it's a build
result and so neither of us could take.

Shawn
Jakub Kicinski Feb. 23, 2024, 2:26 a.m. UTC | #9 
On Fri, 23 Feb 2024 10:07:39 +0800 Shawn Guo wrote:
> On Tue, Feb 06, 2024 at 07:41:51AM -0800, Jakub Kicinski wrote:
> > I said DTB.  
> 
> If the DTB here means Device Tree Blob which is generated by DTC (Device
> Tree Compiler) taking DTS (Device Tree Source) as input, it's a build
> result and so neither of us could take.

I see, thanks for the explainer, I was referring to DeviceTree/Bindings.
I'll say binding next time.