mbox series

[v2,0/2] Dynamically allocate BPIDs for LBK

Message ID 20240131075441.17227-1-gakula@marvell.com
Headers
Series Dynamically allocate BPIDs for LBK |

Message

Geetha sowjanya Jan. 31, 2024, 7:54 a.m. UTC 
  In current driver 64 BPIDs are reserved for LBK interfaces.
These bpids are 1-to-1 mapped to LBK interface channel numbers.
In some usecases one LBK interface required more than one bpids
and in some case they may not require at all. These usescas
can't be address with the current implementation as it always
reserves only one bpid per LBK channel. 

This patch addresses this issue by creating free bpid pool from
these 64 bpids instead of 1-to-1 mapping to the lbk channel.
Now based on usecase LBK interface can request a bpid using (bp_enable()).


v1 -> v2:
   - Modified commit message.
   - Dropped patch2, as for now rvu netdev have no usecase. Will
     be upstream along with the CPT driver.
   - Addressed review comments by Simon Horman. 

Geetha sowjanya (2):
  octeontx2-af: Create BPIDs free pool
  octeontx2-af: Cleanup loopback device checks

 .../net/ethernet/marvell/octeontx2/af/mbox.h  |   2 +
 .../net/ethernet/marvell/octeontx2/af/rvu.c   |  14 +-
 .../net/ethernet/marvell/octeontx2/af/rvu.h   |  21 +-
 .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 179 ++++++++++++++----
 .../ethernet/marvell/octeontx2/af/rvu_npc.c   |   8 +-
 .../ethernet/marvell/octeontx2/af/rvu_reg.h   |   3 +
 .../ethernet/marvell/octeontx2/af/rvu_sdp.c   |   6 +-
 7 files changed, 181 insertions(+), 52 deletions(-)

Comments

Jiri Pirko Jan. 31, 2024, 9:52 a.m. UTC | #1 
Wed, Jan 31, 2024 at 08:54:39AM CET, gakula@marvell.com wrote:
>In current driver 64 BPIDs are reserved for LBK interfaces.
>These bpids are 1-to-1 mapped to LBK interface channel numbers.
>In some usecases one LBK interface required more than one bpids
>and in some case they may not require at all. These usescas
>can't be address with the current implementation as it always
>reserves only one bpid per LBK channel. 
>
>This patch addresses this issue by creating free bpid pool from
>these 64 bpids instead of 1-to-1 mapping to the lbk channel.
>Now based on usecase LBK interface can request a bpid using (bp_enable()).
>
>
>v1 -> v2:
>   - Modified commit message.
>   - Dropped patch2, as for now rvu netdev have no usecase. Will
>     be upstream along with the CPT driver.
>   - Addressed review comments by Simon Horman. 
>
>Geetha sowjanya (2):
>  octeontx2-af: Create BPIDs free pool
>  octeontx2-af: Cleanup loopback device checks
>
> .../net/ethernet/marvell/octeontx2/af/mbox.h  |   2 +
> .../net/ethernet/marvell/octeontx2/af/rvu.c   |  14 +-
> .../net/ethernet/marvell/octeontx2/af/rvu.h   |  21 +-
> .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 179 ++++++++++++++----
> .../ethernet/marvell/octeontx2/af/rvu_npc.c   |   8 +-
> .../ethernet/marvell/octeontx2/af/rvu_reg.h   |   3 +
> .../ethernet/marvell/octeontx2/af/rvu_sdp.c   |   6 +-
> 7 files changed, 181 insertions(+), 52 deletions(-)

FWIW: I don't see anything problematic in this patchset. From that
perspective:
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
patchwork-bot+netdevbpf@kernel.org Feb. 2, 2024, 12:20 p.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 31 Jan 2024 13:24:39 +0530 you wrote:
> In current driver 64 BPIDs are reserved for LBK interfaces.
> These bpids are 1-to-1 mapped to LBK interface channel numbers.
> In some usecases one LBK interface required more than one bpids
> and in some case they may not require at all. These usescas
> can't be address with the current implementation as it always
> reserves only one bpid per LBK channel.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] octeontx2-af: Create BPIDs free pool
    https://git.kernel.org/netdev/net-next/c/d6212d2e41a0
  - [net-next,v2,2/2] octeontx2-af: Cleanup loopback device checks
    https://git.kernel.org/netdev/net-next/c/ae703539f49d

You are awesome, thank you!