mbox series

[linux,v5,0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

Message ID 20240131033523.577450-1-dharma.b@microchip.com
Headers
Series Convert Microchip's HLCDC Text based DT bindings to JSON schema |

Message

Dharma Balasubiramani Jan. 31, 2024, 3:35 a.m. UTC 
  Converted the text bindings to YAML and validated them individually using following commands

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/

changelogs are available in respective patches.

As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
will be sent as separate patch.

Dharma Balasubiramani (3):
  dt-bindings: display: convert Atmel's HLCDC to DT schema
  dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema
  dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

 .../atmel/atmel,hlcdc-display-controller.yaml | 85 ++++++++++++++++
 .../bindings/display/atmel/hlcdc-dc.txt       | 75 --------------
 .../devicetree/bindings/mfd/atmel,hlcdc.yaml  | 99 +++++++++++++++++++
 .../devicetree/bindings/mfd/atmel-hlcdc.txt   | 56 -----------
 .../bindings/pwm/atmel,hlcdc-pwm.yaml         | 44 +++++++++
 .../bindings/pwm/atmel-hlcdc-pwm.txt          | 29 ------
 6 files changed, 228 insertions(+), 160 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
 delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt

Comments

Conor Dooley Jan. 31, 2024, 4:57 p.m. UTC | #1 
On Wed, Jan 31, 2024 at 09:05:23AM +0530, Dharma Balasubiramani wrote:
> Convert the atmel,hlcdc binding to DT schema format.
> 
> Align clocks and clock-names properties to clearly indicate that the LCD
> controller expects lvds_pll_clk when interfaced with the lvds display. This
> alignment with the specific hardware requirements ensures accurate device tree
> configuration for systems utilizing the HLCDC IP.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Dharma Balasubiramani Feb. 1, 2024, 3:38 a.m. UTC | #2 
Hi Rob,

On 31/01/24 9:05 am, Dharma B - I70843 wrote:
> Converted the text bindings to YAML and validated them individually using following commands
> 
> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> 
> changelogs are available in respective patches.
> 
> As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
> will be sent as separate patch.
> 

I would want to know if I can have the examples in display and pwm 
bindings separately or if I have to delete them from both and have a 
single, comprehensive example in mfd binding. I'm a little puzzled about 
this.

> Dharma Balasubiramani (3):
>    dt-bindings: display: convert Atmel's HLCDC to DT schema
>    dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema
>    dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> 
>   .../atmel/atmel,hlcdc-display-controller.yaml | 85 ++++++++++++++++
>   .../bindings/display/atmel/hlcdc-dc.txt       | 75 --------------
>   .../devicetree/bindings/mfd/atmel,hlcdc.yaml  | 99 +++++++++++++++++++
>   .../devicetree/bindings/mfd/atmel-hlcdc.txt   | 56 -----------
>   .../bindings/pwm/atmel,hlcdc-pwm.yaml         | 44 +++++++++
>   .../bindings/pwm/atmel-hlcdc-pwm.txt          | 29 ------
>   6 files changed, 228 insertions(+), 160 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
>   delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt
>   create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml
>   delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
>   create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
>   delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt
> 

-- 
With Best Regards,
Dharma B.
Rob Herring Feb. 1, 2024, 10:36 p.m. UTC | #3 
On Thu, Feb 01, 2024 at 03:38:37AM +0000, Dharma.B@microchip.com wrote:
> Hi Rob,
> 
> On 31/01/24 9:05 am, Dharma B - I70843 wrote:
> > Converted the text bindings to YAML and validated them individually using following commands
> > 
> > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> > $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> > 
> > changelogs are available in respective patches.
> > 
> > As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
> > will be sent as separate patch.
> > 
> 
> I would want to know if I can have the examples in display and pwm 
> bindings separately or if I have to delete them from both and have a 
> single, comprehensive example in mfd binding. I'm a little puzzled about 
> this.

The strong preference is 1 complete example in the MFD binding. That 
avoids 2 copies of the same thing, issues with incomplete examples, 
and temporary warnings bisecting the series.

Rob
Dharma Balasubiramani Feb. 1, 2024, 11:52 p.m. UTC | #4 
On 02/02/24 4:06 am, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Feb 01, 2024 at 03:38:37AM +0000, Dharma.B@microchip.com wrote:
>> Hi Rob,
>>
>> On 31/01/24 9:05 am, Dharma B - I70843 wrote:
>>> Converted the text bindings to YAML and validated them individually using following commands
>>>
>>> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
>>> $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
>>>
>>> changelogs are available in respective patches.
>>>
>>> As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
>>> will be sent as separate patch.
>>>
>>
>> I would want to know if I can have the examples in display and pwm
>> bindings separately or if I have to delete them from both and have a
>> single, comprehensive example in mfd binding. I'm a little puzzled about
>> this.
> 
> The strong preference is 1 complete example in the MFD binding. That
> avoids 2 copies of the same thing, issues with incomplete examples,
> and temporary warnings bisecting the series.

Sure, I will drop the examples in display and pwm bindings while sending v6.

-- 
Thanks,
Dharma B.

> 
> Rob
Lee Jones Feb. 8, 2024, 10:38 a.m. UTC | #5 
On Wed, 31 Jan 2024 09:05:23 +0530, Dharma Balasubiramani wrote:
> Convert the atmel,hlcdc binding to DT schema format.
> 
> Align clocks and clock-names properties to clearly indicate that the LCD
> controller expects lvds_pll_clk when interfaced with the lvds display. This
> alignment with the specific hardware requirements ensures accurate device tree
> configuration for systems utilizing the HLCDC IP.
> 
> [...]

Applied, thanks!

[3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
      commit: 7dd93269787781869d3dbb23138ec1455d26b047

--
Lee Jones [李琼斯]
Lee Jones Feb. 8, 2024, 10:43 a.m. UTC | #6 
On Thu, 08 Feb 2024, Lee Jones wrote:

> On Wed, 31 Jan 2024 09:05:23 +0530, Dharma Balasubiramani wrote:
> > Convert the atmel,hlcdc binding to DT schema format.
> > 
> > Align clocks and clock-names properties to clearly indicate that the LCD
> > controller expects lvds_pll_clk when interfaced with the lvds display. This
> > alignment with the specific hardware requirements ensures accurate device tree
> > configuration for systems utilizing the HLCDC IP.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
>       commit: 7dd93269787781869d3dbb23138ec1455d26b047

Replaced with v6.