From patchwork Tue Jan 30 23:06:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivor Wanders X-Patchwork-Id: 19695 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1550347dyb; Tue, 30 Jan 2024 15:07:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFu8WBVRHFehElmQK4X92VDDEtHDQzDYAVCwd7tQt9oPPWouLe2wZm44lFvH82vqee0z0K5 X-Received: by 2002:a17:902:e5d1:b0:1d5:eeba:814e with SMTP id u17-20020a170902e5d100b001d5eeba814emr52008plf.18.1706656068691; Tue, 30 Jan 2024 15:07:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706656068; cv=pass; d=google.com; s=arc-20160816; b=DClLG5ldjLnSAQ2eJyXG7Gn5peJhUUfdJ+w+1dVUZ9fKnIIN880/g3Cg9HtKIS5paa x0QEGshPweluzH2AivYPRdNOnFq7TC/lqMAx9qy/NjXmguRd6TgEWMxVXVMYedmu6nGM n9nTvnaWlJ+ikAy8bGvKpdZ1H8uUzz8cDmJwx5SJPlr7eYwsTxxZFB085T9G1NgLEOMf PolRSUBSNXphgn7oLXf/9ESS0h/Wndvv1RnabpSB4T3H6iH77x7QY9PCSsuJvrqwdlc+ FEXjAlT+Mtp4/sHYTrkmgsqRpSZNm8QX1WyO0gb65e5liKWkXLmcvthHUZheYSlG/bxs qOMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from:dkim-signature; bh=2Epf2KC/FEpd6pon/LPvJu29mO0Kvpnb2m/NzsfdKN4=; fh=tmP3r8kdHnjto9t/Q2hyg0WZlGuk2h+t0yEFfDzt3ZM=; b=klAourWTw/ubYdZe1245kk+MfbGbDdj4Mbbx2LCME4YqbXDiPeu3NDMlVtZL7t9Vgc rWCd+fvIlXKs3Mv4OzLLcHv4j1xtXmbTyo1abrvpDyU+FV8B/YFM7DQlMwrcs2suFwTa B3bFzAtVyX2gAXPRegstssGXfkzvM5ibj5Zcj3g01kKieS1zrXYw433bms56ASm1ZX5Z JyX/ZHdVOcrq1HL8/b3V6K7Y0D5+sjJ4UsfP1Q1ySLX3SIa3xhrt+y2yXy7afLgOVEC/ rqqAHAvp+YL6k7sOHpChCE1mQy0l7GM9W1Ee3uvtT6cQtYEPcvQqQsVhl958kuttNwTq tfkA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@iwanders.net header.s=google header.b=EQKtjL97; arc=pass (i=1 spf=pass spfdomain=iwanders.net dkim=pass dkdomain=iwanders.net); spf=pass (google.com: domain of linux-kernel+bounces-45444-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45444-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c11-20020a170903234b00b001d6f7b3f65csi247209plh.43.2024.01.30.15.07.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 15:07:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-45444-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@iwanders.net header.s=google header.b=EQKtjL97; arc=pass (i=1 spf=pass spfdomain=iwanders.net dkim=pass dkdomain=iwanders.net); spf=pass (google.com: domain of linux-kernel+bounces-45444-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-45444-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 474E0B241E7 for ; Tue, 30 Jan 2024 23:07:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C7767AE78; Tue, 30 Jan 2024 23:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b="EQKtjL97" Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C15B7EEFA for ; Tue, 30 Jan 2024 23:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706656029; cv=none; b=UAuJY4VXgJXgnNpmu5iKJlQtMk9bte1Q7YEnGTByDV0N1MswG1HDocPtaSG5hWZwfc3TVjgmpQxVuTMLw9Vl7XM4OtOA63FBTYK2ziBbBYRAMwRm2xDDWrCV3QeWtgR5VQgK9+TiXRn1tiTq+vpxG1w/7hp3REOKF6GPJL3So/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706656029; c=relaxed/simple; bh=Quzl4oZDEPNpjQL8yEy8YSM4ZcrJbwUZ4aOuRk5Xgpk=; h=From:To:Cc:Subject:Date:Message-Id; b=MutxHkAzBJVigHRcj3spW/qjkfvRFXq0KcakjKn1PBMQ5P4h4w7oR1tTRTnosq9MK9ItgnzlQwZNR3w7kgg60qSqCtFNuc8VrNYi5hFaXwMPwddgx/RZaV6pIeyN4peUZK7ZvGay0MNxWDZnvz7XxL+fyJPYoezdUmMKqcG+xYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net; spf=pass smtp.mailfrom=iwanders.net; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b=EQKtjL97; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iwanders.net Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-783ced0216aso318411285a.1 for ; Tue, 30 Jan 2024 15:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iwanders.net; s=google; t=1706656026; x=1707260826; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Epf2KC/FEpd6pon/LPvJu29mO0Kvpnb2m/NzsfdKN4=; b=EQKtjL97eC2GGb+Q4kXM/CDYwMs3dgQ0DBL7c3uZH8aTsgawm4OSRw8A/ujxmv1G1P 6EyzDIRiV8/NCemW5scYphWsDx1L7ZwtF28wP8syXF9JHErqKqccsn24zI6uO7o/TM9l PlW7cB68QGJoE+5x/KE/ryxEWqXD1PdYtqzYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706656026; x=1707260826; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Epf2KC/FEpd6pon/LPvJu29mO0Kvpnb2m/NzsfdKN4=; b=v3xJ8XKJr5uC5QR/suSHxc2KUzkCvU1ZeFgunc3UasbyqnZn85znzmhWAokKmJL6+K ZUyvBWoq3gmBJG9KcKY7+qzsAmGWMgwlMjNwmAgt+WCLEwymbXKMoYx8H1fhl7Rv8C2V uQTtZ8QpRrfNov1tVsQM4MDLFCjVwU5h3r6SVbEp/5C8fTcjRiYQtbWnTedPrnUalUS0 51aH+1Tjt0JEFVNJPgEzsf4Ifhkkzblkb8KphpZSGX98HrYfJF8C7wSCd0g/NX/aECRM HLJ9l7JU9/8eQAeKtIkHU3iTMDoOVFHMlJzoRzRGDd5oaAsBjs10U38thPho2+xNe+t3 pTIg== X-Gm-Message-State: AOJu0YzZUNooDjrt1RHOW1YdhgAtjwuoKgxA8IqNDiE8J5tosye98ett +SS6LcE9wrusI96tyNwBZ0r7+61wd+7TNg6PhW8prvQYmv12X6MpMadl6OxRfgw= X-Received: by 2002:a05:6214:1d0a:b0:68c:360e:ca with SMTP id e10-20020a0562141d0a00b0068c360e00camr10305479qvd.57.1706656026093; Tue, 30 Jan 2024 15:07:06 -0800 (PST) Received: from eagle.lan (24-246-30-234.cable.teksavvy.com. [24.246.30.234]) by smtp.gmail.com with ESMTPSA id di8-20020ad458e8000000b0068c47832171sm3081275qvb.65.2024.01.30.15.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 15:07:05 -0800 (PST) From: Ivor Wanders To: Jean Delvare , Guenter Roeck , Jonathan Corbet , Maximilian Luz , Ivor Wanders , Hans de Goede , Mark Gross Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v4 0/2] Surface fan monitoring driver Date: Tue, 30 Jan 2024 18:06:52 -0500 Message-Id: <20240130230654.4218-1-ivor@iwanders.net> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789558594231103934 X-GMAIL-MSGID: 1789558594231103934 Fourth version of a hwmon driver to monitor the fan's rpm on Microsoft Surface devices, originally submitted in [1], v2 at [2], v3 at [3]. Changes since v3 are two minor code changes based on feedback. Changes in v4: - Return 0 from surface_fan_hwmon_read instead of ret. - Use PTR_ERR_OR_ZERO in probe instead of if statement. Changes in v3: - Removed type and attr checks in read and is_visible. - Removed assigning sdev to ssam_device drvdata. - Propagate return from __ssam_fan_rpm_get. - Renamed hwmon chip name from 'fan' to 'surface_fan'. - Removed unnecessary platform_device header. Changes in v2: - Removed all unsupported sysfs attributes from the hwmon driver, leaving the fan input as the only supported attribute. [1] https://lore.kernel.org/linux-hwmon/20231220234415.5219-1-ivor@iwanders.net/T/ [2] https://lore.kernel.org/linux-hwmon/20231228003444.5580-1-ivor@iwanders.net/T/ [3] https://lore.kernel.org/linux-hwmon/20240113183306.9566-1-ivor@iwanders.net/T/ Ivor Wanders (2): platform/surface: aggregator_registry: add entry for fan speed hwmon: add fan speed monitoring driver for Surface devices Documentation/hwmon/index.rst | 1 + Documentation/hwmon/surface_fan.rst | 25 +++++ MAINTAINERS | 8 ++ drivers/hwmon/Kconfig | 13 +++ drivers/hwmon/Makefile | 1 + drivers/hwmon/surface_fan.c | 91 +++++++++++++++++++ .../surface/surface_aggregator_registry.c | 7 ++ 7 files changed, 146 insertions(+) create mode 100644 Documentation/hwmon/surface_fan.rst create mode 100644 drivers/hwmon/surface_fan.c