From patchwork Tue Jan 30 10:04:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 19658 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1112637dyb; Tue, 30 Jan 2024 02:06:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkq6Kb1hFlfcvhooP/Xbxod8qXabZ5tOsyT9jpL3AeXaDD5Z3zEebC4dw7ouyGNq+ixPtQ X-Received: by 2002:a05:622a:148d:b0:42a:aab5:4d4 with SMTP id t13-20020a05622a148d00b0042aaab504d4mr991867qtx.4.1706609212452; Tue, 30 Jan 2024 02:06:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706609212; cv=pass; d=google.com; s=arc-20160816; b=vQcG4uGVinf+EHM1rP0VPT7/myMtlIyq/v6s4M2S4k5c8E391HO7jqBVyYhKcJCc62 5LeNbRpFRfTZisj7tuaH6SleP/CnAqjyWeR3W4F7P55iCn4FHeVgWVlInmlxAcnbDfFi UWcUI98GiXUgCV7XPPULYBWzw53crdkCbF0Zpk4EQCfmcJuFlCzb+YqvGKlXmFHbwi/K lcTF4OkAQfe5rniAFfAUBQz5mAzriO1SE1QOp7JdKIuRJmlnVtF4PURRmP/ynCckkZUB lV6Bdw9XxIpsbwy6gXvRgafmDUBfZqfZfII6Pr4nBL0tritWne6/QeZbkfxHXB4ughMK IiUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:feedback-id:dkim-signature:dkim-signature; bh=vkYxaFes1oZgW4Bo/+u9h7Rx+x8nZ07dK3dg7jhwa6E=; fh=29+NP+Avo3KW5WAFiPrv+jdOjQZBDMQJMXZlHI+I9m4=; b=X7+njHG25S96Li6Y7KhePON5T+uOTk0WoYAfB/pYIS1MbBgrKAVTg7GVw3R8GxPx8M FodWO//1zI+eMLadvPeD9WFt2ML1AOsGbl2uwfzUuFjdnooLMRVq07Fa5Yv4P/kaEJnp W75Z5YtCJ7QA9EZUGmgA2L0WoVKKm3rriBNK5cUZ+MUXgqRqsanhzQJEmwkOFdEuD1LB 4HKFjP2oggXMWBXKqpbvsgOYgnoI3uyFIs0wKgmy3ccHLNtmCnEEAZ21zLj1WL/CIvwy 2RjzRMd1FV8Xvdc5aHjalD19dWwVgBWeyQxO+95XGVj7DswAUPR0gUHWFiaLPH1w4X3J 8IOQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm3 header.b=P+3lV22C; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=dBO9EM4Y; arc=pass (i=1 spf=pass spfdomain=sakamocchi.jp dkim=pass dkdomain=sakamocchi.jp dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sakamocchi.jp); spf=pass (google.com: domain of linux-kernel+bounces-44348-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44348-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f18-20020ac85d12000000b0042a99face24si6042452qtx.795.2024.01.30.02.06.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 02:06:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44348-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sakamocchi.jp header.s=fm3 header.b=P+3lV22C; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=dBO9EM4Y; arc=pass (i=1 spf=pass spfdomain=sakamocchi.jp dkim=pass dkdomain=sakamocchi.jp dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sakamocchi.jp); spf=pass (google.com: domain of linux-kernel+bounces-44348-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44348-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sakamocchi.jp Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D19551C27242 for ; Tue, 30 Jan 2024 10:06:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED3DE67A1F; Tue, 30 Jan 2024 10:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="P+3lV22C"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="dBO9EM4Y" Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA6057867 for ; Tue, 30 Jan 2024 10:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706609059; cv=none; b=MyilJukOesmzGJ969j2TN1/MyHjsCtGNo0SJtKVICJ5b62inaBVoHg+/eOKb/vGaU1ijCTAqCcjIy5mrg319Xj7F9elWV6z/PolmCZpg5DfwJTz6AMtEv33e2gqUtzgK2oFLWO5XP33MeFQFZjBFXDOzlXlKoK0srVRN4kxYdkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706609059; c=relaxed/simple; bh=3w8BIDNYwmsOMQgds+zKKQvqmE+c39tBnyoZ0jKXAuE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=fPZ/gYKZeO2b4t6kwQ5TjKfjQ2phWa74452cxz1JN83KloV7lS7iFEBrrndLZkbJuTMrrtt/RF2TTvz7eIa1aKcugz307nEt9P97IzrP4vLbIUW4oE5gjoniRQL1Xk266YF/mlyRsuElWhkQFeSrrJzZi/rOSsYO0lKReVL/YWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=P+3lV22C; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=dBO9EM4Y; arc=none smtp.client-ip=64.147.123.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 441433200B3B; Tue, 30 Jan 2024 05:04:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 30 Jan 2024 05:04:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm3; t=1706609054; x=1706695454; bh=vkYxaFes1o ZgW4Bo/+u9h7Rx+x8nZ07dK3dg7jhwa6E=; b=P+3lV22CLGLfCDfpvDORyKC7Hc QoBR3AGzjqhAPXOKM28UfXvq7hR+uHFl5HUiKR97N9slT02UbDp2aWjDNsy+sBqE mNfBcjMmLEZxjnQWeCBL7L/iBDr3IkOpUQdtUDRiHumnLFaRjtx9N+hHtq/Xd+tp 6uSGldMzuoZWkzKxk+/VfqXqC/7xcxx+f2tID4LNXDrOFjPh5IrB6GRvkzo7JHjw lNgAiZvE3yT18PcnUpyFiQ+0HxcCWf8LV1IkV2iN8CVMWyDK2UNBTebwcfA3TA9G qNMji/VDodSLSUF00aQa3+e4Chb571joenbA0ewd3PDaB4Z+pDDcLuSvbX/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1706609054; x=1706695454; bh=vkYxaFes1oZgW4Bo/+u9h7Rx+x8n Z07dK3dg7jhwa6E=; b=dBO9EM4YWxLTID2Y2gGjFNZi5YJ/s/tWtZ+afCI5RhLP YAxoGO6bqgNb2uKsV0zaRnHL//DT+BWT9hmw1kablSuk54H6igXWodPP1fN+WoVc j/FeXrgjspA1wa0nX8kMVTFOtbPmmRB9pc3pIJzS8DxptowSnWXHTUU+o70YSMaK foXZhioTC/daH0BITGocVwVt5+Sxm1xRXTWaY7HRxdsx0u0PoIQ55TM+AdypnnmI 9E+Sk/3QN8su/dS3i8JPgfWBACQGO10FpTpCzBeI6Pijkw43HwXNuzRCIKcswpPK EC0gXoEFjOXR0/kC35ZM10d02nuab0MFt3pu6U0EDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedtiedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpeeukeegvefgie ehfefhtdethfevjefghfeileehffefgedugeeigfduhfekgeehueenucffohhmrghinhep khgvrhhnvghlrdhorhhgpdgrrhgthhhivhgvrdhorhhgpddufeelgehtrgdrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghk rghshhhisehsrghkrghmohgttghhihdrjhhp X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Jan 2024 05:04:13 -0500 (EST) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: adamg@pobox.com Subject: [PATCH 0/2] firewire: core: optimization for the quirk of Sony DVMC-DA1 Date: Tue, 30 Jan 2024 19:04:07 +0900 Message-Id: <20240130100409.30128-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789509462016304065 X-GMAIL-MSGID: 1789509462016304065 Hi, A quirk was reported that Sony DVMC-DA1 has a quirk in its configuration ROM[1]. It has the legacy layout of configuration ROM[2] with the quirk that the descriptor leaf entry locates just after the vendor directory entry in its root directory. It is not the layout in the documentation since the usual descriptor leaf entry locates just after the vendor immediate entry. Current implementation of firewire-core fail to pick up the content of descriptor leaf for vendor name. This series of changes is to optimize for the quirk, including a slight correction of documentation for the relevant kernel API. The changes are written to be accepted to the release candidates of v6.8 so that they don't conflict to the changes in for-next branch[3], thus they do not necessarily have a good look. [1] https://lore.kernel.org/lkml/20240126011705.GA22564@workstation.local/ [2] Configuration ROM for AV/C Devices 1.0 (1394 Trading Association, Dec 2000, TA Document 1999027) https://web.archive.org/web/20210216003030/http://1394ta.org/wp-content/uploads/2015/07/1999027.pdf [3] https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git/log/?h=for-next Takashi Sakamoto (2): firewire: core: correct documentation of fw_csr_string() kernel API firewire: core: search descriptor leaf just after vendor directory entry in root directory drivers/firewire/core-device.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)