Message ID | 20240129162737.497-1-rf@opensource.cirrus.com |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-43079-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp680875dyb; Mon, 29 Jan 2024 08:28:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSBvEmU+6gLjUNtrst4zpmAgTRpTwtVAJ73d7CYqnf66H3gWI+dKCELxNkLSE7CsNIuOX4 X-Received: by 2002:a17:906:489:b0:a35:ad04:dcb7 with SMTP id f9-20020a170906048900b00a35ad04dcb7mr2559831eja.17.1706545736392; Mon, 29 Jan 2024 08:28:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706545736; cv=pass; d=google.com; s=arc-20160816; b=obd+pswkkkipZH3HG3TubEYbRBvLRt9muEjL8nO5Vb7+Ut5TPVdoWMAYA24cYQtWVA H0Wzwj/P45q/a9FN7qtzWbqNDN7VUvVxCUGfYc8FRxWNsjI/FBSkviMYUSSMHY8cwNU2 sT/Fc6nbnY/rNyzYHcTXDpMCDINPOqccsTIf4CxaJJdkITCemS13VaJVdIaBbfBNw4D9 4MXeezxzWaFSXoVJePsgoryFhrQZbgb/t4AWtxgPYUM7nAgEKgwJIg52xdOtItUCiMh8 hUx6Ka6E2n0SI0leWRt6Qz5nmHCtRL8oeBbtui3xGJW0r/16kMlOjjSk1KMdr4Dn9vqt MYnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=aCQsG4ebcLQxKipcjMk5BfNAvFtIBi4e0wtIsxuP2ok=; fh=HmcxfOiRAhfdLjKRtDyRjTtuYfcotLlCNOFSdqEobBY=; b=G6HWxyw4AJ9pewPt/cCe2KlQCjRfq2L4f5bRolO20dRpmFpGP8tE+knPP6Utv7v8Vh 6KSAnAmwQuMWlBjzGJhsJzZ3VB5uI/U9OhZJA4R6JycmjnUAvA9VwI8HLM/uj7fA4mEa 9rFIK7auU44GAIflTLMec7SCXxRR34FvecVThzhedebTPREBBIR1XRuoNzyFC0w8dluQ lTuEV8G3z3imOg2Ctz8BjULCELMihPb64mXD1row8aROrhamsaOBOHNwr54fnfUaSfVq pg3thmQd+vkI9yNog4mENTC/W9UmMwxs3YkxxtCunP2bkbAm6111KFTT/VwmKwTfcKcj 9SJg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=XjZ1HhLi; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-43079-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43079-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id oq27-20020a170906cc9b00b00a3173f6e10fsi3309202ejb.526.2024.01.29.08.28.56 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 08:28:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43079-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=XjZ1HhLi; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-43079-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43079-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 094A21F236B5 for <ouuuleilei@gmail.com>; Mon, 29 Jan 2024 16:28:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25558157E6D; Mon, 29 Jan 2024 16:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="XjZ1HhLi" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57093155A22; Mon, 29 Jan 2024 16:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706545680; cv=none; b=GvZFAUraY6wgSNGLEcQkoS4D8JlEwQ0SvJHB3fWZe3+VNufBve40dUJUN6au3eQsm9DCmylVgiKI7CY3X/4i/22MmFNGrDreWW2/0fsHziwe+wwbgHv3MTxYoMvdLhxdvmYGpswO0YWtTLQkTGvsMhHYPKimQ+HxVYQ9THPepOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706545680; c=relaxed/simple; bh=e+rapD5MF44xsQTrTn9qUAudkjaAvRtI+XztleK2lHQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=TIOfNtw8DekK+YM44E6QSuAlaXqRDlE82Fm1KZggIc/yHGhsFxBXqBQtKM+fnjhgPUYX10u0GVLBdW5KJv3f9g2DC8LWmKRkVOjyQmdXlr08kSKI7e6pRHHSQ5HBgnVe1JXYEOPaLj5F1DCcZHciTpO6x3InasyNNccHWKSnqEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=XjZ1HhLi; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40T5fM05006968; Mon, 29 Jan 2024 10:27:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=a CQsG4ebcLQxKipcjMk5BfNAvFtIBi4e0wtIsxuP2ok=; b=XjZ1HhLiocUBrOojM Sumd7SwnGBW5+3iePaXnwJPiacXJwhlM3PB2RqI6REVlvIRvxtZ4gJoAN7aTYDsZ uKFjRX7KJE6lx/BlDMIxBQSLQUT0B+Mn8/BJSfMP3rcBiTmWJ2uHtWSQIZEkXbN7 cH9fGTgcjy3+6v1P0EiLIXpwgonDhFiYFx1StxNiESS72Qjeq4tGnpmHyqOcr6D2 iAEmTHlNX6vq0iMBEdxSRnnOLu10hXQu4+xipHw0Nw7qFGIEd6M2/vZQpy6dC99L m5ao/+vLuqi12NOImgxa1FV2NvI6Tz47hz29bPkU+Mdfi1tv6d2hlMc210NKizXb /nENw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vvy4nta8n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 10:27:48 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 29 Jan 2024 16:27:41 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Mon, 29 Jan 2024 16:27:41 +0000 Received: from EDIN4L06LR3.ad.cirrus.com (EDIN4L06LR3.ad.cirrus.com [198.61.64.204]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 6034C820242; Mon, 29 Jan 2024 16:27:41 +0000 (UTC) From: Richard Fitzgerald <rf@opensource.cirrus.com> To: <broonie@kernel.org>, <tiwai@suse.com> CC: <alsa-devel@alsa-project.org>, <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>, "Richard Fitzgerald" <rf@opensource.cirrus.com> Subject: [PATCH 00/18] ALSA: Various fixes for Cirrus Logic CS35L56 support Date: Mon, 29 Jan 2024 16:27:19 +0000 Message-ID: <20240129162737.497-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: Czor6TjL5qqxOUvlzQ_yyk5U4tgj7Dxb X-Proofpoint-GUID: Czor6TjL5qqxOUvlzQ_yyk5U4tgj7Dxb X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789442902152548083 X-GMAIL-MSGID: 1789442902152548083 |
Series |
ALSA: Various fixes for Cirrus Logic CS35L56 support
|
|
Message
Richard Fitzgerald
Jan. 29, 2024, 4:27 p.m. UTC
This chain of patches fixes various things that were undocumented, unknown or uncertain when the original driver code was written. And also a few things that were just bugs. The HDA patches have dependencies on the ASoC patches, except for the final patch that removes a bogus test stub function. Richard Fitzgerald (18): ASoC: wm_adsp: Fix firmware file search order ASoC: wm_adsp: Don't overwrite fwf_name with the default ASoC: cs35l56: cs35l56_component_remove() must clear cs35l56->component ASoC: cs35l56: cs35l56_component_remove() must clean up wm_adsp ASoC: cs35l56: Don't add the same register patch multiple times ASoC: cs35l56: Remove buggy checks from cs35l56_is_fw_reload_needed() ASoC: cs35l56: Fix to ensure ASP1 registers match cache ASoC: cs35l56: Fix default SDW TX mixer registers ALSA: hda: cs35l56: Initialize all ASP1 registers ASoC: cs35l56: Fix for initializing ASP1 mixer registers ASoC: cs35l56: Fix misuse of wm_adsp 'part' string for silicon revision ASoC: cs35l56: Firmware file must match the version of preloaded firmware ASoC: cs35l56: Load tunings for the correct speaker models ASoC: cs35l56: Allow more time for firmware to boot ALSA: hda: cs35l56: Fix order of searching for firmware files ALSA: hda: cs35l56: Fix filename string field layout ALSA: hda: cs35l56: Firmware file must match the version of preloaded firmware ALSA: hda: cs35l56: Remove unused test stub function include/sound/cs35l56.h | 7 +- sound/pci/hda/cs35l56_hda.c | 138 ++++++++------ sound/soc/codecs/cs35l56-shared.c | 140 ++++++++++++-- sound/soc/codecs/cs35l56.c | 307 +++++++++++++++++++++++++----- sound/soc/codecs/cs35l56.h | 2 + sound/soc/codecs/wm_adsp.c | 73 +++---- 6 files changed, 498 insertions(+), 169 deletions(-)
Comments
On Mon, Jan 29, 2024 at 04:27:19PM +0000, Richard Fitzgerald wrote: > This chain of patches fixes various things that were undocumented, unknown > or uncertain when the original driver code was written. And also a few > things that were just bugs. > > The HDA patches have dependencies on the ASoC patches, except for the final > patch that removes a bogus test stub function. Takashi, should I apply the ALSA bits of this via ASoC?
On Thu, 01 Feb 2024 13:47:38 +0100, Mark Brown wrote: > > On Mon, Jan 29, 2024 at 04:27:19PM +0000, Richard Fitzgerald wrote: > > This chain of patches fixes various things that were undocumented, unknown > > or uncertain when the original driver code was written. And also a few > > things that were just bugs. > > > > The HDA patches have dependencies on the ASoC patches, except for the final > > patch that removes a bogus test stub function. > > Takashi, should I apply the ALSA bits of this via ASoC? Judging from the amount, better to go through your tree. Please go ahead. thanks, Takashi
On Mon, 29 Jan 2024 16:27:19 +0000, Richard Fitzgerald wrote: > This chain of patches fixes various things that were undocumented, unknown > or uncertain when the original driver code was written. And also a few > things that were just bugs. > > The HDA patches have dependencies on the ASoC patches, except for the final > patch that removes a bogus test stub function. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [01/18] ASoC: wm_adsp: Fix firmware file search order commit: 3657e4cb5a8abd9edf6c944e022fe9ef06989960 [02/18] ASoC: wm_adsp: Don't overwrite fwf_name with the default commit: daf3f0f99cde93a066240462b7a87cdfeedc04c0 [03/18] ASoC: cs35l56: cs35l56_component_remove() must clear cs35l56->component commit: ae861c466ee57e15a29d97629e1c564e3f714a4f [04/18] ASoC: cs35l56: cs35l56_component_remove() must clean up wm_adsp commit: cd38ccbecdace1469b4e0cfb3ddeec72a3fad226 [05/18] ASoC: cs35l56: Don't add the same register patch multiple times commit: 07687cd0539f8185b6ba0c0afba8473517116d6a [06/18] ASoC: cs35l56: Remove buggy checks from cs35l56_is_fw_reload_needed() commit: 3739cc0733ba7eeafc08d4d4208d1f3c2451eabd [07/18] ASoC: cs35l56: Fix to ensure ASP1 registers match cache commit: 72a77d7631c6e392677c0134343cf5edcd3a4572 [08/18] ASoC: cs35l56: Fix default SDW TX mixer registers commit: 782e6c538be43a17e34f552ab49e8c713cac7883 [09/18] ALSA: hda: cs35l56: Initialize all ASP1 registers commit: 856ce8982169acb31a25c5f2ecd2570ab8a6af46 [10/18] ASoC: cs35l56: Fix for initializing ASP1 mixer registers commit: 07f7d6e7a124d3e4de36771e2a4926d0e31c2258 [11/18] ASoC: cs35l56: Fix misuse of wm_adsp 'part' string for silicon revision commit: f6c967941c5d6fa526fdd64733a8d86bf2bfab31 [12/18] ASoC: cs35l56: Firmware file must match the version of preloaded firmware commit: f4ef5149953f2fc04907ca5b34db3df667dcddef [13/18] ASoC: cs35l56: Load tunings for the correct speaker models commit: 245eeff18d7a37693815250ae15979ce98c3d190 [14/18] ASoC: cs35l56: Allow more time for firmware to boot commit: 9e92b77ceb6f362eb2e7995dad6c7f9863053d97 [15/18] ALSA: hda: cs35l56: Fix order of searching for firmware files commit: 77c60722ded7d6739805e045e9648cda82dde5ed [16/18] ALSA: hda: cs35l56: Fix filename string field layout commit: e82bc517c6ef5d5c04b845420406e694c31bdb8a [17/18] ALSA: hda: cs35l56: Firmware file must match the version of preloaded firmware commit: 6f8ad0480d82245961dae4d3280908611633872d [18/18] ALSA: hda: cs35l56: Remove unused test stub function commit: 28876c1ae8b8cd1dacef50bd6c0555824774f0d2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark