mbox series

[v1,0/4] Support HP Models without _DSD

Message ID 20240126113007.4084-1-sbinding@opensource.cirrus.com
Headers
Series Support HP Models without _DSD |

Message

Stefan Binding Jan. 26, 2024, 11:30 a.m. UTC 
  Add Quirks and driver properties for Dell models.
Driver properties are required since these models do not have _DSD.
Some models require special handing for Speaker ID and cannot use
the configuration table to add properties.
Also fix an issue for Channel Index property, when set through the
configuration table, to use the same method as when loading _DSD
properties. This is needed for laptops with 4 amps where the
channels do not alternate.

Stefan Binding (4):
  ALSA: hda: cs35l41: Set Channel Index correctly when system is missing
    _DSD
  ALSA: hda: cs35l41: Support additional HP Envy Models
  ALSA: hda: cs35l41: Support HP models without _DSD using dual Speaker
    ID
  ALSA: hda/realtek: Add quirks for various HP ENVY models

 sound/pci/hda/cs35l41_hda_property.c | 90 +++++++++++++++++++++++-----
 sound/pci/hda/patch_realtek.c        | 40 +++++++++++++
 2 files changed, 114 insertions(+), 16 deletions(-)

Comments

Takashi Iwai Jan. 26, 2024, 3:14 p.m. UTC | #1 
On Fri, 26 Jan 2024 12:30:03 +0100,
Stefan Binding wrote:
> 
> Add Quirks and driver properties for Dell models.
> Driver properties are required since these models do not have _DSD.
> Some models require special handing for Speaker ID and cannot use
> the configuration table to add properties.
> Also fix an issue for Channel Index property, when set through the
> configuration table, to use the same method as when loading _DSD
> properties. This is needed for laptops with 4 amps where the
> channels do not alternate.
> 
> Stefan Binding (4):
>   ALSA: hda: cs35l41: Set Channel Index correctly when system is missing
>     _DSD
>   ALSA: hda: cs35l41: Support additional HP Envy Models
>   ALSA: hda: cs35l41: Support HP models without _DSD using dual Speaker
>     ID
>   ALSA: hda/realtek: Add quirks for various HP ENVY models

The last one conflicts with the latest for-next branch due to the
recent change from Cirrus.  Could you rebase and resubmit?


thanks,

Takashi
Richard Fitzgerald Jan. 26, 2024, 3:44 p.m. UTC | #2 
On 26/01/2024 15:14, Takashi Iwai wrote:
> On Fri, 26 Jan 2024 12:30:03 +0100,
> Stefan Binding wrote:
>>
>> Add Quirks and driver properties for Dell models.
>> Driver properties are required since these models do not have _DSD.
>> Some models require special handing for Speaker ID and cannot use
>> the configuration table to add properties.
>> Also fix an issue for Channel Index property, when set through the
>> configuration table, to use the same method as when loading _DSD
>> properties. This is needed for laptops with 4 amps where the
>> channels do not alternate.
>>
>> Stefan Binding (4):
>>    ALSA: hda: cs35l41: Set Channel Index correctly when system is missing
>>      _DSD
>>    ALSA: hda: cs35l41: Support additional HP Envy Models
>>    ALSA: hda: cs35l41: Support HP models without _DSD using dual Speaker
>>      ID
>>    ALSA: hda/realtek: Add quirks for various HP ENVY models
> 
> The last one conflicts with the latest for-next branch due to the
> recent change from Cirrus.  Could you rebase and resubmit?
> 

Yes, sorry. That's my fault for not syncing up with Stefan before
sending the other patch.